@ag-grid-enterprise/rich-select - npm Package Compare versions

Comparing version 22.1.1 to 23.0.0

dist/cjs/richSelect/richSelectCellEditor.js

@@ -37,4 +37,6 @@ "use strict";
         this.focusAfterAttached = params.cellStartedEdit;
-        this.eValue.appendChild(core_1._.createIconNoSpan('smallDown', this.gridOptionsWrapper));
-        this.virtualList = new core_1.VirtualList();
+        var icon = core_1._.createIconNoSpan('smallDown', this.gridOptionsWrapper);
+        core_1._.addCssClass(icon, 'ag-rich-select-value-icon');
+        this.eValue.appendChild(icon);
+        this.virtualList = new core_1.VirtualList('rich-select');
         this.getContext().wireBean(this.virtualList);
@@ -84,4 +86,4 @@ this.virtualList.setComponentCreator(this.createRowComponent.bind(this));
     RichSelectCellEditor.prototype.onNavigationKeyPressed = function (event, key) {
-        // if we don't stop propagation, then the grids navigation kicks in
-        event.stopPropagation();
+        // if we don't preventDefault the page body and/or grid scroll will move.
+        event.preventDefault();
         var oldIndex = this.params.values.indexOf(this.selectedValue);
@@ -88,0 +90,0 @@ var newIndex = key === core_1.Constants.KEY_UP ? oldIndex - 1 : oldIndex + 1;

dist/es6/richSelect/richSelectCellEditor.js

@@ -35,4 +35,6 @@ var __extends = (this && this.__extends) || (function () {
         this.focusAfterAttached = params.cellStartedEdit;
-        this.eValue.appendChild(_.createIconNoSpan('smallDown', this.gridOptionsWrapper));
-        this.virtualList = new VirtualList();
+        var icon = _.createIconNoSpan('smallDown', this.gridOptionsWrapper);
+        _.addCssClass(icon, 'ag-rich-select-value-icon');
+        this.eValue.appendChild(icon);
+        this.virtualList = new VirtualList('rich-select');
         this.getContext().wireBean(this.virtualList);
@@ -82,4 +84,4 @@ this.virtualList.setComponentCreator(this.createRowComponent.bind(this));
     RichSelectCellEditor.prototype.onNavigationKeyPressed = function (event, key) {
-        // if we don't stop propagation, then the grids navigation kicks in
-        event.stopPropagation();
+        // if we don't preventDefault the page body and/or grid scroll will move.
+        event.preventDefault();
         var oldIndex = this.params.values.indexOf(this.selectedValue);
@@ -86,0 +88,0 @@ var newIndex = key === Constants.KEY_UP ? oldIndex - 1 : oldIndex + 1;

package.json

 {
   "name": "@ag-grid-enterprise/rich-select",
-  "version": "22.1.1",
+  "version": "23.0.0",
   "description": "Advanced Data Grid / Data Table supporting Javascript / React / AngularJS / Web Components",
   "main": "./dist/cjs/main.js",
   "module": "./dist/es6/main.js",
-  "types": "./dist/es6/main.d.ts",
+  "types": "./dist/cjs/main.d.ts",
   "scripts": {
@@ -44,4 +44,4 @@ "build-cjs": "tsc -p tsconfig.json",
   "dependencies": {
-    "@ag-grid-community/core": "~22.1.1",
-    "@ag-grid-enterprise/core": "~22.1.1"
+    "@ag-grid-community/core": "~23.0.0",
+    "@ag-grid-enterprise/core": "~23.0.0"
   },
@@ -48,0 +48,0 @@ "devDependencies": {

README.md

@@ -13,3 +13,3 @@
 
-[Angular 1](https://www.ag-grid.com/angular-grid/) | [Angular 2](https://www.ag-grid.com/angular-grid/) | [Javascript](https://www.ag-grid.com/javascript-grid/) | [Polymer](https://www.ag-grid.com/best-polymer-data-grid/) | [React](https://www.ag-grid.com/react-grid/) | [TypeScript](https://www.ag-grid.com/ag-grid-typescript-webpack-2/) | [VueJS](https://www.ag-grid.com/vuejs-grid/) | [Web Components](https://www.ag-grid.com/best-web-component-data-grid/) | [Aurelia](https://www.ag-grid.com/best-aurelia-data-grid/) 
+[Angular 1](https://www.ag-grid.com/angular-grid/) | [Angular 2](https://www.ag-grid.com/angular-grid/) | [Javascript](https://www.ag-grid.com/javascript-grid/) | [Polymer](https://www.ag-grid.com/best-polymer-data-grid/) | [React](https://www.ag-grid.com/react-grid/) | [TypeScript](https://www.ag-grid.com/ag-grid-building-typescript/) | [VueJS](https://www.ag-grid.com/vuejs-grid/) | [Web Components](https://www.ag-grid.com/best-web-component-data-grid/) | [Aurelia](https://www.ag-grid.com/best-aurelia-data-grid/) 
 
@@ -16,0 +16,0 @@ This is not free software, this software is covered by copyright and to use you need a commercial license.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5158159

increased by2.62%

Lines of code

81606

increased by2.34%

Dependency changes

• + Added@ag-grid-community/core@23.0.2(transitive)

• + Added@ag-grid-enterprise/core@23.0.2(transitive)

• - Removed@ag-grid-community/core@22.1.1(transitive)

• - Removed@ag-grid-enterprise/core@22.1.1(transitive)

• Updated@ag-grid-community/core@~23.0.0

• Updated@ag-grid-enterprise/core@~23.0.0