@airtable/eslint-plugin-blocks - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

lib/rules/no-error-interpolation.js

@@ -1,3 +0,121 @@
-const getPropertyName = require('eslint/lib/rules/utils/ast-utils').getStaticPropertyName;
+// isNullLiteral, getStaticStringValue and getStaticPropertyName are taken from
+// https://github.com/eslint/eslint/blob/fd3683f/lib/rules/utils/ast-utils.js#L15ß0-L290
 
+/**
+ * Determines whether the given node is a `null` literal.
+ * @param {ASTNode} node The node to check
+ * @returns {boolean} `true` if the node is a `null` literal
+ */
+function isNullLiteral(node) {
+    /*
+     * Checking `node.value === null` does not guarantee that a literal is a null literal.
+     * When parsing values that cannot be represented in the current environment (e.g. unicode
+     * regexes in Node 4), `node.value` is set to `null` because it wouldn't be possible to
+     * set `node.value` to a unicode regex. To make sure a literal is actually `null`, check
+     * `node.regex` instead. Also see: https://github.com/eslint/eslint/issues/8020
+     */
+    return node.type === 'Literal' && node.value === null && !node.regex && !node.bigint;
+}
+
+/**
+ * Returns the result of the string conversion applied to the evaluated value of the given expression node,
+ * if it can be determined statically.
+ *
+ * This function returns a `string` value for all `Literal` nodes and simple `TemplateLiteral` nodes only.
+ * In all other cases, this function returns `null`.
+ * @param {ASTNode} node Expression node.
+ * @returns {string|null} String value if it can be determined. Otherwise, `null`.
+ */
+function getStaticStringValue(node) {
+    switch (node.type) {
+        case 'Literal':
+            if (node.value === null) {
+                if (isNullLiteral(node)) {
+                    return String(node.value); // "null"
+                }
+                if (node.regex) {
+                    return `/${node.regex.pattern}/${node.regex.flags}`;
+                }
+                if (node.bigint) {
+                    return node.bigint;
+                }
+
+                // Otherwise, this is an unknown literal. The function will return null.
+            } else {
+                return String(node.value);
+            }
+            break;
+        case 'TemplateLiteral':
+            if (node.expressions.length === 0 && node.quasis.length === 1) {
+                return node.quasis[0].value.cooked;
+            }
+            break;
+
+        // no default
+    }
+
+    return null;
+}
+
+/**
+ * Gets the property name of a given node.
+ * The node can be a MemberExpression, a Property, or a MethodDefinition.
+ *
+ * If the name is dynamic, this returns `null`.
+ *
+ * For examples:
+ *
+ *     a.b           // => "b"
+ *     a["b"]        // => "b"
+ *     a['b']        // => "b"
+ *     a[`b`]        // => "b"
+ *     a[100]        // => "100"
+ *     a[b]          // => null
+ *     a["a" + "b"]  // => null
+ *     a[tag`b`]     // => null
+ *     a[`${b}`]     // => null
+ *
+ *     let a = {b: 1}            // => "b"
+ *     let a = {["b"]: 1}        // => "b"
+ *     let a = {['b']: 1}        // => "b"
+ *     let a = {[`b`]: 1}        // => "b"
+ *     let a = {[100]: 1}        // => "100"
+ *     let a = {[b]: 1}          // => null
+ *     let a = {["a" + "b"]: 1}  // => null
+ *     let a = {[tag`b`]: 1}     // => null
+ *     let a = {[`${b}`]: 1}     // => null
+ * @param {ASTNode} node The node to get.
+ * @returns {string|null} The property name if static. Otherwise, null.
+ */
+function getStaticPropertyName(node) {
+    let prop;
+
+    switch (node && node.type) {
+        case 'ChainExpression':
+            return getStaticPropertyName(node.expression);
+
+        case 'Property':
+        case 'PropertyDefinition':
+        case 'MethodDefinition':
+            prop = node.key;
+            break;
+
+        case 'MemberExpression':
+            prop = node.property;
+            break;
+
+        // no default
+    }
+
+    if (prop) {
+        if (prop.type === 'Identifier' && !node.computed) {
+            return prop.name;
+        }
+
+        return getStaticStringValue(prop);
+    }
+
+    return null;
+}
+
 function getNodeName(node) {
@@ -7,3 +125,3 @@ if (node.type === 'Identifier') {
     }
-    return getPropertyName(node);
+    return getStaticPropertyName(node);
 }
@@ -35,3 +153,4 @@
                         node.arguments[messageArgumentIndex] &&
-                        node.arguments[messageArgumentIndex].type === 'TemplateLiteral'
+                        node.arguments[messageArgumentIndex].type === 'TemplateLiteral' &&
+                        node.arguments[messageArgumentIndex].quasis.length > 1
                     ) {
@@ -38,0 +157,0 @@ context.report({

package.json

 {
     "name": "@airtable/eslint-plugin-blocks",
-    "version": "1.0.2",
+    "version": "1.0.3",
     "description": "An eslint plugin used by Airtable to develop the blocks SDK and our own blocks",
@@ -14,3 +14,5 @@ "main": "lib/index.js",
     "scripts": {
-        "test": "mocha 'test/**/*.js'"
+        "ci": "yarn run test",
+        "test": "mocha 'test/**/*.js'",
+        "release": "npm_config_registry=https://registry.npmjs.org/ release-it"
     },
@@ -22,3 +24,14 @@ "devDependencies": {
     },
-    "gitHead": "8fa958a5a4c49933e5190049a9be44ec4d601f42"
+    "release-it": {
+        "git": {
+            "tagName": "@airtable/eslint-plugin-blocks@${version}",
+            "commitMessage": "Release @airtable/eslint-plugin-blocks@${version}"
+        },
+        "hooks": {
+            "before:init": "../../bin/check-repo-for-release && yarn test"
+        },
+        "npm": {
+            "access": "public"
+        }
+    }
 }

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8257

increased by108.93%

Lines of code

205

increased by107.07%

No dependency changes