@aller/blink-labrador - npm Package Compare versions

Comparing version 0.2.2 to 0.2.3

lib/main.js

@@ -160,2 +160,3 @@ 'use strict';
     });
+    this.blink.pageInit(window.location.href);
   }
@@ -166,3 +167,8 @@
     value: function trackPageload() {
-      this.blink.pageload(window.location.href);
+      var _this2 = this;
+
+      // Delay the pageload, to ensure that we get cmId included
+      document.addEventListener('DOMContentLoaded', function () {
+        return _this2.blink.pageload(window.location.href);
+      });
     }
@@ -179,10 +185,10 @@
     value: function trackAdInscreen(selector) {
-      var _this2 = this;
+      var _this3 = this;
 
       document.querySelectorAll(selector).forEach(function (element) {
         if (element.id !== undefined && element.id !== '') {
-          _this2.inView('#' + element.id, { threshold: getThreshold(element) }).on('enter', function () {
-            _this2.blink.adScreenEnter(element.id);
+          _this3.inView('#' + element.id, { threshold: getThreshold(element) }).on('enter', function () {
+            _this3.blink.adScreenEnter(element.id);
           }).on('exit', function () {
-            _this2.blink.adScreenExit(element.id);
+            _this3.blink.adScreenExit(element.id);
           });
@@ -202,8 +208,8 @@ }
     value: function trackAdInscreen0(selector) {
-      var _this3 = this;
+      var _this4 = this;
 
       this.inView(selector).on('enter', function (domElement) {
-        _this3.blink.adScreenEnter0(domElement.getAttribute('id'));
+        _this4.blink.adScreenEnter0(domElement.getAttribute('id'));
       }).on('exit', function (domElement) {
-        _this3.blink.adScreenExit0(domElement.getAttribute('id'));
+        _this4.blink.adScreenExit0(domElement.getAttribute('id'));
       });
@@ -214,3 +220,3 @@ }
     value: function trackAdDFP() {
-      var _this4 = this;
+      var _this5 = this;
 
@@ -222,3 +228,3 @@ window.googletag = window.googletag || {};
           var elementId = event.slot.getSlotElementId();
-          _this4.blink.dfpImpressionViewable({ id: elementId });
+          _this5.blink.dfpImpressionViewable({ id: elementId });
         });
@@ -228,3 +234,3 @@
           var elementId = event.slot.getSlotElementId();
-          _this4.blink.dfpSlotRenderEnded({
+          _this5.blink.dfpSlotRenderEnded({
             adUnitPath: event.slot.getAdUnitPath(),
@@ -245,3 +251,3 @@ advertiserId: event.advertiserId,
           var name = event.slot.getTargeting('pos')[0];
-          _this4.blink.dfpSlotOnload({
+          _this5.blink.dfpSlotOnload({
             id: elementId,
@@ -256,7 +262,7 @@ name: name
     value: function trackLinkClicks() {
-      var _this5 = this;
+      var _this6 = this;
 
       (0, _clickOnOutgoingLink2.default)(function (_event, element) {
         var url = (0, _getFullUrl2.default)(element.getAttribute('href'), window.location);
-        _this5.blink.click(url);
+        _this6.blink.click(url);
       });
@@ -267,31 +273,25 @@ }
     value: function _resetActiveTimer(url) {
-      var _this6 = this;
+      var _this7 = this;
 
       clearTimeout(this.activeTimeTimerId);
       this.activeTimeTimerId = setTimeout(function () {
-        return _this6.blink.articleActivityPause(url);
+        return _this7.blink.articleActivityPause(url);
       }, 10000);
     }
   }, {
-    key: '_getCurrentUrl',
-    value: function _getCurrentUrl() {
-      var el = document.head.querySelector('meta[property="og:url"]');
-      return el && el.getAttribute('content') || window.location.href;
-    }
-  }, {
     key: 'trackActiveTime',
     value: function trackActiveTime() {
-      var _this7 = this;
+      var _this8 = this;
 
-      var url = this._getCurrentUrl();
+      var url = LabradorTracker._getCurrentUrl();
       this._resetActiveTimer(url);
       var throttledStart = (0, _throttle2.default)(function () {
-        _this7._resetActiveTimer(url);
-        _this7.blink.articleActivityStart(url);
+        _this8._resetActiveTimer(url);
+        _this8.blink.articleActivityStart(url);
       }, 2000);
       var pause = function pause() {
-        return _this7.blink.articleActivityPause(url);
+        return _this8.blink.articleActivityPause(url);
       };
       var stop = function stop() {
-        return _this7.blink.articleActivityStop(url);
+        return _this8.blink.articleActivityStop(url);
       };
@@ -312,7 +312,7 @@
     value: function trackArticleImpressions(selector) {
-      var _this8 = this;
+      var _this9 = this;
 
       this.inView(selector, { threshold: 0.5 }).on('enter', function (domElement) {
         var preview = new _articlePreview2.default(domElement, window.location);
-        _this8.blink.articlePreviewScreenEnter({
+        _this9.blink.articlePreviewScreenEnter({
           url: preview.url,
@@ -327,5 +327,11 @@ title: preview.title,
         var url = (0, _getFullUrl2.default)(domElement.querySelector('a').getAttribute('href'), window.location);
-        _this8.blink.articlePreviewScreenExit(url);
+        _this9.blink.articlePreviewScreenExit(url);
       });
     }
+  }], [{
+    key: '_getCurrentUrl',
+    value: function _getCurrentUrl() {
+      var el = document.head.querySelector('meta[property="og:url"]');
+      return el && el.getAttribute('content') || window.location.href;
+    }
   }]);
@@ -332,0 +338,0 @@

lib/utils/get-db-pluss-data.js

@@ -26,3 +26,3 @@ 'use strict';
     if (parsedDecodedPlussData.access && parsedDecodedPlussData.customer_number) {
-      plussData = { hasAccess: parsedDecodedPlussData.access, customerNumber: parsedDecodedPlussData.customer_number };
+      plussData = { hasAccess: parsedDecodedPlussData.access, customerNumber: parsedDecodedPlussData.customer_number.toString() };
       return plussData;
@@ -29,0 +29,0 @@ }

package.json

 {
   "name": "@aller/blink-labrador",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Library for using blink on Labrador",
@@ -52,3 +52,3 @@ "main": "lib/main.js",
   "dependencies": {
-    "@aller/blink": "0.1.7",
+    "@aller/blink": "1.0.0",
     "@soldotno/aller-in-view": "^3.0.2"
@@ -55,0 +55,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

43464

increased by0.58%

Lines of code

1099

increased by0.46%

Dependency changes

• + Added@aller/blink@1.0.0(transitive)

• - Removed@aller/blink@0.1.7(transitive)

• Updated@aller/blink@1.0.0