@angular/bazel - npm Package Compare versions

Comparing version 6.0.0-beta.0 to 6.0.0-beta.1

package.json

 {
   "name": "@angular/bazel",
-  "version": "6.0.0-beta.0",
+  "version": "6.0.0-beta.1",
   "description": "Angular - bazel build rules",
@@ -8,3 +8,3 @@ "author": "angular",
   "peerDependencies": {
-    "@angular/compiler-cli": "6.0.0-beta.0",
+    "@angular/compiler-cli": "6.0.0-beta.1",
     "typescript": ">=2.4.2 <2.7"
@@ -11,0 +11,0 @@ },

src/ngc-wrapped/index.ts

@@ -48,3 +48,9 @@ /**
   const project = args[0].replace(/^@+/, '');
-  const [{options: tsOptions, bazelOpts, files, config}] = parseTsconfig(project);
+
+  const [parsedOptions, errors] = parseTsconfig(project);
+  if (errors && errors.length) {
+    console.error(ng.formatDiagnostics(errors));
+    return false;
+  }
+  const {options: tsOptions, bazelOpts, files, config} = parsedOptions;
   const expectedOuts = config['angularCompilerOptions']['expectedOut'];
@@ -187,4 +193,5 @@
   };
-  ngHost.toSummaryFileName = (fileName: string, referringSrcFileName: string) =>
-      relativeToRootDirs(fileName, compilerOpts.rootDirs).replace(EXT, '');
+  ngHost.toSummaryFileName = (fileName: string, referringSrcFileName: string) => path.join(
+      bazelOpts.workspaceName,
+      relativeToRootDirs(fileName, compilerOpts.rootDirs).replace(EXT, ''));
   if (allDepsCompiledWithBazel) {
@@ -195,4 +202,6 @@ // Note: The default implementation would work as well,
     // as that has a different implementation of fromSummaryFileName / toSummaryFileName
-    ngHost.fromSummaryFileName = (fileName: string, referringLibFileName: string) =>
-        path.resolve(bazelBin, fileName) + '.d.ts';
+    ngHost.fromSummaryFileName = (fileName: string, referringLibFileName: string) => {
+      const workspaceRelative = fileName.split('/').splice(1).join('/');
+      return path.resolve(bazelBin, workspaceRelative) + '.d.ts';
+    };
   }
@@ -199,0 +208,0 @@

test/ngc-wrapped/test_support.ts

@@ -50,3 +50,3 @@ /**
 
-  const angularCorePath = path.resolve(runfilesPath, 'angular_src', 'packages', 'core');
+  const angularCorePath = path.resolve(runfilesPath, 'angular', 'packages', 'core');
   const ngFiles = listFilesRecursive(angularCorePath);
@@ -117,3 +117,4 @@
         path.resolve(
-            runfilesPath, 'angular', 'test', 'ngc-wrapped', 'empty', 'empty_tsconfig.json'),
+            runfilesPath, 'angular', 'packages', 'bazel', 'test', 'ngc-wrapped', 'empty',
+            'empty_tsconfig.json'),
         read);
@@ -120,0 +121,0 @@

test/ngc-wrapped/tsconfig_template.ts

@@ -73,3 +73,3 @@ /**
       // the original workspace directory for it
-      'nodeModulesPrefix': '../angular_src/node_modules',
+      'nodeModulesPrefix': '../angular/node_modules',
     },
@@ -76,0 +76,0 @@ 'files': options.files,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

562

increased by1.63%

Worsened metrics

Total package byte prevSize

36224

decreased by-0.98%

No dependency changes