@antora/content-aggregator - npm Package Compare versions

Comparing version 2.0.0-rc.1 to 2.0.0-rc.2

lib/aggregate-content.js

@@ -199,5 +199,4 @@ 'use strict'
           fetchOpts.emitter && fetchOpts.emitter.emit('complete')
-          // NOTE we're not interested in local branches
-          // it also causes isomorphic-git to hang when calling readObject after fetch
-          return fs.emptyDir(ospath.join(repo.gitdir, 'refs', 'heads'))
+          // NOTE we're not interested in local branches, so we can just delete them
+          //return fs.emptyDir(ospath.join(repo.gitdir, 'refs', 'heads'))
         })
@@ -231,10 +230,6 @@ } else {
 
-async function collectComponentVersions (source, repo, remoteName, requiresAuth, refPatterns) {
-  const refs = await selectReferences(repo, remoteName, refPatterns)
-  const result = []
-  // a for loop is used here because Promise.all was causing resource starvation on large repositories
-  for (let i = 0, len = refs.length; i < len; i++) {
-    result[i] = await populateComponentVersion(source, repo, remoteName, requiresAuth, refs[i])
-  }
-  return result
+function collectComponentVersions (source, repo, remoteName, requiresAuth, refPatterns) {
+  return selectReferences(repo, remoteName, refPatterns).then((refs) =>
+    Promise.all(refs.map((ref) => populateComponentVersion(source, repo, remoteName, requiresAuth, ref)))
+  )
 }
@@ -297,3 +292,3 @@
     for (let name of remoteBranches) {
-      // FIXME UPSTREAM isomorphic-git should filter out HEAD from the list of remote branches
+      // NOTE isomorphic-git includes HEAD in list of remote branches (see https://isomorphic-git.org/docs/listBranches)
       if (name !== 'HEAD' && matcher([name], branchPatterns).length) {
@@ -300,0 +295,0 @@ refs.set(name, { name, qname: path.join('remotes', remote, name), type: 'branch', remote })

package.json

 {
   "name": "@antora/content-aggregator",
-  "version": "2.0.0-rc.1",
+  "version": "2.0.0-rc.2",
   "description": "Fetches and aggregates content from distributed sources for use in an Antora documentation pipeline.",
@@ -23,3 +23,3 @@ "license": "MPL-2.0",
     "fs-extra": "^7.0.0",
-    "isomorphic-git": "0.46.0",
+    "isomorphic-git": "0.47.0",
     "js-yaml": "^3.12.0",
@@ -26,0 +26,0 @@ "lodash": "^4.17.11",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

33536

decreased by-0.64%

Lines of code

792

decreased by-0.63%

Dependency changes

• + Addedisomorphic-git@0.47.0(transitive)

• - Removedisomorphic-git@0.46.0(transitive)

• Updatedisomorphic-git@0.47.0