@antv/g - npm Package Compare versions

Comparing version 2.0.7-beta.6 to 2.1.0

lib/shape/path.js

@@ -240,19 +240,2 @@ var Util = require('../util/index');
   },
-  _addArrow: function _addArrow(startPoint, endPoint, tangent, context, isStartArrow) {
-    var attrs = this.__attrs;
-    if (Util.isFunction(tangent)) {
-      var v = tangent();
-      if (isStartArrow) {
-        Arrow.addStartArrow(context, attrs, startPoint.x - v[0], startPoint.y - v[1], startPoint.x, startPoint.y);
-      } else {
-        Arrow.addEndArrow(context, attrs, endPoint.x - v[0], endPoint.y - v[1], endPoint.x, endPoint.y);
-      }
-    } else {
-      if (isStartArrow) {
-        Arrow.addStartArrow(context, attrs, endPoint.x, endPoint.y, startPoint.x, startPoint.y);
-      } else {
-        Arrow.addEndArrow(context, attrs, startPoint.x, startPoint.y, endPoint.x, endPoint.y);
-      }
-    }
-  },
   afterPath: function afterPath(context) {
@@ -263,2 +246,5 @@ var self = this;
     var path = attrs.path;
+    var startPoint = void 0,
+        endPoint = void 0,
+        tangent = void 0;
     context = context || self.get('context');
@@ -275,6 +261,22 @@ if (!Util.isArray(segments)) return;
     if (segmentsLen > 1) {
-      self._addArrow(segments[0].endPoint, segments[1].endPoint, segments[1].startTangent, context, true);
+      startPoint = segments[0].endPoint;
+      endPoint = segments[1].endPoint;
+      tangent = segments[1].startTangent;
+      if (Util.isFunction(tangent)) {
+        var v = tangent();
+        Arrow.addStartArrow(context, attrs, startPoint.x - v[0], startPoint.y - v[1], startPoint.x, startPoint.y);
+      } else {
+        Arrow.addStartArrow(context, attrs, endPoint.x, endPoint.y, startPoint.x, startPoint.y);
+      }
     }
     if (segmentsLen > 1) {
-      self._addArrow(segments[segmentsLen - 2].endPoint, segments[segmentsLen - 1].endPoint, segments[segmentsLen - 1].endTangent, context, false);
+      startPoint = segments[segmentsLen - 2].endPoint;
+      endPoint = segments[segmentsLen - 1].endPoint;
+      tangent = segments[segmentsLen - 1].endTangent;
+      if (Util.isFunction(tangent)) {
+        var _v = tangent();
+        Arrow.addEndArrow(context, attrs, endPoint.x - _v[0], endPoint.y - _v[1], endPoint.x, endPoint.y, tangent());
+      } else {
+        Arrow.addEndArrow(context, attrs, startPoint.x, startPoint.y, endPoint.x, endPoint.y);
+      }
     }
@@ -281,0 +283,0 @@ }

package.json

 {
   "name": "@antv/g",
-  "version": "2.0.7-beta.6",
+  "version": "2.1.0",
   "description": "A canvas library which providing 2d draw for G2.",
@@ -5,0 +5,0 @@ "keywords": [

src/shape/path.js

@@ -244,19 +244,2 @@ const Util = require('../util/index');
   },
-  _addArrow(startPoint, endPoint, tangent, context, isStartArrow) {
-    const attrs = this.__attrs;
-    if (Util.isFunction(tangent)) {
-      const v = tangent();
-      if (isStartArrow) {
-        Arrow.addStartArrow(context, attrs, startPoint.x - v[0], startPoint.y - v[1], startPoint.x, startPoint.y);
-      } else {
-        Arrow.addEndArrow(context, attrs, endPoint.x - v[0], endPoint.y - v[1], endPoint.x, endPoint.y);
-      }
-    } else {
-      if (isStartArrow) {
-        Arrow.addStartArrow(context, attrs, endPoint.x, endPoint.y, startPoint.x, startPoint.y);
-      } else {
-        Arrow.addEndArrow(context, attrs, startPoint.x, startPoint.y, endPoint.x, endPoint.y);
-      }
-    }
-  },
   afterPath(context) {
@@ -267,2 +250,5 @@ const self = this;
     const path = attrs.path;
+    let startPoint,
+      endPoint,
+      tangent;
     context = context || self.get('context');
@@ -278,14 +264,22 @@ if (!Util.isArray(segments)) return;
     if (segmentsLen > 1) {
-      self._addArrow(
-        segments[0].endPoint,
-        segments[1].endPoint,
-        segments[1].startTangent,
-        context, true);
+      startPoint = segments[0].endPoint;
+      endPoint = segments[1].endPoint;
+      tangent = segments[1].startTangent;
+      if (Util.isFunction(tangent)) {
+        const v = tangent();
+        Arrow.addStartArrow(context, attrs, startPoint.x - v[0], startPoint.y - v[1], startPoint.x, startPoint.y);
+      } else {
+        Arrow.addStartArrow(context, attrs, endPoint.x, endPoint.y, startPoint.x, startPoint.y);
+      }
     }
     if (segmentsLen > 1) {
-      self._addArrow(
-        segments[ segmentsLen - 2 ].endPoint,
-        segments[ segmentsLen - 1 ].endPoint,
-        segments[segmentsLen - 1].endTangent,
-        context, false);
+      startPoint = segments[ segmentsLen - 2 ].endPoint;
+      endPoint = segments[ segmentsLen - 1 ].endPoint;
+      tangent = segments[segmentsLen - 1].endTangent;
+      if (Util.isFunction(tangent)) {
+        const v = tangent();
+        Arrow.addEndArrow(context, attrs, endPoint.x - v[0], endPoint.y - v[1], endPoint.x, endPoint.y, tangent());
+      } else {
+        Arrow.addEndArrow(context, attrs, startPoint.x, startPoint.y, endPoint.x, endPoint.y);
+      }
     }
@@ -292,0 +286,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

1067660

decreased by-0.05%

Lines of code

27619

decreased by-0.01%

No dependency changes