@antv/g - npm Package Compare versions

Comparing version 3.1.0-beta.1 to 3.1.0-beta.2

lib/canvas.js

@@ -273,7 +273,9 @@ var Util = require('./util/index');
   destroy: function destroy() {
-    var containerDOM = this.get('containerDOM');
-    var canvasDOM = this.get('canvasDOM');
+    var cfg = this._cfg;
+    var containerDOM = cfg.containerDOM;
+    var canvasDOM = cfg.canvasDOM;
     if (canvasDOM && containerDOM) {
       containerDOM.removeChild(canvasDOM);
     }
+    cfg.timeline.stop();
     Canvas.superclass.destroy.call(this);
@@ -280,0 +282,0 @@ }

lib/core/element.js

@@ -133,7 +133,2 @@ var Util = require('../util/index');
     }
-    // 如果正在执行动画，清理动画
-    if (this.get('animating')) {
-      var timer = this.get('animateTimer');
-      timer && timer.stop();
-    }
     this._attrs = null;
@@ -140,0 +135,0 @@ this.removeEvent(); // 移除所有的事件

lib/core/mixin/timeline.js

@@ -145,2 +145,7 @@ var Util = require('../../util/index');
   },
+  stop: function stop() {
+    if (this._timer) {
+      this._timer.stop();
+    }
+  },
   getTime: function getTime() {
@@ -147,0 +152,0 @@ return this._current;

lib/index.js

@@ -26,3 +26,3 @@ module.exports = {
   // version, etc.
-  version: '3.1.0-beta.1'
+  version: '3.1.0-beta.2'
 };

package.json

 {
   "name": "@antv/g",
-  "version": "3.1.0-beta.1",
+  "version": "3.1.0-beta.2",
   "description": "A canvas library which providing 2d draw for G2.",
@@ -5,0 +5,0 @@ "keywords": [

src/canvas.js

@@ -282,7 +282,9 @@ const Util = require('./util/index');
   destroy() {
-    const containerDOM = this.get('containerDOM');
-    const canvasDOM = this.get('canvasDOM');
+    const cfg = this._cfg;
+    const containerDOM = cfg.containerDOM;
+    const canvasDOM = cfg.canvasDOM;
     if (canvasDOM && containerDOM) {
       containerDOM.removeChild(canvasDOM);
     }
+    cfg.timeline.stop();
     Canvas.superclass.destroy.call(this);
@@ -289,0 +291,0 @@ }

src/core/element.js

@@ -131,7 +131,2 @@ const Util = require('../util/index');
     }
-    // 如果正在执行动画，清理动画
-    if (this.get('animating')) {
-      const timer = this.get('animateTimer');
-      timer && timer.stop();
-    }
     this._attrs = null;
@@ -138,0 +133,0 @@ this.removeEvent(); // 移除所有的事件

src/core/mixin/timeline.js

@@ -140,2 +140,7 @@ const Util = require('../../util/index');
   },
+  stop() {
+    if (this._timer) {
+      this._timer.stop();
+    }
+  },
   getTime() {
@@ -142,0 +147,0 @@ return this._current;

src/index.js

@@ -26,3 +26,3 @@ module.exports = {
   // version, etc.
-  version: '3.1.0-beta.1'
+  version: '3.1.0-beta.2'
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1033316

increased by0.36%

Lines of code

26760

increased by0.02%

No dependency changes