@apollo/server - npm Package Compare versions

Comparing version 4.10.3 to 4.10.4

dist/cjs/generated/packageVersion.d.ts

@@ -1,2 +0,2 @@
-export declare const packageVersion = "4.10.3";
+export declare const packageVersion = "4.10.4";
 //# sourceMappingURL=packageVersion.d.ts.map

dist/cjs/generated/packageVersion.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.packageVersion = void 0;
-exports.packageVersion = "4.10.3";
+exports.packageVersion = "4.10.4";
 //# sourceMappingURL=packageVersion.js.map

dist/cjs/plugin/subscriptionCallback/index.js

@@ -62,2 +62,8 @@ "use strict";
                     }
+                    subscriptionManager.initHeartbeat({
+                        callbackUrl,
+                        id,
+                        verifier,
+                        heartbeatIntervalMs,
+                    });
                     logger?.debug(`Starting graphql-js subscription`, id);
@@ -103,8 +109,2 @@ let subscription;
                         logger?.debug('graphql-js subscription successful', id);
-                        subscriptionManager.initHeartbeat({
-                            callbackUrl,
-                            id,
-                            verifier,
-                            heartbeatIntervalMs,
-                        });
                         subscriptionManager.startConsumingSubscription({
@@ -111,0 +111,0 @@ subscription,

dist/esm/generated/packageVersion.d.ts

@@ -1,2 +0,2 @@
-export declare const packageVersion = "4.10.3";
+export declare const packageVersion = "4.10.4";
 //# sourceMappingURL=packageVersion.d.ts.map

dist/esm/generated/packageVersion.js

@@ -1,2 +0,2 @@
-export const packageVersion = "4.10.3";
+export const packageVersion = "4.10.4";
 //# sourceMappingURL=packageVersion.js.map

dist/esm/plugin/subscriptionCallback/index.js

@@ -56,2 +56,8 @@ import retry from 'async-retry';
                     }
+                    subscriptionManager.initHeartbeat({
+                        callbackUrl,
+                        id,
+                        verifier,
+                        heartbeatIntervalMs,
+                    });
                     logger?.debug(`Starting graphql-js subscription`, id);
@@ -97,8 +103,2 @@ let subscription;
                         logger?.debug('graphql-js subscription successful', id);
-                        subscriptionManager.initHeartbeat({
-                            callbackUrl,
-                            id,
-                            verifier,
-                            heartbeatIntervalMs,
-                        });
                         subscriptionManager.startConsumingSubscription({
@@ -105,0 +105,0 @@ subscription,

package.json

 {
   "name": "@apollo/server",
-  "version": "4.10.3",
+  "version": "4.10.4",
   "description": "Core engine for Apollo GraphQL server",
@@ -5,0 +5,0 @@ "type": "module",

src/generated/packageVersion.ts

@@ -1,1 +0,1 @@
-export const packageVersion = "4.10.3";
+export const packageVersion = "4.10.4";

src/plugin/subscriptionCallback/index.ts

@@ -101,2 +101,13 @@ import type { Logger } from '@apollo/utils.logger';
 
+          // We're about to `await` the subscription, which could have some
+          // nontrivial asynchronous work to do before returning the generator.
+          // We set up the heartbeat first so the router knows we're alive
+          // during that wait period.
+          subscriptionManager.initHeartbeat({
+            callbackUrl,
+            id,
+            verifier,
+            heartbeatIntervalMs,
+          });
+
           // The `check` request was successful, so we can initialize the actual
@@ -156,12 +167,5 @@ // `graphql-js` subscription. We don't expect `subscribe` to throw,
           } else if (isAsyncIterable(subscription)) {
-            // We have a real subscription - now we can kick off the heartbeat
-            // interval and consume the AsyncIterable on the `subscription`
-            // object.
+            // We have a real subscription - now we can consume the
+            // AsyncIterable on the `subscription` object.
             logger?.debug('graphql-js subscription successful', id);
-            subscriptionManager.initHeartbeat({
-              callbackUrl,
-              id,
-              verifier,
-              heartbeatIntervalMs,
-            });
 
@@ -168,0 +172,0 @@ subscriptionManager.startConsumingSubscription({

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1951384

increased by0.01%

Lines of code

34376

increased by0.01%

No dependency changes