@arcteryx/components-button - npm Package Compare versions

Comparing version 1.30.3 to 1.30.4

CHANGELOG.md

@@ -6,2 +6,10 @@ # Change Log
 
+## [1.30.4](http://bitbucket.org/arcteryx/arcteryx-js-helpers/compare/@arcteryx/components-button@1.30.3...@arcteryx/components-button@1.30.4) (2021-04-06)
+
+**Note:** Version bump only for package @arcteryx/components-button
+
+
+
+
+
 ## [1.30.3](http://bitbucket.org/arcteryx/arcteryx-js-helpers/compare/@arcteryx/components-button@1.30.2...@arcteryx/components-button@1.30.3) (2021-03-10)
@@ -8,0 +16,0 @@

dist/cjs/index.js

@@ -145,5 +145,5 @@ 'use strict';
 
-  ${props => props.isDisabled && styled.css`
+  ${props => props.disabled && styled.css`
       &:disabled,
-      &.is-disabled {
+      &.disabled{
         opacity: 0.3;
@@ -234,3 +234,3 @@ color: #ccc;
     size,
-    isDisabled,
+    disabled,
     isWaiting,
@@ -243,3 +243,3 @@ onClick,
   } = _ref,
-      otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "isDisabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
+      otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "disabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
 
@@ -251,4 +251,3 @@ const baseClass = "button";
     [`${baseClass}--${size}`]: size,
-    [`disabled`]: isDisabled,
-    [`is-disabled`]: isDisabled,
+    [`disabled`]: disabled,
     [`waiting`]: isWaiting,
@@ -266,3 +265,3 @@ [`is-waiting`]: isWaiting
     context: context,
-    isDisabled: isDisabled
+    disabled: disabled
   }, otherProps), isWaiting ? /*#__PURE__*/React.createElement(LoadingIcon, null) : null, /*#__PURE__*/React.createElement("span", null, children));
@@ -276,3 +275,3 @@ };
   type: "button",
-  isDisabled: false,
+  disabled: false,
   isWaiting: false,
@@ -293,3 +292,3 @@ onClick: null,
   size: PropTypes.oneOf(["xs", "sm", "md", "lg"]),
-  isDisabled: PropTypes.bool,
+  disabled: PropTypes.bool,
   isWaiting: PropTypes.bool,
@@ -296,0 +295,0 @@ onClick: PropTypes.func,

dist/es/index.js

@@ -138,5 +138,5 @@ import React from 'react';
 
-  ${props => props.isDisabled && css`
+  ${props => props.disabled && css`
       &:disabled,
-      &.is-disabled {
+      &.disabled{
         opacity: 0.3;
@@ -227,3 +227,3 @@ color: #ccc;
     size,
-    isDisabled,
+    disabled,
     isWaiting,
@@ -236,3 +236,3 @@ onClick,
   } = _ref,
-      otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "isDisabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
+      otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "disabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
 
@@ -244,4 +244,3 @@ const baseClass = "button";
     [`${baseClass}--${size}`]: size,
-    [`disabled`]: isDisabled,
-    [`is-disabled`]: isDisabled,
+    [`disabled`]: disabled,
     [`waiting`]: isWaiting,
@@ -259,3 +258,3 @@ [`is-waiting`]: isWaiting
     context: context,
-    isDisabled: isDisabled
+    disabled: disabled
   }, otherProps), isWaiting ? /*#__PURE__*/React.createElement(LoadingIcon, null) : null, /*#__PURE__*/React.createElement("span", null, children));
@@ -269,3 +268,3 @@ };
   type: "button",
-  isDisabled: false,
+  disabled: false,
   isWaiting: false,
@@ -286,3 +285,3 @@ onClick: null,
   size: PropTypes.oneOf(["xs", "sm", "md", "lg"]),
-  isDisabled: PropTypes.bool,
+  disabled: PropTypes.bool,
   isWaiting: PropTypes.bool,
@@ -289,0 +288,0 @@ onClick: PropTypes.func,

dist/umd/index.js

@@ -149,5 +149,5 @@ (function (global, factory) {
 
-  ${props => props.isDisabled && styled.css`
+  ${props => props.disabled && styled.css`
       &:disabled,
-      &.is-disabled {
+      &.disabled{
         opacity: 0.3;
@@ -238,3 +238,3 @@ color: #ccc;
       size,
-      isDisabled,
+      disabled,
       isWaiting,
@@ -247,3 +247,3 @@ onClick,
     } = _ref,
-        otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "isDisabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
+        otherProps = _objectWithoutProperties(_ref, ["market", "context", "type", "size", "disabled", "isWaiting", "onClick", "className", "id", "style", "children"]);
 
@@ -255,4 +255,3 @@ const baseClass = "button";
       [`${baseClass}--${size}`]: size,
-      [`disabled`]: isDisabled,
-      [`is-disabled`]: isDisabled,
+      [`disabled`]: disabled,
       [`waiting`]: isWaiting,
@@ -270,3 +269,3 @@ [`is-waiting`]: isWaiting
       context: context,
-      isDisabled: isDisabled
+      disabled: disabled
     }, otherProps), isWaiting ? /*#__PURE__*/React.createElement(LoadingIcon, null) : null, /*#__PURE__*/React.createElement("span", null, children));
@@ -280,3 +279,3 @@ };
     type: "button",
-    isDisabled: false,
+    disabled: false,
     isWaiting: false,
@@ -297,3 +296,3 @@ onClick: null,
     size: PropTypes.oneOf(["xs", "sm", "md", "lg"]),
-    isDisabled: PropTypes.bool,
+    disabled: PropTypes.bool,
     isWaiting: PropTypes.bool,
@@ -300,0 +299,0 @@ onClick: PropTypes.func,

package.json

 {
   "name": "@arcteryx/components-button",
-  "version": "1.30.3",
+  "version": "1.30.4",
   "description": "Arcteryx Button",
@@ -18,3 +18,3 @@ "source": "src/index.js",
   "license": "ISC",
-  "gitHead": "c9791cb48fdf8be998fba0ac650823b7d6e38af7",
+  "gitHead": "f39f41d3cc13b6fa64dc8ff90c2e5682d5250af9",
   "files": [
@@ -21,0 +21,0 @@ "dist",

src/__tests__/components/button.test.js

 import React from "react";
-import { render } from "@testing-library/react";
+import { render, fireEvent } from "@testing-library/react";
 import ButtonWrapper from "../../components/button";
@@ -22,3 +22,2 @@ import "jest-styled-components";
       context: "Standard",
-      isDisabled: false,
       disabled: false,
@@ -29,3 +28,3 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
+        disabled={mockData.disabled}
         market={mockData.market}
@@ -57,3 +56,2 @@ context={mockData.context}
       context: "Standard",
-      isDisabled: true,
       disabled: true,
@@ -64,3 +62,2 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
         disabled={mockData.disabled}
@@ -78,2 +75,34 @@ market={mockData.market}
   });
+  it("Does not fire the function when clicked", () => {
+    mockData = {
+      market: "outdoor",
+      id: "btn",
+      className: "btn",
+      type: "button",
+      style: {},
+      onClick: jest.fn(),
+      size: "lg",
+      market: "Outdoor",
+      context: "Standard",
+      disabled: true,
+    };
+    const { container } = render(
+      <ButtonWrapper
+        id={mockData.id}
+        disabled={mockData.disabled}
+        market={mockData.market}
+        context={mockData.context}
+        size={mockData.size}
+        className={mockData.className}
+        onClick={mockData.onClick}
+      >
+        Standard
+      </ButtonWrapper>
+    );
+    fireEvent(container.firstChild, new MouseEvent('click', {
+      bubbles: true,
+      cancelable: true,
+    }));
+    expect(mockData.onClick).toHaveBeenCalledTimes(0);
+  })
 });
@@ -88,6 +117,4 @@ describe("Waiting Standard Button Component", () => {
       style: {},
-      onClick: function() {
-        console.log("Disabled, not clickable");
-      },
       size: "lg",
+      onClick: () => {console.log("this is a test")},
       market: "Outdoor",
@@ -196,3 +223,2 @@ context: "Standard",
       context: "Subtile",
-      isDisabled: false,
       disabled: false,
@@ -203,3 +229,3 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
+        disabled={mockData.disabled}
         market={mockData.market}
@@ -232,3 +258,2 @@ context={mockData.context}
       context: "Secure-Checkout",
-      isDisabled: false,
       disabled: false,
@@ -239,3 +264,3 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
+        disabled={mockData.disabled}
         market={mockData.market}
@@ -268,3 +293,2 @@ context={mockData.context}
       context: "Add-To-Cart",
-      isDisabled: false,
       disabled: false,
@@ -275,3 +299,3 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
+        disabled={mockData.disabled}
         market={mockData.market}
@@ -304,3 +328,2 @@ context={mockData.context}
       context: "Find-In-Store",
-      isDisabled: false,
       disabled: false,
@@ -311,3 +334,3 @@ };
         id={mockData.id}
-        isDisabled={mockData.isDisabled}
+        disabled={mockData.disabled}
         market={mockData.market}
@@ -314,0 +337,0 @@ context={mockData.context}

src/components/button.js

@@ -73,6 +73,6 @@ import React from "react";
   ${props =>
-    props.isDisabled &&
+    props.disabled &&
     css`
       &:disabled,
-      &.is-disabled {
+      &.disabled{
         opacity: 0.3;
@@ -168,3 +168,3 @@ color: #ccc;
   size,
-  isDisabled,
+  disabled,
   isWaiting,
@@ -183,4 +183,3 @@ onClick,
     [`${baseClass}--${size}`]: size,
-    [`disabled`]: isDisabled,
-    [`is-disabled`]: isDisabled,
+    [`disabled`]: disabled,
     [`waiting`]: isWaiting,
@@ -200,3 +199,3 @@ [`is-waiting`]: isWaiting,
       context={context}
-      isDisabled={isDisabled}
+      disabled={disabled}
       {...otherProps}
@@ -216,3 +215,3 @@ >
   type: "button",
-  isDisabled: false,
+  disabled: false,
   isWaiting: false,
@@ -232,3 +231,3 @@ onClick: null,
   size: PropTypes.oneOf(["xs", "sm", "md", "lg"]),
-  isDisabled: PropTypes.bool,
+  disabled: PropTypes.bool,
   isWaiting: PropTypes.bool,
@@ -235,0 +234,0 @@ onClick: PropTypes.func,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Unpopular package

Quality

This package is not very popular.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

99331

increased by0.35%

Lines of code

1481

increased by1.3%

Worsened metrics

Number of downloads

843

decreased by-19.71%

Number of medium quality alerts

1

increased byInfinity%

No dependency changes