@azure/core-rest-pipeline - npm Package Compare versions

Comparing version 1.0.3 to 1.1.0-alpha.20210518.2

CHANGELOG.md

 # Release History
 
+## 1.1.0-beta.2 (Unreleased)
+
+### Fixed
+
+- Fixed an issue where tracing spans were not setting a status correctly (on success or error) which results in the span status being `UNSET`. In addition, we will now capture the HTTP status code when a request fails in the tracing span. [PR 15061](https://github.com/Azure/azure-sdk-for-js/pull/15061)
+
+## 1.1.0-beta.1 (2021-05-06)
+
+### Features Added
+
+- Add a new `bearerTokenChallengeAuthenticationPolicy` that provides a skeleton of handling challenge-based authorization. There are two extensible points: `authorizeRequest` and `authorizeRequestOnChallenge` callbacks.
+  - `authorizeRequest` allows customizing the policy to alter how it authorizes a request before sending it. By default when no callbacks are specified, this policy has the same behavior as `bearerTokenAuthenticationPolicy`. It will retrieve the token from the underlying token credential, and if it gets one, it will cache the token and set it to the outgoing request.
+  - `authorizeRequestOnChallenge`, which gets called only if we've found a challenge in the response. This callback has access to the original request and its response and is expected to handle the challenge. If this callback returns true, the request, usually updated after handling the challenge, will be sent again. If this call back returns false, no further actions will be taken.
+
+### Fixed
+
+- Rewrote `bearerTokenAuthenticationPolicy` to use a new backend that refreshes tokens only when they're about to expire and not multiple times before. This is based on a similar fix implemented on `@azure/core-http@1.2.4` ([PR with the changes](https://github.com/Azure/azure-sdk-for-js/pull/14223)). This fixes the issue: [13369](https://github.com/Azure/azure-sdk-for-js/issues/13369).
+- Delay loading of NO_PROXY environment variable until when request pipeline is being created. This fixes [issue 14873](https://github.com/Azure/azure-sdk-for-js/issues/14873)
+
 ## 1.0.3 (2021-03-30)
@@ -4,0 +23,0 @@

dist-esm/src/constants.js

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-export const SDK_VERSION = "1.0.3";
+export const SDK_VERSION = "1.1.0-beta.2";
 //# sourceMappingURL=constants.js.map

dist-esm/src/index.js

@@ -20,3 +20,4 @@ // Copyright (c) Microsoft Corporation.
 export { bearerTokenAuthenticationPolicy, bearerTokenAuthenticationPolicyName } from "./policies/bearerTokenAuthenticationPolicy";
+export { bearerTokenChallengeAuthenticationPolicy, bearerTokenChallengeAuthenticationPolicyName } from "./policies/bearerTokenChallengeAuthenticationPolicy";
 export { ndJsonPolicy, ndJsonPolicyName } from "./policies/ndJsonPolicy";
 //# sourceMappingURL=index.js.map

dist-esm/src/nodeHttpClient.js

@@ -267,3 +267,4 @@ // Copyright (c) Microsoft Corporation.
 }
-function getBodyLength(body) {
+/** @internal */
+export function getBodyLength(body) {
     if (!body) {
@@ -281,2 +282,5 @@ return 0;
     }
+    else if (typeof body === "string") {
+        return Buffer.from(body).length;
+    }
     else {
@@ -283,0 +287,0 @@ return null;

dist-esm/src/policies/bearerTokenAuthenticationPolicy.js

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 import { __awaiter } from "tslib";
-import { ExpiringAccessTokenCache } from "../accessTokenCache";
+import { createTokenCycler } from "../util/tokenCycler";
 /**
@@ -15,13 +15,7 @@ * The programmatic identifier of the bearerTokenAuthenticationPolicy.
     const { credential, scopes } = options;
-    const tokenCache = new ExpiringAccessTokenCache();
-    function getToken(tokenOptions) {
-        return __awaiter(this, void 0, void 0, function* () {
-            let accessToken = tokenCache.getCachedToken();
-            if (accessToken === undefined) {
-                accessToken = (yield credential.getToken(scopes, tokenOptions)) || undefined;
-                tokenCache.setCachedToken(accessToken);
-            }
-            return accessToken ? accessToken.token : undefined;
-        });
-    }
+    // This function encapsulates the entire process of reliably retrieving the token
+    // The options are left out of the public API until there's demand to configure this.
+    // Remember to extend `BearerTokenAuthenticationPolicyOptions` with `TokenCyclerOptions`
+    // in order to pass through the `options` object.
+    const cycler = createTokenCycler(credential /* , options */);
     return {
@@ -31,3 +25,3 @@ name: bearerTokenAuthenticationPolicyName,
             return __awaiter(this, void 0, void 0, function* () {
-                const token = yield getToken({
+                const { token } = yield cycler.getToken(scopes, {
                     abortSignal: request.abortSignal,
@@ -34,0 +28,0 @@ tracingOptions: request.tracingOptions

dist-esm/src/policies/proxyPolicy.js

@@ -15,3 +15,4 @@ // Copyright (c) Microsoft Corporation.
 export const proxyPolicyName = "proxyPolicy";
-export const noProxyList = loadNoProxy();
+export const noProxyList = [];
+let noProxyListLoaded = false;
 const byPassedList = new Map();
@@ -73,2 +74,3 @@ let httpsProxyAgent;
     const noProxy = getEnvironmentValue(NO_PROXY);
+    noProxyListLoaded = true;
     if (noProxy) {
@@ -151,2 +153,5 @@ return noProxy
 export function proxyPolicy(proxySettings = getDefaultProxySettings()) {
+    if (!noProxyListLoaded) {
+        noProxyList.push(...loadNoProxy());
+    }
     return {
@@ -153,0 +158,0 @@ name: proxyPolicyName,

dist-esm/src/policies/redirectPolicy.js

@@ -47,2 +47,3 @@ // Copyright (c) Microsoft Corporation.
                 request.method = "GET";
+                request.headers.delete("Content-Length");
                 delete request.body;
@@ -49,0 +50,0 @@ }

dist-esm/src/policies/tracingPolicy.js

 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 import { __awaiter } from "tslib";
-import { getTraceParentHeader, createSpanFunction } from "@azure/core-tracing";
+import { getTraceParentHeader, createSpanFunction, SpanStatusCode } from "@azure/core-tracing";
 import { SpanKind } from "@azure/core-tracing";
@@ -63,9 +63,18 @@ import { URL } from "../util/url";
                     }
-                    span.end();
+                    span.setStatus({
+                        code: SpanStatusCode.OK
+                    });
                     return response;
                 }
                 catch (err) {
-                    span.end();
+                    span.setStatus({
+                        code: SpanStatusCode.ERROR,
+                        message: err.message
+                    });
+                    span.setAttribute("http.status_code", err.statusCode);
                     throw err;
                 }
+                finally {
+                    span.end();
+                }
             });
@@ -72,0 +81,0 @@ }

dist-esm/src/util/sanitizer.js

@@ -25,2 +25,3 @@ // Copyright (c) Microsoft Corporation.
     "Accept",
+    "Accept-Encoding",
     "Cache-Control",
@@ -27,0 +28,0 @@ "Connection",

package.json

 {
   "name": "@azure/core-rest-pipeline",
-  "version": "1.0.3",
+  "version": "1.1.0-alpha.20210518.2",
   "description": "Isomorphic client library for making HTTP requests in node.js and browser.",
@@ -116,4 +116,4 @@ "sdk-type": "client",
     "@types/uuid": "^8.0.0",
-    "@azure/eslint-plugin-azure-sdk": "^3.0.0",
-    "@azure/dev-tool": "^1.0.0",
+    "@azure/eslint-plugin-azure-sdk": "^3.0.0-alpha",
+    "@azure/dev-tool": "^1.0.0-alpha",
     "chai": "^4.2.0",
@@ -120,0 +120,0 @@ "downlevel-dts": "~0.4.0",

types/3.1/core-rest-pipeline.d.ts

 /// <reference types="node" />
 import { AbortSignalLike } from '@azure/abort-controller';
+import { AccessToken } from '@azure/core-auth';
 import { Debugger } from '@azure/logger';
+import { GetTokenOptions } from '@azure/core-auth';
 import { OperationTracingOptions } from '@azure/core-tracing';
@@ -56,2 +58,40 @@ import { TokenCredential } from '@azure/core-auth';
 /**
+ * Options sent to the authorizeRequestOnChallenge callback
+ */
+export declare interface AuthorizeRequestOnChallengeOptions {
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Function that retrieves either a cached access token or a new access token.
+     */
+    getAccessToken: (scopes: string[], options: GetTokenOptions) => Promise<AccessToken | null>;
+    /**
+     * Request that the policy is trying to fulfill.
+     */
+    request: PipelineRequest;
+    /**
+     * Response containing the challenge.
+     */
+    response: PipelineResponse;
+}
+/**
+ * Options sent to the authorizeRequest callback
+ */
+export declare interface AuthorizeRequestOptions {
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Function that retrieves either a cached access token or a new access token.
+     */
+    getAccessToken: (scopes: string[], options: GetTokenOptions) => Promise<AccessToken | null>;
+    /**
+     * Request that the policy is trying to fulfill.
+     */
+    request: PipelineRequest;
+}
+/**
  * A policy that can request a token from a TokenCredential implementation and
@@ -79,2 +119,46 @@ * then apply it to the Authorization header of a request as a Bearer token.
 /**
+ * A policy that can request a token from a TokenCredential implementation and
+ * then apply it to the Authorization header of a request as a Bearer token.
+ */
+export declare function bearerTokenChallengeAuthenticationPolicy(options: BearerTokenChallengeAuthenticationPolicyOptions): PipelinePolicy;
+/**
+ * The programmatic identifier of the bearerTokenChallengeAuthenticationPolicy.
+ */
+export declare const bearerTokenChallengeAuthenticationPolicyName = "bearerTokenChallengeAuthenticationPolicy";
+/**
+ * Options to configure the bearerTokenChallengeAuthenticationPolicy
+ */
+export declare interface BearerTokenChallengeAuthenticationPolicyOptions {
+    /**
+     * The TokenCredential implementation that can supply the bearer token.
+     */
+    credential?: TokenCredential;
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Allows for the processing of [Continuous Access Evaluation](https://docs.microsoft.com/azure/active-directory/conditional-access/concept-continuous-access-evaluation) challenges.
+     * If provided, it must contain at least the `authorizeRequestOnChallenge` method.
+     * If provided, after a request is sent, if it has a challenge, it can be processed to re-send the original request with the relevant challenge information.
+     */
+    challengeCallbacks?: ChallengeCallbacks;
+}
+/**
+ * Options to override the processing of [Continuous Access Evaluation](https://docs.microsoft.com/azure/active-directory/conditional-access/concept-continuous-access-evaluation) challenges.
+ */
+export declare interface ChallengeCallbacks {
+    /**
+     * Allows for the authorization of the main request of this policy before it's sent.
+     */
+    authorizeRequest?(options: AuthorizeRequestOptions): Promise<void>;
+    /**
+     * Allows to handle authentication challenges and to re-authorize the request.
+     * The response containing the challenge is `options.response`.
+     * If this method returns true, the underlying request will be sent once again.
+     * The request may be modified before being sent.
+     */
+    authorizeRequestOnChallenge?(options: AuthorizeRequestOnChallengeOptions): Promise<boolean>;
+}
+/**
  * Create the correct HttpClient for the current environment.
@@ -81,0 +165,0 @@ */

types/latest/core-rest-pipeline.d.ts

 /// <reference types="node" />
 import { AbortSignalLike } from '@azure/abort-controller';
+import { AccessToken } from '@azure/core-auth';
 import { Debugger } from '@azure/logger';
+import { GetTokenOptions } from '@azure/core-auth';
 import { OperationTracingOptions } from '@azure/core-tracing';
@@ -59,2 +61,42 @@ import { TokenCredential } from '@azure/core-auth';
 /**
+ * Options sent to the authorizeRequestOnChallenge callback
+ */
+export declare interface AuthorizeRequestOnChallengeOptions {
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Function that retrieves either a cached access token or a new access token.
+     */
+    getAccessToken: (scopes: string[], options: GetTokenOptions) => Promise<AccessToken | null>;
+    /**
+     * Request that the policy is trying to fulfill.
+     */
+    request: PipelineRequest;
+    /**
+     * Response containing the challenge.
+     */
+    response: PipelineResponse;
+}
+
+/**
+ * Options sent to the authorizeRequest callback
+ */
+export declare interface AuthorizeRequestOptions {
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Function that retrieves either a cached access token or a new access token.
+     */
+    getAccessToken: (scopes: string[], options: GetTokenOptions) => Promise<AccessToken | null>;
+    /**
+     * Request that the policy is trying to fulfill.
+     */
+    request: PipelineRequest;
+}
+
+/**
  * A policy that can request a token from a TokenCredential implementation and
@@ -85,2 +127,50 @@ * then apply it to the Authorization header of a request as a Bearer token.
 /**
+ * A policy that can request a token from a TokenCredential implementation and
+ * then apply it to the Authorization header of a request as a Bearer token.
+ */
+export declare function bearerTokenChallengeAuthenticationPolicy(options: BearerTokenChallengeAuthenticationPolicyOptions): PipelinePolicy;
+
+/**
+ * The programmatic identifier of the bearerTokenChallengeAuthenticationPolicy.
+ */
+export declare const bearerTokenChallengeAuthenticationPolicyName = "bearerTokenChallengeAuthenticationPolicy";
+
+/**
+ * Options to configure the bearerTokenChallengeAuthenticationPolicy
+ */
+export declare interface BearerTokenChallengeAuthenticationPolicyOptions {
+    /**
+     * The TokenCredential implementation that can supply the bearer token.
+     */
+    credential?: TokenCredential;
+    /**
+     * The scopes for which the bearer token applies.
+     */
+    scopes: string[];
+    /**
+     * Allows for the processing of [Continuous Access Evaluation](https://docs.microsoft.com/azure/active-directory/conditional-access/concept-continuous-access-evaluation) challenges.
+     * If provided, it must contain at least the `authorizeRequestOnChallenge` method.
+     * If provided, after a request is sent, if it has a challenge, it can be processed to re-send the original request with the relevant challenge information.
+     */
+    challengeCallbacks?: ChallengeCallbacks;
+}
+
+/**
+ * Options to override the processing of [Continuous Access Evaluation](https://docs.microsoft.com/azure/active-directory/conditional-access/concept-continuous-access-evaluation) challenges.
+ */
+export declare interface ChallengeCallbacks {
+    /**
+     * Allows for the authorization of the main request of this policy before it's sent.
+     */
+    authorizeRequest?(options: AuthorizeRequestOptions): Promise<void>;
+    /**
+     * Allows to handle authentication challenges and to re-authorize the request.
+     * The response containing the challenge is `options.response`.
+     * If this method returns true, the underlying request will be sent once again.
+     * The request may be modified before being sent.
+     */
+    authorizeRequestOnChallenge?(options: AuthorizeRequestOnChallengeOptions): Promise<boolean>;
+}
+
+/**
  * Create the correct HttpClient for the current environment.
@@ -87,0 +177,0 @@ */

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

565568

increased by13.84%

Number of package files

92

increased by4.55%

Lines of code

6065

increased by12.54%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes