@azure/msal-node - npm Package Compare versions

Comparing version 2.7.0 to 2.7.1-alpha.0

dist/client/ClientApplication.d.ts

@@ -1,2 +0,2 @@
-import { ClientConfiguration, AuthenticationResult, BaseAuthRequest, Logger, ServerTelemetryManager, AzureRegionConfiguration, AzureCloudOptions, AuthorizationCodePayload } from "@azure/msal-common";
+import { ClientConfiguration, AuthenticationResult, BaseAuthRequest, Logger, ServerTelemetryManager, AzureRegionConfiguration, AzureCloudOptions, AuthorizationCodePayload, ClientAssertionCallback } from "@azure/msal-common";
 import { Configuration, NodeConfiguration } from "../config/Configuration.js";
@@ -35,2 +35,3 @@ import { CryptoProvider } from "../crypto/CryptoProvider.js";
     protected clientAssertion: ClientAssertion;
+    protected developerProvidedClientAssertion: string | ClientAssertionCallback;
     /**
@@ -37,0 +38,0 @@ * Client secret passed by the user for confidential client flows

dist/config/Configuration.d.ts

 /// <reference types="node" />
 /// <reference types="node" />
-import { LoggerOptions, INetworkModule, ProtocolMode, ICachePlugin, AzureCloudOptions, ApplicationTelemetry, INativeBrokerPlugin } from "@azure/msal-common";
+import { LoggerOptions, INetworkModule, ProtocolMode, ICachePlugin, AzureCloudOptions, ApplicationTelemetry, INativeBrokerPlugin, ClientAssertionCallback } from "@azure/msal-common";
 import http from "http";
@@ -12,3 +12,3 @@ import https from "https";
  * - clientSecret           - Secret string that the application uses when requesting a token. Only used in confidential client applications. Can be created in the Azure app registration portal.
- * - clientAssertion        - Assertion string that the application uses when requesting a token. Only used in confidential client applications. Assertion should be of type urn:ietf:params:oauth:client-assertion-type:jwt-bearer.
+ * - clientAssertion        - A ClientAssertion object containing an assertion string or a callback function that returns an assertion string that the application uses when requesting a token, as well as the assertion's type (urn:ietf:params:oauth:client-assertion-type:jwt-bearer). Only used in confidential client applications.
  * - clientCertificate      - Certificate that the application uses when requesting a token. Only used in confidential client applications. Requires hex encoded X.509 SHA-1 thumbprint of the certificiate, and the PEM encoded private key (string should contain -----BEGIN PRIVATE KEY----- ... -----END PRIVATE KEY----- )
@@ -23,3 +23,3 @@ * - protocolMode           - Enum that represents the protocol that msal follows. Used for configuring proper endpoints.
     clientSecret?: string;
-    clientAssertion?: string;
+    clientAssertion?: string | ClientAssertionCallback;
     clientCertificate?: {
@@ -46,2 +46,5 @@ thumbprint: string;
     cachePlugin?: ICachePlugin;
+    /**
+     * @deprecated claims-based-caching functionality will be removed in the next version of MSALJS
+     */
     claimsBasedCachingEnabled?: boolean;
@@ -48,0 +51,0 @@ };

dist/error/ManagedIdentityError.d.ts

@@ -9,3 +9,2 @@ import { AuthError } from "@azure/msal-common";
     invalid_managed_identity_id_type: string;
-    invalid_resource: string;
     missing_client_id: string;
@@ -12,0 +11,0 @@ azure_pod_identity_authority_host_url_malformed: string;

dist/error/ManagedIdentityErrorCodes.d.ts

 export declare const invalidManagedIdentityIdType = "invalid_managed_identity_id_type";
-export declare const invalidResource = "invalid_resource";
 export declare const missingId = "missing_client_id";
@@ -4,0 +3,0 @@ export declare const networkUnavailable = "network_unavailable";

dist/index.d.ts

@@ -43,4 +43,4 @@ /**
 export type { ManagedIdentityRequestParams } from "./request/ManagedIdentityRequestParams.js";
-export { PromptValue, ResponseMode, AuthorizationCodePayload, AuthenticationResult, ServerAuthorizationCodeResponse, IdTokenClaims, AccountInfo, ValidCacheType, AuthError, AuthErrorMessage, AuthErrorCodes, ClientAuthError, ClientAuthErrorCodes, ClientAuthErrorMessage, ClientConfigurationError, ClientConfigurationErrorCodes, ClientConfigurationErrorMessage, InteractionRequiredAuthError, InteractionRequiredAuthErrorCodes, InteractionRequiredAuthErrorMessage, ServerError, INetworkModule, NetworkRequestOptions, NetworkResponse, Logger, LogLevel, ProtocolMode, ICachePlugin, TokenCacheContext, ISerializableTokenCache, AzureCloudInstance, AzureCloudOptions, IAppTokenProvider, AppTokenProviderParameters, AppTokenProviderResult, INativeBrokerPlugin, } from "@azure/msal-common";
+export { PromptValue, ResponseMode, AuthorizationCodePayload, AuthenticationResult, ServerAuthorizationCodeResponse, IdTokenClaims, AccountInfo, ValidCacheType, AuthError, AuthErrorMessage, AuthErrorCodes, ClientAuthError, ClientAuthErrorCodes, ClientAuthErrorMessage, ClientConfigurationError, ClientConfigurationErrorCodes, ClientConfigurationErrorMessage, InteractionRequiredAuthError, InteractionRequiredAuthErrorCodes, InteractionRequiredAuthErrorMessage, ServerError, INetworkModule, NetworkRequestOptions, NetworkResponse, Logger, LogLevel, ProtocolMode, ICachePlugin, TokenCacheContext, ISerializableTokenCache, AzureCloudInstance, AzureCloudOptions, IAppTokenProvider, AppTokenProviderParameters, AppTokenProviderResult, INativeBrokerPlugin, ClientAssertionCallback, } from "@azure/msal-common";
 export { version } from "./packageMetadata.js";
 //# sourceMappingURL=index.d.ts.map

dist/network/HttpClient.d.ts

@@ -18,3 +18,3 @@ /// <reference types="node" />
      */
-    sendGetRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<NetworkResponse<T>>;
+    sendGetRequestAsync<T>(url: string, options?: NetworkRequestOptions, timeout?: number): Promise<NetworkResponse<T>>;
     /**
@@ -25,4 +25,4 @@ * Http Post request
      */
-    sendPostRequestAsync<T>(url: string, options?: NetworkRequestOptions, cancellationToken?: number): Promise<NetworkResponse<T>>;
+    sendPostRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<NetworkResponse<T>>;
 }
 //# sourceMappingURL=HttpClient.d.ts.map

dist/packageMetadata.d.ts

 export declare const name = "@azure/msal-node";
-export declare const version = "2.7.0";
+export declare const version = "2.7.1-alpha.0";
 //# sourceMappingURL=packageMetadata.d.ts.map

dist/request/ClientCredentialRequest.d.ts

@@ -1,2 +0,2 @@
-import { CommonClientCredentialRequest } from "@azure/msal-common";
+import { ClientAssertionCallback, CommonClientCredentialRequest } from "@azure/msal-common";
 /**
@@ -8,3 +8,3 @@ * CommonClientCredentialRequest
  * - skipCache               - Skip token cache lookup and force request to authority to get a a new token. Defaults to false.
- * - clientAssertion         - A Base64Url-encoded signed JWT assertion string used in the Client Credential flow
+ * - clientAssertion         - An assertion string or a callback function that returns an assertion string (both are Base64Url-encoded signed JWTs) used in the Client Credential flow
  * - tokenQueryParameters    - String to string map of custom query parameters added to the /token call
@@ -14,4 +14,4 @@ * @public
 export type ClientCredentialRequest = Partial<Omit<CommonClientCredentialRequest, "resourceRequestMethod" | "resourceRequestUri" | "requestedClaimsHash" | "clientAssertion" | "storeInCache">> & {
-    clientAssertion?: string;
+    clientAssertion?: string | ClientAssertionCallback;
 };
 //# sourceMappingURL=ClientCredentialRequest.d.ts.map

dist/utils/Constants.d.ts

@@ -52,2 +52,3 @@ export declare const AUTHORIZATION_HEADER_NAME: string;
 export declare const ProxyStatus: {
+    readonly SUCCESS: 200;
     readonly SUCCESS_RANGE_START: 200;
@@ -132,3 +133,3 @@ readonly SUCCESS_RANGE_END: 299;
 export declare const MANAGED_IDENTITY_RETRY_DELAY = 1000;
-export declare const MANAGED_IDENTITY_HTTP_STATUS_CODES_TO_RETRY_ON: (500 | 404 | 408 | 429 | 503 | 504)[];
+export declare const MANAGED_IDENTITY_HTTP_STATUS_CODES_TO_RETRY_ON: (404 | 408 | 429 | 500 | 503 | 504)[];
 //# sourceMappingURL=Constants.d.ts.map

package.json

 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@azure/msal-node",
-  "version": "2.7.0",
+  "version": "2.7.1-alpha.0",
   "author": {
@@ -80,3 +80,3 @@ "name": "Microsoft",
   "dependencies": {
-    "@azure/msal-common": "14.9.0",
+    "@azure/msal-common": "14.9.1-alpha.0",
     "jsonwebtoken": "^9.0.0",
@@ -83,0 +83,0 @@ "uuid": "^8.3.0"

README.md

@@ -91,3 +91,3 @@ # Microsoft Authentication Library for Node (msal-node)
 | ----------------- | ------------------- | ----------------------- |
-| 2.x.x             | Active development  | 16, 18, 20              |
+| 2.x.x             | Active development  | 16, 18, 20, 22          |
 | 1.x.x             | In maintenance      | 10, 12, 14, 16, 18      |
@@ -94,0 +94,0 @@

src/client/ClientApplication.ts

@@ -36,2 +36,5 @@ /*
     buildStaticAuthorityOptions,
+    ClientAssertion as ClientAssertionType,
+    getClientAssertion,
+    ClientAssertionCallback,
 } from "@azure/msal-common";
@@ -81,2 +84,5 @@ import {
     protected clientAssertion: ClientAssertion;
+    protected developerProvidedClientAssertion:
+        | string
+        | ClientAssertionCallback;
     /**
@@ -456,4 +462,4 @@ * Client secret passed by the user for confidential client flows
                 clientSecret: this.clientSecret,
-                clientAssertion: this.clientAssertion
-                    ? this.getClientAssertion(discoveredAuthority)
+                clientAssertion: this.developerProvidedClientAssertion
+                    ? await this.getClientAssertion(discoveredAuthority)
                     : undefined,
@@ -475,6 +481,13 @@ },
 
-    private getClientAssertion(authority: Authority): {
-        assertion: string;
-        assertionType: string;
-    } {
+    private async getClientAssertion(
+        authority: Authority
+    ): Promise<ClientAssertionType> {
+        this.clientAssertion = ClientAssertion.fromAssertion(
+            await getClientAssertion(
+                this.developerProvidedClientAssertion,
+                this.config.auth.clientId,
+                authority.tokenEndpoint
+            )
+        );
+
         return {
@@ -481,0 +494,0 @@ assertion: this.clientAssertion.getJwt(

src/client/ClientCredentialClient.ts

@@ -35,2 +35,4 @@ /*
     createClientAuthError,
+    ClientAssertion,
+    getClientAssertion,
 } from "@azure/msal-common";
@@ -63,3 +65,3 @@ import {
     ): Promise<AuthenticationResult | null> {
-        if (request.skipCache) {
+        if (request.skipCache || request.claims) {
             return this.executeTokenRequest(request, this.authority);
@@ -275,3 +277,3 @@ }
 
-            const requestBody = this.createTokenRequestBody(request);
+            const requestBody = await this.createTokenRequestBody(request);
             const headers: Record<string, string> =
@@ -336,5 +338,5 @@ this.createTokenRequestHeaders();
      */
-    private createTokenRequestBody(
+    private async createTokenRequestBody(
         request: CommonClientCredentialRequest
-    ): string {
+    ): Promise<string> {
         const parameterBuilder = new RequestParameterBuilder();
@@ -371,3 +373,3 @@
         // Use clientAssertion from request, fallback to client assertion in base configuration
-        const clientAssertion =
+        const clientAssertion: ClientAssertion | undefined =
             request.clientAssertion ||
@@ -377,3 +379,9 @@ this.config.clientCredentials.clientAssertion;
         if (clientAssertion) {
-            parameterBuilder.addClientAssertion(clientAssertion.assertion);
+            parameterBuilder.addClientAssertion(
+                await getClientAssertion(
+                    clientAssertion.assertion,
+                    this.config.authOptions.clientId,
+                    request.resourceRequestUri
+                )
+            );
             parameterBuilder.addClientAssertionType(
@@ -380,0 +388,0 @@ clientAssertion.assertionType

src/client/ConfidentialClientApplication.ts

@@ -29,2 +29,4 @@ /*
     ClientAuthErrorCodes,
+    ClientAssertion as ClientAssertionType,
+    getClientAssertion,
 } from "@azure/msal-common";
@@ -95,6 +97,10 @@ import { IConfidentialClientApplication } from "./IConfidentialClientApplication.js";
         // If there is a client assertion present in the request, it overrides the one present in the client configuration
-        let clientAssertion;
+        let clientAssertion: ClientAssertionType | undefined;
         if (request.clientAssertion) {
             clientAssertion = {
-                assertion: request.clientAssertion,
+                assertion: await getClientAssertion(
+                    request.clientAssertion,
+                    this.config.auth.clientId
+                    // tokenEndpoint will be undefined. resourceRequestUri is omitted in ClientCredentialRequest
+                ),
                 assertionType: NodeConstants.JWT_BEARER_ASSERTION_TYPE,
@@ -252,5 +258,4 @@ };
         if (configuration.auth.clientAssertion) {
-            this.clientAssertion = ClientAssertion.fromAssertion(
-                configuration.auth.clientAssertion
-            );
+            this.developerProvidedClientAssertion =
+                configuration.auth.clientAssertion;
             return;
@@ -257,0 +262,0 @@ }

src/client/ManagedIdentityApplication.ts

@@ -19,3 +19,4 @@ /*
     AuthenticationResult,
-    UrlString,
+    createClientConfigurationError,
+    ClientConfigurationErrorCodes,
 } from "@azure/msal-common";
@@ -35,6 +36,2 @@ import {
 import { DEFAULT_AUTHORITY_FOR_MANAGED_IDENTITY } from "../utils/Constants";
-import {
-    ManagedIdentityErrorCodes,
-    createManagedIdentityError,
-} from "../error/ManagedIdentityError";
 
@@ -127,10 +124,5 @@ /**
     ): Promise<AuthenticationResult> {
-        const resourceUrlString = new UrlString(
-            managedIdentityRequestParams.resource.replace("/.default", "")
-        );
-        try {
-            resourceUrlString.validateAsUri();
-        } catch (e) {
-            throw createManagedIdentityError(
-                ManagedIdentityErrorCodes.invalidResource
+        if (!managedIdentityRequestParams.resource) {
+            throw createClientConfigurationError(
+                ClientConfigurationErrorCodes.urlEmptyError
             );
@@ -137,0 +129,0 @@ }

src/client/ManagedIdentitySources/BaseManagedIdentitySource.ts

@@ -84,2 +84,12 @@ /*
     ): ServerAuthorizationTokenResponse {
+        let refreshIn, expiresIn: number | undefined;
+        if (response.body.expires_on) {
+            expiresIn = response.body.expires_on - TimeUtils.nowSeconds();
+
+            // compute refresh_in as 1/2 of expires_in, but only if expires_in > 2h
+            if (expiresIn > 2 * 3600) {
+                refreshIn = expiresIn / 2;
+            }
+        }
+
         const serverTokenResponse: ServerAuthorizationTokenResponse = {
@@ -90,5 +100,6 @@ status: response.status,
             access_token: response.body.access_token,
-            expires_in: response.body.expires_on,
+            expires_in: expiresIn,
             scope: response.body.resource,
             token_type: response.body.token_type,
+            refresh_in: refreshIn,
 
@@ -100,10 +111,2 @@ // error
 
-        // compute refresh_in as 1/2 of expires_in, but only if expires_in > 2h
-        if (
-            serverTokenResponse.expires_in &&
-            serverTokenResponse.expires_in > 2 * 3600
-        ) {
-            serverTokenResponse.refresh_in = serverTokenResponse.expires_in / 2;
-        }
-
         return serverTokenResponse;
@@ -110,0 +113,0 @@ }

src/client/OnBehalfOfClient.ts

@@ -33,2 +33,4 @@ /*
     UrlString,
+    ClientAssertion,
+    getClientAssertion,
 } from "@azure/msal-common";
@@ -62,3 +64,3 @@ import { EncodingUtils } from "../utils/EncodingUtils";
 
-        if (request.skipCache) {
+        if (request.skipCache || request.claims) {
             return this.executeTokenRequest(
@@ -262,3 +264,3 @@ request,
         );
-        const requestBody = this.createTokenRequestBody(request);
+        const requestBody = await this.createTokenRequestBody(request);
         const headers: Record<string, string> =
@@ -313,3 +315,5 @@ this.createTokenRequestHeaders();
      */
-    private createTokenRequestBody(request: CommonOnBehalfOfRequest): string {
+    private async createTokenRequestBody(
+        request: CommonOnBehalfOfRequest
+    ): Promise<string> {
         const parameterBuilder = new RequestParameterBuilder();
@@ -350,6 +354,13 @@
 
-        if (this.config.clientCredentials.clientAssertion) {
-            const clientAssertion =
-                this.config.clientCredentials.clientAssertion;
-            parameterBuilder.addClientAssertion(clientAssertion.assertion);
+        const clientAssertion: ClientAssertion | undefined =
+            this.config.clientCredentials.clientAssertion;
+
+        if (clientAssertion) {
+            parameterBuilder.addClientAssertion(
+                await getClientAssertion(
+                    clientAssertion.assertion,
+                    this.config.authOptions.clientId,
+                    request.resourceRequestUri
+                )
+            );
             parameterBuilder.addClientAssertionType(
@@ -356,0 +367,0 @@ clientAssertion.assertionType

src/client/UsernamePasswordClient.ts

@@ -11,2 +11,3 @@ /*
     CcsCredentialType,
+    ClientAssertion,
     ClientConfiguration,
@@ -23,2 +24,3 @@ CommonUsernamePasswordRequest,
     UrlString,
+    getClientAssertion,
 } from "@azure/msal-common";
@@ -86,3 +88,3 @@
         );
-        const requestBody = this.createTokenRequestBody(request);
+        const requestBody = await this.createTokenRequestBody(request);
         const headers: Record<string, string> = this.createTokenRequestHeaders({
@@ -117,5 +119,5 @@ credential: request.username,
      */
-    private createTokenRequestBody(
+    private async createTokenRequestBody(
         request: CommonUsernamePasswordRequest
-    ): string {
+    ): Promise<string> {
         const parameterBuilder = new RequestParameterBuilder();
@@ -155,6 +157,13 @@
 
-        if (this.config.clientCredentials.clientAssertion) {
-            const clientAssertion =
-                this.config.clientCredentials.clientAssertion;
-            parameterBuilder.addClientAssertion(clientAssertion.assertion);
+        const clientAssertion: ClientAssertion | undefined =
+            this.config.clientCredentials.clientAssertion;
+
+        if (clientAssertion) {
+            parameterBuilder.addClientAssertion(
+                await getClientAssertion(
+                    clientAssertion.assertion,
+                    this.config.authOptions.clientId,
+                    request.resourceRequestUri
+                )
+            );
             parameterBuilder.addClientAssertionType(
@@ -161,0 +170,0 @@ clientAssertion.assertionType

src/config/Configuration.ts

@@ -17,2 +17,3 @@ /*
     INativeBrokerPlugin,
+    ClientAssertionCallback,
 } from "@azure/msal-common";
@@ -36,3 +37,3 @@ import { HttpClient } from "../network/HttpClient.js";
  * - clientSecret           - Secret string that the application uses when requesting a token. Only used in confidential client applications. Can be created in the Azure app registration portal.
- * - clientAssertion        - Assertion string that the application uses when requesting a token. Only used in confidential client applications. Assertion should be of type urn:ietf:params:oauth:client-assertion-type:jwt-bearer.
+ * - clientAssertion        - A ClientAssertion object containing an assertion string or a callback function that returns an assertion string that the application uses when requesting a token, as well as the assertion's type (urn:ietf:params:oauth:client-assertion-type:jwt-bearer). Only used in confidential client applications.
  * - clientCertificate      - Certificate that the application uses when requesting a token. Only used in confidential client applications. Requires hex encoded X.509 SHA-1 thumbprint of the certificiate, and the PEM encoded private key (string should contain -----BEGIN PRIVATE KEY----- ... -----END PRIVATE KEY----- )
@@ -47,3 +48,3 @@ * - protocolMode           - Enum that represents the protocol that msal follows. Used for configuring proper endpoints.
     clientSecret?: string;
-    clientAssertion?: string;
+    clientAssertion?: string | ClientAssertionCallback;
     clientCertificate?: {
@@ -71,2 +72,5 @@ thumbprint: string;
     cachePlugin?: ICachePlugin;
+    /**
+     * @deprecated claims-based-caching functionality will be removed in the next version of MSALJS
+     */
     claimsBasedCachingEnabled?: boolean;
@@ -73,0 +77,0 @@ };

src/error/ManagedIdentityError.ts

@@ -17,4 +17,2 @@ /*
         "More than one ManagedIdentityIdType was provided.",
-    [ManagedIdentityErrorCodes.invalidResource]:
-        "The supplied resource is an invalid URL.",
     [ManagedIdentityErrorCodes.missingId]:
@@ -21,0 +19,0 @@ "A ManagedIdentityId id was not provided.",

src/error/ManagedIdentityErrorCodes.ts

@@ -9,3 +9,2 @@ /*
 export const invalidManagedIdentityIdType = "invalid_managed_identity_id_type";
-export const invalidResource = "invalid_resource";
 export const missingId = "missing_client_id";
@@ -12,0 +11,0 @@ export const networkUnavailable = "network_unavailable";

src/index.ts

@@ -128,4 +128,5 @@ /*
     INativeBrokerPlugin,
+    ClientAssertionCallback,
 } from "@azure/msal-common";
 
 export { version } from "./packageMetadata.js";

src/network/HttpClient.ts

@@ -39,3 +39,4 @@ /*
         url: string,
-        options?: NetworkRequestOptions
+        options?: NetworkRequestOptions,
+        timeout?: number
     ): Promise<NetworkResponse<T>> {
@@ -48,3 +49,4 @@ if (this.proxyUrl) {
                 options,
-                this.customAgentOptions as http.AgentOptions
+                this.customAgentOptions as http.AgentOptions,
+                timeout
             );
@@ -57,3 +59,3 @@ } else {
                 this.customAgentOptions as https.AgentOptions,
-                undefined
+                timeout
             );
@@ -70,4 +72,3 @@ }
         url: string,
-        options?: NetworkRequestOptions,
-        cancellationToken?: number
+        options?: NetworkRequestOptions
     ): Promise<NetworkResponse<T>> {
@@ -80,4 +81,3 @@ if (this.proxyUrl) {
                 options,
-                this.customAgentOptions as http.AgentOptions,
-                cancellationToken
+                this.customAgentOptions as http.AgentOptions
             );
@@ -89,4 +89,3 @@ } else {
                 options,
-                this.customAgentOptions as https.AgentOptions,
-                cancellationToken
+                this.customAgentOptions as https.AgentOptions
             );
@@ -118,6 +117,2 @@ }
 
-    if (timeout) {
-        tunnelRequestOptions.timeout = timeout;
-    }
-
     if (agentOptions && Object.keys(agentOptions).length) {
@@ -135,2 +130,7 @@ tunnelRequestOptions.agent = new http.Agent(agentOptions);
             `\r\n${body}`;
+    } else {
+        // optional timeout is only for get requests (regionDiscovery, for example)
+        if (timeout) {
+            tunnelRequestOptions.timeout = timeout;
+        }
     }
@@ -147,3 +147,3 @@ const outgoingRequestString =
 
-        if (tunnelRequestOptions.timeout) {
+        if (timeout) {
             request.on("timeout", () => {
@@ -177,10 +177,2 @@ request.destroy();
             }
-            if (tunnelRequestOptions.timeout) {
-                socket.setTimeout(tunnelRequestOptions.timeout);
-                socket.on("timeout", () => {
-                    request.destroy();
-                    socket.destroy();
-                    reject(new Error("Request time out"));
-                });
-            }
 
@@ -304,6 +296,2 @@ // make a request over an HTTP tunnel
 
-    if (timeout) {
-        customOptions.timeout = timeout;
-    }
-
     if (agentOptions && Object.keys(agentOptions).length) {
@@ -319,2 +307,7 @@ customOptions.agent = new https.Agent(agentOptions);
         };
+    } else {
+        // optional timeout is only for get requests (regionDiscovery, for example)
+        if (timeout) {
+            customOptions.timeout = timeout;
+        }
     }
@@ -331,2 +324,6 @@
 
+        if (isPostRequest) {
+            request.write(body);
+        }
+
         if (timeout) {
@@ -339,6 +336,2 @@ request.on("timeout", () => {
 
-        if (isPostRequest) {
-            request.write(body);
-        }
-
         request.end();
@@ -345,0 +338,0 @@

src/packageMetadata.ts

 /* eslint-disable header/header */
 export const name = "@azure/msal-node";
-export const version = "2.7.0";
+export const version = "2.7.1-alpha.0";

src/request/ClientCredentialRequest.ts

@@ -6,3 +6,6 @@ /*
 
-import { CommonClientCredentialRequest } from "@azure/msal-common";
+import {
+    ClientAssertionCallback,
+    CommonClientCredentialRequest,
+} from "@azure/msal-common";
 
@@ -15,3 +18,3 @@ /**
  * - skipCache               - Skip token cache lookup and force request to authority to get a a new token. Defaults to false.
- * - clientAssertion         - A Base64Url-encoded signed JWT assertion string used in the Client Credential flow
+ * - clientAssertion         - An assertion string or a callback function that returns an assertion string (both are Base64Url-encoded signed JWTs) used in the Client Credential flow
  * - tokenQueryParameters    - String to string map of custom query parameters added to the /token call
@@ -30,3 +33,3 @@ * @public
 > & {
-    clientAssertion?: string;
+    clientAssertion?: string | ClientAssertionCallback;
 };

src/utils/Constants.ts

@@ -68,5 +68,6 @@ /*
 export const ProxyStatus = {
-    SUCCESS_RANGE_START: 200,
-    SUCCESS_RANGE_END: 299,
-    SERVER_ERROR: 500,
+    SUCCESS: HttpStatus.SUCCESS,
+    SUCCESS_RANGE_START: HttpStatus.SUCCESS_RANGE_START,
+    SUCCESS_RANGE_END: HttpStatus.SUCCESS_RANGE_END,
+    SERVER_ERROR: HttpStatus.SERVER_ERROR,
 } as const;
@@ -164,5 +165,5 @@ export type ProxyStatus = (typeof ProxyStatus)[keyof typeof ProxyStatus];
     HttpStatus.TOO_MANY_REQUESTS,
-    HttpStatus.INTERNAL_SERVER_ERROR,
+    HttpStatus.SERVER_ERROR,
     HttpStatus.SERVICE_UNAVAILABLE,
     HttpStatus.GATEWAY_TIMEOUT,
 ];

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1129190

increased by0.35%

Lines of code

18533

increased by0.23%

Worsened metrics

Number of low quality alerts

2

increased by100%

Dependency changes

• + Added@azure/msal-common@14.9.1-alpha.0(transitive)

• - Removed@azure/msal-common@14.9.0(transitive)

• Updated@azure/msal-common@14.9.1-alpha.0