@bancor/contracts-solidity - npm Package Compare versions

Comparing version 0.6.2 to 0.6.3

CHANGELOG.md

@@ -0,1 +1,9 @@
+### 0.6.3 (2020-06-17)
+BancorNetwork
+* Fixed an issue in the backward compatibility layer for older converters
+
+ConverterUpgrader
+* Fixed an issue in the backward compatibility layer for older converters
+
+
 ### 0.6.2 (2020-06-16)
@@ -2,0 +10,0 @@ BancorNetwork

package.json

 {
   "name": "@bancor/contracts-solidity",
-  "version": "0.6.2",
+  "version": "0.6.3",
   "description": "The solidity version of the Bancor smart contracts is composed of many different components that work together to create the Bancor Network deployment.",
@@ -5,0 +5,0 @@ "repository": {

solidity/test/BancorNetwork.js

@@ -19,3 +19,7 @@ /* global artifacts, contract, before, it, assert, web3 */
 const ConverterHelper = require('./helpers/Converter');
-const TestBancorNetwork = artifacts.require('./helpers/TestBancorNetwork');
+const TestBancorNetwork = artifacts.require('TestBancorNetwork');
+const ConverterV27OrLowerWithoutFallback = artifacts.require('ConverterV27OrLowerWithoutFallback');
+const ConverterV27OrLowerWithFallback = artifacts.require('ConverterV27OrLowerWithFallback');
+const ConverterV28OrHigherWithoutFallback = artifacts.require('ConverterV28OrHigherWithoutFallback');
+const ConverterV28OrHigherWithFallback = artifacts.require('ConverterV28OrHigherWithFallback');
 
@@ -26,2 +30,3 @@ const ETH_RESERVE_ADDRESS = '0x'.padEnd(42, 'e');
 
+let network;
 let bntToken;
@@ -286,10 +291,26 @@ let erc20Token1;
         before(async () => {
+            network = await TestBancorNetwork.new(0, 0);
             await initTokensAndConverters(accounts);
         });
 
-        it('verifies that isV28OrHigherConverter returns true', async () => {
-            let network = await TestBancorNetwork.new(0, 0);
-            assert.isTrue(await network.isV28OrHigherConverterExternal.call(converter1.address));
+        it('verifies that isV28OrHigherConverter returns false for ConverterV27OrLowerWithoutFallback', async () => {
+            let converter = await ConverterV27OrLowerWithoutFallback.new();
+            assert.isFalse(await network.isV28OrHigherConverterExternal.call(converter.address));
         });
 
+        it('verifies that isV28OrHigherConverter returns false for ConverterV27OrLowerWithFallback', async () => {
+            let converter = await ConverterV27OrLowerWithFallback.new();
+            assert.isFalse(await network.isV28OrHigherConverterExternal.call(converter.address));
+        });
+
+        it('verifies that isV28OrHigherConverter returns true for ConverterV28OrHigherWithoutFallback', async () => {
+            let converter = await ConverterV28OrHigherWithoutFallback.new();
+            assert.isTrue(await network.isV28OrHigherConverterExternal.call(converter.address));
+        });
+
+        it('verifies that isV28OrHigherConverter returns true for ConverterV28OrHigherWithFallback', async () => {
+            let converter = await ConverterV28OrHigherWithFallback.new();
+            assert.isTrue(await network.isV28OrHigherConverterExternal.call(converter.address));
+        });
+
         for (let sourceSymbol in pathsTokens) {
@@ -296,0 +317,0 @@ for (let targetSymbol in pathsTokens[sourceSymbol]) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1547187

increased by0.11%

Lines of code

6094

increased by0.3%

No dependency changes