@bandwidth/numbers - npm Package Compare versions

Comparing version 1.7.0 to 1.8.0

lib/sipPeer.js

@@ -53,2 +53,7 @@ var Client = require("./client");
 
+SipPeer.prototype.update = function(data, callback) {
+  const url = this.client.concatAccountPath(SITE_PATH + "/" + this.siteId + "/" + SIP_PEER_PATH + "/" + this.id);
+  this.client.makeRequest('put', url, {sipPeer: data}, callback);
+};
+
 SipPeer.prototype.getTns = function(number, callback){
@@ -55,0 +60,0 @@ var url = this.client.concatAccountPath(SITE_PATH + "/" + this.siteId + "/" + SIP_PEER_PATH + "/" + this.id + "/" + TNS_PATH);

lib/tnOption.js

@@ -69,2 +69,3 @@ var Client = require("./client");
    }
+   item = item.tnOptionOrder;
    if (item.tnOptionGroups && item.tnOptionGroups.tnOptionGroup) {
@@ -71,0 +72,0 @@ item.tnOptionGroups = item.tnOptionGroups.tnOptionGroup;

package.json

 {
   "name": "@bandwidth/numbers",
-  "version": "1.7.0",
+  "version": "1.8.0",
   "description": "NodeJs Client library for Bandwidth Numbers API",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -5,2 +5,5 @@ # node-numbers
 
+## Developer Docs
+* [[Bandwidth API Developer Docs](https://dev.bandwidth.com)
+
 ## Other Node SDKs
@@ -29,2 +32,3 @@ * Messaging: https://github.com/Bandwidth/node-messaging
 | 1.7.0 | Added get products to account |
+| 1.7.1 | Fix TnOptions.create() callback bug |
 
@@ -665,5 +669,5 @@
   isDefaultPeer:false,
-  shortMessagingProtocol:"SMPP",
+  shortMessagingProtocol:"SMPP",    // `HTTP` for use with the v2 messaging API
   siteId:selectedSite,
-  voiceHosts:[
+  voiceHosts:[    // optional
     {
@@ -675,3 +679,3 @@ host:{
   ],
-  smsHosts:[
+  smsHosts:[    // optional
     {
@@ -682,10 +686,2 @@ host:{
     }
-  ],
-  terminationHosts:[
-    {
-      terminationHost:{
-        hostName:"1.1.1.1",
-        port:5060,
-      }
-    }
   ]
@@ -709,2 +705,9 @@ };
 
+### Update SIP Peer
+
+```Javascript
+sipPeer.peerName = "Some new name";
+sipPeer.update(sipPeer, callback);
+```
+
 ### Delete SIP Peer
@@ -1391,3 +1394,3 @@
 var voiceHttpSettings = {
-  httpVoiceV2AppId: "abcd-1234" 
+  httpVoiceV2AppId: "abcd-1234"
 }
@@ -1394,0 +1397,0 @@ await sipPeer.createOriginationSettingsAsync({voiceProtocol: "HTTP", httpSettings: voiceHttpSettings})

test/sipPeer.js

@@ -103,2 +103,13 @@ var lib = require("../");
   });
+  describe("#update", function(){
+    it("should update a peer", function(done){
+      var data = {peerName: "Test Sip Peer" };
+      helper.nock().put("/accounts/FakeAccountId/sites/1/sippeers/10", helper.buildXml({sipPeer: data})).reply(200);
+      var peer = new SipPeer();
+      peer.client = helper.createClient();
+      peer.siteId = 1;
+      peer.id = 10;
+      peer.update(data, done);
+    });
+  });
   describe("#delete", function(){
@@ -105,0 +116,0 @@ it("should remove a peer", function(done){

test/tnOption.js

@@ -120,3 +120,3 @@ var lib = require("../");
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
@@ -156,3 +156,3 @@ if(err){
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
@@ -194,3 +194,3 @@ if(err){
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
@@ -197,0 +197,0 @@ if(err){

test/xml.json

@@ -6,2 +6,3 @@ {
   "tnOption": "<TnOptionOrder><OrderCreateDate>createdDate</OrderCreateDate><AccountId>14</AccountId><CreatedByUser>user</CreatedByUser><OrderId>orderId</OrderId><LastModifiedDate>dateHere</LastModifiedDate><ProcessingStatus>FAILED</ProcessingStatus><TnOptionGroups><TnOptionGroup><NumberFormat>10digit</NumberFormat><RPIDFormat>10digit</RPIDFormat><RewriteUser>testUser1</RewriteUser><CallForward>6042661720</CallForward><CallingNameDisplay>on</CallingNameDisplay><Protected>true</Protected><Sms>on</Sms><FinalDestinationURI>sip:[phone]@1.2.3.4:5060</FinalDestinationURI><TelephoneNumbers><TelephoneNumber>2018551020</TelephoneNumber></TelephoneNumbers></TnOptionGroup><TnOptionGroup><CallingNameDisplay>off</CallingNameDisplay><Protected>false</Protected><Sms>off</Sms><TelephoneNumbers><TelephoneNumber>2018551025</TelephoneNumber></TelephoneNumbers></TnOptionGroup></TnOptionGroups></TnOptionOrder>",
+  "tnOptionOrderResponse": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><TnOptionOrderResponse><TnOptionOrder><OrderCreateDate>createdDate</OrderCreateDate><AccountId>14</AccountId><CreatedByUser>user</CreatedByUser><OrderId>orderId</OrderId><LastModifiedDate>dateHere</LastModifiedDate><ProcessingStatus>FAILED</ProcessingStatus><TnOptionGroups><TnOptionGroup><NumberFormat>10digit</NumberFormat><RPIDFormat>10digit</RPIDFormat><RewriteUser>testUser1</RewriteUser><CallForward>6042661720</CallForward><CallingNameDisplay>on</CallingNameDisplay><Protected>true</Protected><Sms>on</Sms><FinalDestinationURI>sip:[phone]@1.2.3.4:5060</FinalDestinationURI><TelephoneNumbers><TelephoneNumber>2018551020</TelephoneNumber></TelephoneNumbers></TnOptionGroup><TnOptionGroup><CallingNameDisplay>off</CallingNameDisplay><Protected>false</Protected><Sms>off</Sms><TelephoneNumbers><TelephoneNumber>2018551025</TelephoneNumber></TelephoneNumbers></TnOptionGroup></TnOptionGroups></TnOptionOrder></TnOptionOrderResponse>",
   "geocode": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><GeocodeRequestResponse><GeocodedAddress><AddressLine1>1 Street Name</AddressLine1><HouseNumber>1</HouseNumber><StreetName>Street</StreetName><StreetSuffix>Name</StreetSuffix><City>City</City><StateCode>State</StateCode><Zip>ZipCode</Zip><PlusFour>1234</PlusFour><Country>US</Country></GeocodedAddress></GeocodeRequestResponse>",
@@ -8,0 +9,0 @@ "peerApplications": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><ApplicationSettingsResponse><ApplicationSettings><HttpMessagingV2AppId>100</HttpMessagingV2AppId></ApplicationSettings></ApplicationSettingsResponse>",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

391339

increased by0.89%

Number of package files

95

increased by4.4%

Lines of code

8658

increased by0.23%

Number of lines in readme file

1398

increased by0.22%

No dependency changes