@binary-com/binary-style - npm Package Compare versions

Comparing version 0.2.7 to 0.2.8

package.json

 {
   "name": "@binary-com/binary-style",
-  "version": "0.2.7",
+  "version": "0.2.8",
   "description": "Style system and guide for Binary.com",
@@ -5,0 +5,0 @@ "main": "binary.js",

src/js/binary.js

@@ -100,3 +100,3 @@ /*
             const selected_value = $selector.val();
-            const dropdown_value = $target.attr('value');
+            const dropdown_value = $target.data('value');
 
@@ -161,5 +161,5 @@ // sync original select with selected dropdown value
                 case 13:
-                    if (active_target && active_target.attr('value') && (active_target.attr('value') !== selected_value) || active_target.attr('value') === '') {
+                    if (active_target && active_target.data('value') && (active_target.data('value') !== selected_value) || active_target.data('value') === '') {
                         $target.find('li.select-items').removeClass('selected');
-                        triggerEventChange(active_target.attr('value'));
+                        triggerEventChange(active_target.data('value'));
                         active_target.addClass('selected');
@@ -178,5 +178,5 @@ $select_dropdown.text(active_target.text()).removeClass('show').wrapInner('<span></span>');
                     else if ($select_dropdown.hasClass('show') && $select_dropdown.hasClass('focused')) {
-                        if (active_target && active_target.attr('value') && (active_target.attr('value') !== selected_value) || active_target.attr('value') === '') {
+                        if (active_target && active_target.data('value') && (active_target.data('value') !== selected_value) || active_target.data('value') === '') {
                             $target.find('li.select-items').removeClass('selected');
-                            triggerEventChange(active_target.attr('value'));
+                            triggerEventChange(active_target.data('value'));
                             active_target.addClass('selected');
@@ -234,5 +234,5 @@ $select_dropdown.text(active_target.text()).removeClass('show').wrapInner('<span></span>');
             $('<li />', {
-                text : $el.text(),
-                value: $el.val(),
-                class: className,
+                'text'      : $el.text(),
+                'data-value': $el.val(),
+                'class'     : className,
             }).appendTo($list);
@@ -239,0 +239,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2330583

No dependency changes