@changesets/assemble-release-plan - npm Package Compare versions

Comparing version 5.0.4 to 5.0.5

CHANGELOG.md

 # @changesets/assemble-release-plan
 
+## 5.0.5
+
+### Patch Changes
+
+- [#693](https://github.com/changesets/changesets/pull/693) [`1be201f`](https://github.com/changesets/changesets/commit/1be201fc27903cb2f42137400b5484c4ccad3812) Thanks [@luciaquirke](https://github.com/luciaquirke)! - Fixed an issue with `none` release type sometimes overriding other release types and thus preventing a release from happening.
+
+- Updated dependencies [[`6f9c9d6`](https://github.com/changesets/changesets/commit/6f9c9d60c0e02c79d555c48deb01559057f1d252)]:
+  - @changesets/get-dependents-graph@1.3.0
+
 ## 5.0.4
@@ -4,0 +13,0 @@

dist/assemble-release-plan.cjs.dev.js

@@ -281,7 +281,4 @@ 'use strict';
       } else {
-        // If the type was already major, we never need to update it
-        if (release.type === "minor" && type === "major") {
+        if (type === "major" || (release.type === "patch" || release.type === "none") && (type === "minor" || type === "patch")) {
           release.type = type;
-        } else if (release.type === "patch" && (type === "major" || type === "minor")) {
-          release.type = type;
         } // Check whether the bumpType will change
@@ -288,0 +285,0 @@ // If the bumpType has changed recalc newVersion

dist/assemble-release-plan.cjs.prod.js

@@ -138,3 +138,3 @@ "use strict";
       if (!pkg) throw new Error("Could not find package information for " + name);
-      release ? ("minor" === release.type && "major" === type ? release.type = type : "patch" !== release.type || "major" !== type && "minor" !== type || (release.type = type), 
+      release ? ("major" !== type && ("patch" !== release.type && "none" !== release.type || "minor" !== type && "patch" !== type) || (release.type = type), 
       release.changesets.push(changeset.id)) : release = {
@@ -141,0 +141,0 @@ name: name,

dist/assemble-release-plan.esm.js

@@ -273,7 +273,4 @@ import semver, { inc, parse } from 'semver';
       } else {
-        // If the type was already major, we never need to update it
-        if (release.type === "minor" && type === "major") {
+        if (type === "major" || (release.type === "patch" || release.type === "none") && (type === "minor" || type === "patch")) {
           release.type = type;
-        } else if (release.type === "patch" && (type === "major" || type === "minor")) {
-          release.type = type;
         } // Check whether the bumpType will change
@@ -280,0 +277,0 @@ // If the bumpType has changed recalc newVersion

package.json

 {
   "name": "@changesets/assemble-release-plan",
-  "version": "5.0.4",
+  "version": "5.0.5",
   "description": "Reads changesets and adds information on dependents that need bumping",
@@ -12,3 +12,3 @@ "main": "dist/assemble-release-plan.cjs.js",
     "@changesets/errors": "^0.1.4",
-    "@changesets/get-dependents-graph": "^1.2.4",
+    "@changesets/get-dependents-graph": "^1.3.0",
     "@changesets/types": "^4.0.2",
@@ -15,0 +15,0 @@ "@manypkg/get-packages": "^1.1.3",

src/flatten-releases.ts

@@ -34,8 +34,6 @@ // This function takes in changesets and returns one release per
         } else {
-          // If the type was already major, we never need to update it
-          if (release.type === "minor" && type === "major") {
-            release.type = type;
-          } else if (
-            release.type === "patch" &&
-            (type === "major" || type === "minor")
+          if (
+            type === "major" ||
+            ((release.type === "patch" || release.type === "none") &&
+              (type === "minor" || type === "patch"))
           ) {
@@ -42,0 +40,0 @@ release.type = type;

src/index.test.ts

@@ -105,2 +105,49 @@ import { defaultConfig } from "@changesets/config";
   });
+  it("`none` changeset should not override other release types", () => {
+    setup.addChangeset({
+      id: "big-cats-delight",
+      releases: [
+        { name: "pkg-a", type: "none" },
+        { name: "pkg-b", type: "none" },
+        { name: "pkg-c", type: "none" }
+      ]
+    });
+    setup.addChangeset({
+      id: "big-cats-wonder",
+      releases: [
+        { name: "pkg-a", type: "patch" },
+        { name: "pkg-b", type: "minor" },
+        { name: "pkg-c", type: "major" }
+      ]
+    });
+    setup.addChangeset({
+      id: "big-cats-yelp",
+      releases: [
+        { name: "pkg-a", type: "none" },
+        { name: "pkg-b", type: "none" },
+        { name: "pkg-c", type: "none" }
+      ]
+    });
+
+    let { releases } = assembleReleasePlan(
+      setup.changesets,
+      setup.packages,
+      defaultConfig,
+      undefined
+    );
+
+    expect(releases.length).toEqual(3);
+
+    expect(releases[0].name).toEqual("pkg-a");
+    expect(releases[0].type).toEqual("patch");
+    expect(releases[0].newVersion).toEqual("1.0.1");
+
+    expect(releases[1].name).toEqual("pkg-b");
+    expect(releases[1].type).toEqual("minor");
+    expect(releases[1].newVersion).toEqual("1.1.0");
+
+    expect(releases[2].name).toEqual("pkg-c");
+    expect(releases[2].type).toEqual("major");
+    expect(releases[2].newVersion).toEqual("2.0.0");
+  });
   it("should assemble release plan with dependents", () => {
@@ -107,0 +154,0 @@ setup.updateDependency("pkg-b", "pkg-a", "^1.0.0");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

135226

increased by1.13%

Lines of code

2995

increased by1.15%

Dependency changes

• Updated@changesets/get-dependents-graph@^1.3.0