@ciscospark/media-engine-webrtc - npm Package Compare versions

Comparing version 1.50.3 to 1.50.6

dist/engine.js

@@ -54,2 +54,6 @@ 'use strict';
 
+var _bowser = require('bowser');
+
+var _bowser2 = _interopRequireDefault(_bowser);
+
 var _lodashDecorators = require('lodash-decorators');
@@ -75,6 +79,2 @@
 
-var _bowser = require('bowser');
-
-var _bowser2 = _interopRequireDefault(_bowser);
-
 var _webrtcHelpers = require('./webrtc-helpers');
@@ -81,0 +81,0 @@

package.json

 {
   "name": "@ciscospark/media-engine-webrtc",
-  "version": "1.50.3",
+  "version": "1.50.6",
   "description": "",
@@ -20,9 +20,9 @@ "license": "MIT",
     "lodash": "^4.17.11",
+    "bowser": "1.9.4",
     "lodash-decorators": "^4.3.4",
     "core-decorators": "^0.20.0",
-    "@ciscospark/common": "1.50.3",
-    "@ciscospark/common-evented": "1.50.3",
+    "@ciscospark/common": "1.50.6",
+    "@ciscospark/common-evented": "1.50.6",
     "ampersand-events": "^2.0.2",
     "sdp-transform": "^2.4.0",
-    "bowser": "^1.6.0",
     "webrtc-adapter": "^6.1.0",
@@ -29,0 +29,0 @@ "envify": "^4.1.0"

src/engine.js

@@ -0,1 +1,2 @@
+import bowser from 'bowser';
 import {debounce} from 'lodash-decorators';
@@ -9,3 +10,2 @@ import {nonenumerable} from 'core-decorators';
 import grammar from 'sdp-transform/lib/grammar';
-import browser from 'bowser';
 
@@ -501,3 +501,3 @@ import {
           const sender = this.pc.getSenders().find((s) => s.track === track);
-          if (!browser.firefox) {
+          if (!bowser.firefox) {
             this.localMediaStream.removeTrack(track);
@@ -511,3 +511,3 @@ }
             // browsers will still create SDP media field if we don't remote the track
-            if (!browser.firefox) {
+            if (!bowser.firefox) {
               this.pc.removeTrack(sender);
@@ -514,0 +514,0 @@ }

test/unit/spec/engine.js

 /* global step: false */
 
-import browser from 'bowser';
+import bowser from 'bowser';
 import 'mocha-steps';
@@ -149,3 +149,3 @@ import {assert} from '@ciscospark/test-helper-chai';
 
-              const shouldSkip = (browser.chrome && (flakyInChrome || brokenInChrome)) || (browser.firefox && brokenInFirefox);
+              const shouldSkip = (bowser.chrome && (flakyInChrome || brokenInChrome)) || (bowser.firefox && brokenInFirefox);
 
@@ -260,5 +260,5 @@ // See `renegotiation-support.md` for renegotiation and ontrack table
                     || !audioStart.includes('recv') && audioEnd.includes('recv')
-                      && !(browser.firefox && audioStart === 'sendonly' && audioEnd.includes('recv'))
+                      && !(bowser.firefox && audioStart === 'sendonly' && audioEnd.includes('recv'))
                     || !videoStart.includes('recv') && videoEnd.includes('recv')
-                      && !(browser.firefox && videoStart === 'sendonly' && videoEnd.includes('recv'));
+                      && !(bowser.firefox && videoStart === 'sendonly' && videoEnd.includes('recv'));
 
@@ -281,6 +281,6 @@ expectToRenegotiateOnTransition = expectNewRemoteTrackOnTransition
                           // correct direction on sdp so we skip the assertions
-                          if (!browser.firefox || audioEnd !== 'inactive') {
+                          if (!bowser.firefox || audioEnd !== 'inactive') {
                             assertOffer('audio', audioEnd, audioStart, offerSdp);
                           }
-                          if (!browser.firefox || videoEnd !== 'inactive') {
+                          if (!bowser.firefox || videoEnd !== 'inactive') {
                             assertOffer('video', videoEnd, videoStart, offerSdp);
@@ -292,6 +292,6 @@ }
                         .then((answerSdp) => {
-                          if (!browser.firefox || audioEnd !== 'inactive') {
+                          if (!bowser.firefox || audioEnd !== 'inactive') {
                             assertAnswer('audio', audioEnd, audioStart, answerSdp);
                           }
-                          if (!browser.firefox || videoEnd !== 'inactive') {
+                          if (!bowser.firefox || videoEnd !== 'inactive') {
                             assertAnswer('video', videoEnd, videoStart, answerSdp);
@@ -308,3 +308,3 @@ }
                       // generates extra receiver tracks. We ignore those changes for now.
-                      if (!browser.firefox
+                      if (!bowser.firefox
                         || !expectToRenegotiateOnTransition
@@ -351,3 +351,3 @@ || ((videoStart !== 'sendonly' || !videoEnd.includes('recv'))
                   expectNewRemoteTrackOnReturn = expectNewRemoteTrackOnReturn
-                    || browser.chrome
+                    || bowser.chrome
                       && (!audioEnd.includes('recv') && audioStart.includes('recv')
@@ -389,3 +389,3 @@ || !videoEnd.includes('recv') && videoStart.includes('recv'))
                       // generates extra receiver tracks. We ignore those changes for now.
-                      if (!browser.firefox
+                      if (!bowser.firefox
                         || !expectToRenegotiateOnTransition
@@ -392,0 +392,0 @@ || ((videoStart !== 'sendonly' || !videoEnd.includes('recv'))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

212385

decreased by-0.01%

Dependency changes

• + Added@ciscospark/common@1.50.6(transitive)

• + Added@ciscospark/common-evented@1.50.6(transitive)

• - Removed@ciscospark/common@1.50.3(transitive)

• - Removed@ciscospark/common-evented@1.50.3(transitive)

• Updated@ciscospark/common@1.50.6

• Updated@ciscospark/common-evented@1.50.6

• Updatedbowser@1.9.4