@ckeditor/ckeditor5-easy-image - npm Package Compare versions

Comparing version 1.0.0-alpha.1 to 1.0.0-alpha.2

CHANGELOG.md

 Changelog
 =========
 
+## [1.0.0-alpha.2](https://github.com/ckeditor/ckeditor5-easy-image/compare/v1.0.0-alpha.1...v1.0.0-alpha.2) (2017-11-14)
+
+### Bug fixes
+
+* Prevented `UploadGateway` from being created when `cloudServices#tokenUrl` is not provided. Closes [#9](https://github.com/ckeditor/ckeditor5-easy-image/issues/9). ([cdc6662](https://github.com/ckeditor/ckeditor5-easy-image/commit/cdc6662))
+
+### Other changes
+
+* Aligned code to the new `CloudeServices` API and used the `ckeditor5-cloudservices` package. Closes [#7](https://github.com/ckeditor/ckeditor5-easy-image/issues/7). ([ce800f7](https://github.com/ckeditor/ckeditor5-easy-image/commit/ce800f7))
+
+  The plugin will now automatically refresh the token when it expired.
+
+### BREAKING CHANGES
+
+* The Easy Image plugin does not use `config.cloudServices.token` anymore. The new option name is `config.cloudServices.tokenUrl` with a URL to the token server.
+
+
 ## 1.0.0-alpha.1 (2017-10-03)
 
 Internal changes only (updated dependencies, documentation, etc.).

package.json

 {
   "name": "@ckeditor/ckeditor5-easy-image",
-  "version": "1.0.0-alpha.1",
+  "version": "1.0.0-alpha.2",
   "description": "Easy Image feature for CKEditor 5.",
@@ -10,15 +10,16 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor-cloudservices-core": "^0.1.0",
-    "@ckeditor/ckeditor5-core": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-image": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-upload": "^1.0.0-alpha.1"
+    "@ckeditor/ckeditor-cloudservices-core": "^0.2.0",
+    "@ckeditor/ckeditor5-cloudservices": "^1.0.0-alpha.1",
+    "@ckeditor/ckeditor5-core": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-image": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-upload": "^1.0.0-alpha.2"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-dev-lint": "^3.1.4",
-    "@ckeditor/ckeditor5-editor-classic": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-paragraph": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-utils": "^1.0.0-alpha.1",
+    "@ckeditor/ckeditor5-editor-classic": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-paragraph": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-utils": "^1.0.0-alpha.2",
+    "eslint": "^4.8.0",
     "eslint-config-ckeditor5": "^1.0.6",
-    "gulp": "^3.9.1",
-    "guppy-pre-commit": "^0.4.0"
+    "husky": "^0.14.3",
+    "lint-staged": "^4.2.3"
   },
@@ -41,3 +42,16 @@ "engines": {
     "theme"
+  ],
+  "scripts": {
+    "lint": "eslint --quiet '**/*.js'",
+    "precommit": "lint-staged"
+  },
+  "lint-staged": {
+    "**/*.js": [
+      "eslint --quiet"
+    ]
+  },
+  "eslintIgnore": [
+    "src/lib/**",
+    "packages/**"
   ]
 }

src/cloudservicesuploadadapter.js

@@ -13,2 +13,3 @@ /**
 import UploadGateway from '@ckeditor/ckeditor-cloudservices-core/src/uploadgateway/uploadgateway';
+import CloudServices from '@ckeditor/ckeditor5-cloudservices/src/cloudservices';
 
@@ -21,3 +22,3 @@ /**
  * After enabling this adapter you need to configure the Cloud Services integration through
- * {@link module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig `config.cloudServices`}.
+ * {@link module:cloudservices/cloudservices~CloudServicesConfig `config.cloudServices`}.
  *
@@ -31,3 +32,3 @@ * @extends module:core/plugin~Plugin
 	static get requires() {
-		return [ FileRepository ];
+		return [ FileRepository, CloudServices ];
 	}
@@ -40,10 +41,9 @@
 		const editor = this.editor;
-		const config = editor.config;
 
-		config.define( 'cloudServices.uploadUrl', 'https://files.cke-cs.com/upload/' );
+		const cloudServices = editor.plugins.get( CloudServices );
 
-		const token = config.get( 'cloudServices.token' );
-		const uploadUrl = config.get( 'cloudServices.uploadUrl' );
+		const token = cloudServices.token;
+		const uploadUrl = cloudServices.uploadUrl;
 
-		if ( !token || !uploadUrl ) {
+		if ( !token ) {
 			return;
@@ -89,44 +89,1 @@ }
 CloudServicesUploadAdapter._UploadGateway = UploadGateway;
-
-/**
- * The configuration of the {@link module:easy-image/cloudservicesuploadadapter~CloudServicesUploadAdapter Cloud Services upload adapter}.
- *
- * It is used mainly by the {@link module:easy-image/easyimage~EasyImage} feature.
- *
- * Read more in {@link module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig}.
- *
- * @member {module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig}
- *         module:core/editor/editorconfig~EditorConfig#cloudServices
- */
-
-/**
- * The configuration of the {@link module:easy-image/cloudservicesuploadadapter~CloudServicesUploadAdapter Cloud Services upload adapter}.
- *
- * It is used mainly by the {@link module:easy-image/easyimage~EasyImage} feature.
- *
- *		ClassicEditor
- *			.create( editorElement, {
- * 				cloudServices: {
- *					token: '...',
- *					uploadUrl: 'https://files.cke-cs.com/upload/'
- * 				}
- *			} )
- *			.then( ... )
- *			.catch( ... );
- *
- * See {@link module:core/editor/editorconfig~EditorConfig all editor options}.
- *
- * @interface CloudServicesAdapterConfig
- */
-
-/**
- * The URL to which the files should be uploaded.
- *
- * @member {String} module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig#uploadUrl
- */
-
-/**
- * The token to the Cloud Services application. You can obtain it from the token service.
- *
- * @member {String} module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig#token
- */

src/easyimage.js

@@ -25,3 +25,3 @@ /**
  * After enabling the Easy Image plugin you need to configure the Cloud Services integration through
- * {@link module:easy-image/cloudservicesuploadadapter~CloudServicesAdapterConfig `config.cloudServices`}.
+ * {@link module:cloudservices/cloudservices~CloudServicesConfig `config.cloudServices`}.
  *
@@ -28,0 +28,0 @@ * @extends module:core/plugin~Plugin

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

9270

decreased by-3.13%

Dependency count

5

increased by25%

Lines of code

111

decreased by-26%

Dependency changes

• + Added@ckeditor/ckeditor5-cloudservices@^1.0.0-alpha.1

• + Added@ckeditor/ckeditor-cloudservices-core@0.2.0(transitive)

• + Added@ckeditor/ckeditor5-cloudservices@1.0.0-beta.1(transitive)

• - Removed@ckeditor/ckeditor-cloudservices-core@0.1.1(transitive)

• Updated@ckeditor/ckeditor-cloudservices-core@^0.2.0

• Updated@ckeditor/ckeditor5-core@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-image@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-upload@^1.0.0-alpha.2