@ckeditor/ckeditor5-editor-classic - npm Package Compare versions

Comparing version 1.0.0-alpha.1 to 1.0.0-alpha.2

CHANGELOG.md

 Changelog
 =========
 
+## [1.0.0-alpha.2](https://github.com/ckeditor/ckeditor5-editor-classic/compare/v1.0.0-alpha.1...v1.0.0-alpha.2) (2017-11-14)
+
+### Other changes
+
+* Aligned UI library usage to the [changes in the UI framework](https://github.com/ckeditor/ckeditor5-ui/pull/332).
+
+
 ## [1.0.0-alpha.1](https://github.com/ckeditor/ckeditor5-editor-classic/compare/v0.8.0...v1.0.0-alpha.1) (2017-10-03)
@@ -5,0 +12,0 @@

package.json

 {
   "name": "@ckeditor/ckeditor5-editor-classic",
-  "version": "1.0.0-alpha.1",
+  "version": "1.0.0-alpha.2",
   "description": "Classic editor implementation for CKEditor 5.",
@@ -10,19 +10,19 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-core": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-engine": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-theme-lark": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-ui": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-utils": "^1.0.0-alpha.1"
+    "@ckeditor/ckeditor5-core": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-engine": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-theme-lark": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-ui": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-utils": "^1.0.0-alpha.2"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-dev-lint": "^3.1.4",
-    "@ckeditor/ckeditor5-basic-styles": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-enter": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-heading": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-paragraph": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-undo": "^1.0.0-alpha.1",
-    "@ckeditor/ckeditor5-typing": "^1.0.0-alpha.1",
+    "@ckeditor/ckeditor5-basic-styles": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-enter": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-heading": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-paragraph": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-typing": "^1.0.0-alpha.2",
+    "@ckeditor/ckeditor5-undo": "^1.0.0-alpha.2",
+    "eslint": "^4.8.0",
     "eslint-config-ckeditor5": "^1.0.6",
-    "gulp": "^3.9.1",
-    "guppy-pre-commit": "^0.4.0"
+    "husky": "^0.14.3",
+    "lint-staged": "^4.2.3"
   },
@@ -45,3 +45,16 @@ "engines": {
     "theme"
+  ],
+  "scripts": {
+    "lint": "eslint --quiet '**/*.js'",
+    "precommit": "lint-staged"
+  },
+  "lint-staged": {
+    "**/*.js": [
+      "eslint --quiet"
+    ]
+  },
+  "eslintIgnore": [
+    "src/lib/**",
+    "packages/**"
   ]
 }

src/classiceditor.js

@@ -131,5 +131,5 @@ /**
 				editor.initPlugins()
-					.then( () => editor._elementReplacer.replace( element, editor.ui.view.element ) )
+					.then( () => editor.ui.init() )
 					.then( () => {
-						editor.ui.init();
+						editor._elementReplacer.replace( element, editor.ui.view.element );
 						editor.fire( 'uiReady' );
@@ -136,0 +136,0 @@ } )

src/classiceditorui.js

@@ -55,7 +55,13 @@ /**
 		this._toolbarConfig = normalizeToolbarConfig( editor.config.get( 'toolbar' ) );
+	}
 
-		// Set–up the view.
-		view.set( 'width', editor.config.get( 'ui.width' ) );
-		view.set( 'height', editor.config.get( 'ui.height' ) );
+	/**
+	 * Initializes the UI.
+	 */
+	init() {
+		const editor = this.editor;
+		const view = this.view;
 
+		view.render();
+
 		// Set–up the sticky panel with toolbar.
@@ -65,3 +71,3 @@ view.stickyPanel.bind( 'isActive' ).to( this.focusTracker, 'isFocused' );
 
-		if ( this._toolbarConfig && this._toolbarConfig.viewportTopOffset ) {
+		if ( this._toolbarConfig.viewportTopOffset ) {
 			view.stickyPanel.viewportTopOffset = this._toolbarConfig.viewportTopOffset;
@@ -75,17 +81,7 @@ }
 		view.editable.name = editingRoot.rootName;
-		this.focusTracker.add( view.editableElement );
-	}
 
-	/**
-	 * Initializes the UI.
-	 */
-	init() {
-		const editor = this.editor;
+		this.focusTracker.add( this.view.editableElement );
 
-		this.view.init();
+		this.view.toolbar.fillFromConfig( this._toolbarConfig.items, this.componentFactory );
 
-		if ( this._toolbarConfig ) {
-			this.view.toolbar.fillFromConfig( this._toolbarConfig.items, this.componentFactory );
-		}
-
 		enableToolbarKeyboardFocus( {
@@ -92,0 +88,0 @@ origin: editor.editing.view,

src/classiceditoruiview.js

@@ -14,3 +14,2 @@ /**
 import ToolbarView from '@ckeditor/ckeditor5-ui/src/toolbar/toolbarview';
-import Template from '@ckeditor/ckeditor5-ui/src/template';
 
@@ -49,3 +48,3 @@ /**
 
-		Template.extend( this.toolbar.template, {
+		this.toolbar.extendTemplate( {
 			attributes: {
@@ -56,5 +55,2 @@ class: 'ck-editor-toolbar'
 
-		// Set toolbar as a child of a stickyPanel and makes toolbar sticky.
-		this.stickyPanel.content.add( this.toolbar );
-
 		/**
@@ -67,3 +63,13 @@ * Editable UI view.
 		this.editable = new InlineEditableUIView( locale );
+	}
 
+	/**
+	 * @inheritDoc
+	 */
+	render() {
+		super.render();
+
+		// Set toolbar as a child of a stickyPanel and makes toolbar sticky.
+		this.stickyPanel.content.add( this.toolbar );
+
 		this.top.add( this.stickyPanel );
@@ -70,0 +76,0 @@ this.main.add( this.editable );

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

19616

increased by1.58%

Lines of code

288

increased by0.35%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• Updated@ckeditor/ckeditor5-core@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-engine@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-theme-lark@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-ui@^1.0.0-alpha.2

• Updated@ckeditor/ckeditor5-utils@^1.0.0-alpha.2