@ckeditor/ckeditor5-media-embed - npm Package Compare versions

Comparing version 18.0.0 to 19.0.0

CHANGELOG.md

 Changelog
 =========
 
+## [19.0.0](https://github.com/ckeditor/ckeditor5-media-embed/compare/v18.0.0...v19.0.0) (2020-04-29)
+
+### Other changes
+
+* Replaced `LabeledInputView` with `LabeledFieldView`. See [ckeditor/ckeditor5#6110](https://github.com/ckeditor/ckeditor5/issues/6110). ([bc00c8b](https://github.com/ckeditor/ckeditor5-media-embed/commit/bc00c8b))
+* Updated translations. ([8ac4d13](https://github.com/ckeditor/ckeditor5-media-embed/commit/8ac4d13))
+
+
 ## [18.0.0](https://github.com/ckeditor/ckeditor5-media-embed/compare/v17.0.0...v18.0.0) (2020-03-19)
@@ -5,0 +13,0 @@

package.json

 {
   "name": "@ckeditor/ckeditor5-media-embed",
-  "version": "18.0.0",
+  "version": "19.0.0",
   "description": "Media Embed feature for CKEditor 5.",
@@ -13,19 +13,19 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-clipboard": "^18.0.0",
-    "@ckeditor/ckeditor5-core": "^18.0.0",
-    "@ckeditor/ckeditor5-engine": "^18.0.0",
-    "@ckeditor/ckeditor5-image": "^18.0.0",
-    "@ckeditor/ckeditor5-ui": "^18.0.0",
-    "@ckeditor/ckeditor5-undo": "^18.0.0",
-    "@ckeditor/ckeditor5-utils": "^18.0.0",
-    "@ckeditor/ckeditor5-widget": "^18.0.0"
+    "@ckeditor/ckeditor5-clipboard": "^19.0.0",
+    "@ckeditor/ckeditor5-core": "^19.0.0",
+    "@ckeditor/ckeditor5-engine": "^19.0.0",
+    "@ckeditor/ckeditor5-image": "^19.0.0",
+    "@ckeditor/ckeditor5-ui": "^19.0.0",
+    "@ckeditor/ckeditor5-undo": "^19.0.0",
+    "@ckeditor/ckeditor5-utils": "^19.0.0",
+    "@ckeditor/ckeditor5-widget": "^19.0.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^18.0.0",
-    "@ckeditor/ckeditor5-editor-balloon": "^18.0.0",
-    "@ckeditor/ckeditor5-editor-classic": "^18.0.0",
-    "@ckeditor/ckeditor5-link": "^18.0.0",
-    "@ckeditor/ckeditor5-list": "^18.0.0",
-    "@ckeditor/ckeditor5-paragraph": "^18.0.0",
-    "@ckeditor/ckeditor5-typing": "^18.0.0",
+    "@ckeditor/ckeditor5-basic-styles": "^19.0.0",
+    "@ckeditor/ckeditor5-editor-balloon": "^19.0.0",
+    "@ckeditor/ckeditor5-editor-classic": "^19.0.0",
+    "@ckeditor/ckeditor5-link": "^19.0.0",
+    "@ckeditor/ckeditor5-list": "^19.0.0",
+    "@ckeditor/ckeditor5-paragraph": "^19.0.0",
+    "@ckeditor/ckeditor5-typing": "^19.0.0",
     "eslint": "^5.5.0",
@@ -32,0 +32,0 @@ "eslint-config-ckeditor5": "^2.0.0",

src/mediaembedui.js

@@ -81,3 +81,3 @@ /**
 			// Make sure that each time the panel shows up, the URL field remains in sync with the value of
-			// the command. If the user typed in the input, then canceled (`urlInputView#value` stays
+			// the command. If the user typed in the input, then canceled (`urlInputView#fieldView#value` stays
 			// unaltered) and re-opened it without changing the value of the media command (e.g. because they
@@ -87,3 +87,3 @@ // didn't change the selection), they would see the old value instead of the actual value of the
 			form.url = command.value || '';
-			form.urlInputView.select();
+			form.urlInputView.fieldView.select();
 			form.focus();
@@ -90,0 +90,0 @@ }, { priority: 'low' } );

src/ui/mediaformview.js

@@ -14,5 +14,6 @@ /**
 import ButtonView from '@ckeditor/ckeditor5-ui/src/button/buttonview';
-import LabeledInputView from '@ckeditor/ckeditor5-ui/src/labeledinput/labeledinputview';
-import InputTextView from '@ckeditor/ckeditor5-ui/src/inputtext/inputtextview';
 
+import LabeledFieldView from '@ckeditor/ckeditor5-ui/src/labeledfield/labeledfieldview';
+import { createLabeledInputText } from '@ckeditor/ckeditor5-ui/src/labeledfield/utils';
+
 import submitHandler from '@ckeditor/ckeditor5-ui/src/bindings/submithandler';
@@ -63,3 +64,3 @@ import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';
 		 *
-		 * @member {module:ui/labeledinput/labeledinputview~LabeledInputView}
+		 * @member {module:ui/labeledfield/labeledfieldview~LabeledFieldView}
 		 */
@@ -217,3 +218,3 @@ this.urlInputView = this._createUrlInput();
 	get url() {
-		return this.urlInputView.inputView.element.value.trim();
+		return this.urlInputView.fieldView.element.value.trim();
 	}
@@ -230,3 +231,3 @@
 	set url( url ) {
-		this.urlInputView.inputView.element.value = url.trim();
+		this.urlInputView.fieldView.element.value = url.trim();
 	}
@@ -272,3 +273,3 @@
 	 * @private
-	 * @returns {module:ui/labeledinput/labeledinputview~LabeledInputView} Labeled input view instance.
+	 * @returns {module:ui/labeledfield/labeledfieldview~LabeledFieldView} Labeled input view instance.
 	 */
@@ -278,4 +279,4 @@ _createUrlInput() {
 
-		const labeledInput = new LabeledInputView( this.locale, InputTextView );
-		const inputView = labeledInput.inputView;
+		const labeledInput = new LabeledFieldView( this.locale, createLabeledInputText );
+		const inputField = labeledInput.fieldView;
 
@@ -287,7 +288,7 @@ this._urlInputViewInfoDefault = t( 'Paste the media URL in the input.' );
 		labeledInput.infoText = this._urlInputViewInfoDefault;
-		inputView.placeholder = 'https://example.com';
+		inputField.placeholder = 'https://example.com';
 
-		inputView.on( 'input', () => {
+		inputField.on( 'input', () => {
 			// Display the tip text only when there's some value. Otherwise fall back to the default info text.
-			labeledInput.infoText = inputView.element.value ? this._urlInputViewInfoTip : this._urlInputViewInfoDefault;
+			labeledInput.infoText = inputField.element.value ? this._urlInputViewInfoTip : this._urlInputViewInfoDefault;
 		} );
@@ -294,0 +295,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

146573

increased by0.37%

Dependency changes

• + Added@ckeditor/ckeditor5-clipboard@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-core@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-engine@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-image@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-ui@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-undo@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-upload@19.0.1(transitive)

• + Added@ckeditor/ckeditor5-utils@19.0.2(transitive)

• + Added@ckeditor/ckeditor5-widget@19.1.0(transitive)

• - Removed@ckeditor/ckeditor5-clipboard@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-core@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-engine@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-image@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-ui@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-undo@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-upload@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-utils@18.0.0(transitive)

• - Removed@ckeditor/ckeditor5-widget@18.0.0(transitive)

• Updated@ckeditor/ckeditor5-clipboard@^19.0.0

• Updated@ckeditor/ckeditor5-core@^19.0.0

• Updated@ckeditor/ckeditor5-engine@^19.0.0

• Updated@ckeditor/ckeditor5-image@^19.0.0

• Updated@ckeditor/ckeditor5-ui@^19.0.0

• Updated@ckeditor/ckeditor5-undo@^19.0.0

• Updated@ckeditor/ckeditor5-utils@^19.0.0

• Updated@ckeditor/ckeditor5-widget@^19.0.0