@ckeditor/ckeditor5-media-embed - npm Package Compare versions

Comparing version 20.0.0 to 21.0.0

package.json

 {
   "name": "@ckeditor/ckeditor5-media-embed",
-  "version": "20.0.0",
+  "version": "21.0.0",
   "description": "Media Embed feature for CKEditor 5.",
@@ -13,20 +13,20 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-clipboard": "^20.0.0",
-    "@ckeditor/ckeditor5-core": "^20.0.0",
-    "@ckeditor/ckeditor5-engine": "^20.0.0",
-    "@ckeditor/ckeditor5-image": "^20.0.0",
-    "@ckeditor/ckeditor5-ui": "^20.0.0",
-    "@ckeditor/ckeditor5-undo": "^20.0.0",
-    "@ckeditor/ckeditor5-utils": "^20.0.0",
-    "@ckeditor/ckeditor5-widget": "^20.0.0"
+    "@ckeditor/ckeditor5-clipboard": "^21.0.0",
+    "@ckeditor/ckeditor5-core": "^21.0.0",
+    "@ckeditor/ckeditor5-engine": "^21.0.0",
+    "@ckeditor/ckeditor5-image": "^21.0.0",
+    "@ckeditor/ckeditor5-ui": "^21.0.0",
+    "@ckeditor/ckeditor5-undo": "^21.0.0",
+    "@ckeditor/ckeditor5-utils": "^21.0.0",
+    "@ckeditor/ckeditor5-widget": "^21.0.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^20.0.0",
-    "@ckeditor/ckeditor5-editor-balloon": "^20.0.0",
-    "@ckeditor/ckeditor5-editor-classic": "^20.0.0",
-    "@ckeditor/ckeditor5-link": "^20.0.0",
-    "@ckeditor/ckeditor5-list": "^20.0.0",
-    "@ckeditor/ckeditor5-paragraph": "^20.0.0",
-    "@ckeditor/ckeditor5-typing": "^20.0.0",
-    "@ckeditor/ckeditor5-table": "^20.0.0"
+    "@ckeditor/ckeditor5-basic-styles": "^21.0.0",
+    "@ckeditor/ckeditor5-editor-balloon": "^21.0.0",
+    "@ckeditor/ckeditor5-editor-classic": "^21.0.0",
+    "@ckeditor/ckeditor5-link": "^21.0.0",
+    "@ckeditor/ckeditor5-list": "^21.0.0",
+    "@ckeditor/ckeditor5-paragraph": "^21.0.0",
+    "@ckeditor/ckeditor5-typing": "^21.0.0",
+    "@ckeditor/ckeditor5-table": "^21.0.0"
   },
@@ -33,0 +33,0 @@ "engines": {

src/automediaembed.js

@@ -123,3 +123,3 @@ /**
 		for ( const node of walker ) {
-			if ( node.item.is( 'textProxy' ) ) {
+			if ( node.item.is( '$textProxy' ) ) {
 				url += node.item.data;
@@ -126,0 +126,0 @@ }

src/mediaregistry.js

@@ -237,8 +237,4 @@ /**
 
-			viewElement = writer.createUIElement( 'div', attributes, function( domDocument ) {
-				const domElement = this.toDomElement( domDocument );
-
+			viewElement = writer.createRawElement( 'div', attributes, function( domElement ) {
 				domElement.innerHTML = mediaHtml;
-
-				return domElement;
 			} );
@@ -245,0 +241,0 @@ } else {

src/ui/mediaformview.js

@@ -213,3 +213,3 @@ /**
 	 *
-	 * @type {Number}
+	 * @type {String}
 	 */
@@ -220,10 +220,2 @@ get url() {
 
-	/**
-	 * Sets the native DOM `value` of the {@link #urlInputView} element.
-	 *
-	 * **Note**: Do not confuse it with the {@link module:ui/inputtext/inputtextview~InputTextView#value}
-	 * which works one way only and may not represent the actual state of the component in the DOM.
-	 *
-	 * @param {String} url
-	 */
 	set url( url ) {
@@ -230,0 +222,0 @@ this.urlInputView.fieldView.element.value = url.trim();

src/utils.js

@@ -78,8 +78,2 @@ /**
 
-	// TODO: This is a hack. Without it, the figure in the data pipeline will contain   because
-	// its only child is the UIElement (wrapper).
-	//
-	// Note: The hack is a copy&paste from widget utils; it makes the figure act like it's a widget.
-	figure.getFillerOffset = getFillerOffset;
-
 	writer.insert( writer.createPositionAt( figure, 0 ), registry.getMediaViewElement( writer, url, options ) );
@@ -99,3 +93,3 @@
 
-	if ( selectedElement && selectedElement.is( 'media' ) ) {
+	if ( selectedElement && selectedElement.is( 'element', 'media' ) ) {
 		return selectedElement;
@@ -128,5 +122,1 @@ }
 }
-
-function getFillerOffset() {
-	return null;
-}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

153407

increased by2.24%

Number of package files

62

increased by3.33%

Worsened metrics

Lines of code

1656

decreased by-1.08%

Dependency changes

• + Added@ckeditor/ckeditor5-clipboard@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-core@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-engine@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-image@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-typing@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-ui@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-undo@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-upload@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-utils@21.0.0(transitive)

• + Added@ckeditor/ckeditor5-widget@21.0.0(transitive)

• - Removed@ckeditor/ckeditor5-clipboard@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-core@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-engine@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-image@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-typing@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-ui@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-undo@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-upload@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-utils@20.0.0(transitive)

• - Removed@ckeditor/ckeditor5-widget@20.0.0(transitive)

• Updated@ckeditor/ckeditor5-clipboard@^21.0.0

• Updated@ckeditor/ckeditor5-core@^21.0.0

• Updated@ckeditor/ckeditor5-engine@^21.0.0

• Updated@ckeditor/ckeditor5-image@^21.0.0

• Updated@ckeditor/ckeditor5-ui@^21.0.0

• Updated@ckeditor/ckeditor5-undo@^21.0.0

• Updated@ckeditor/ckeditor5-utils@^21.0.0

• Updated@ckeditor/ckeditor5-widget@^21.0.0