@ckeditor/ckeditor5-media-embed - npm Package Compare versions

Comparing version 23.0.0 to 23.1.0

package.json

 {
   "name": "@ckeditor/ckeditor5-media-embed",
-  "version": "23.0.0",
+  "version": "23.1.0",
   "description": "Media Embed feature for CKEditor 5.",
@@ -13,20 +13,20 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-clipboard": "^23.0.0",
-    "@ckeditor/ckeditor5-core": "^23.0.0",
-    "@ckeditor/ckeditor5-engine": "^23.0.0",
-    "@ckeditor/ckeditor5-image": "^23.0.0",
-    "@ckeditor/ckeditor5-ui": "^23.0.0",
-    "@ckeditor/ckeditor5-undo": "^23.0.0",
-    "@ckeditor/ckeditor5-utils": "^23.0.0",
-    "@ckeditor/ckeditor5-widget": "^23.0.0"
+    "@ckeditor/ckeditor5-clipboard": "^23.1.0",
+    "@ckeditor/ckeditor5-core": "^23.1.0",
+    "@ckeditor/ckeditor5-engine": "^23.1.0",
+    "@ckeditor/ckeditor5-image": "^23.1.0",
+    "@ckeditor/ckeditor5-ui": "^23.1.0",
+    "@ckeditor/ckeditor5-undo": "^23.1.0",
+    "@ckeditor/ckeditor5-utils": "^23.1.0",
+    "@ckeditor/ckeditor5-widget": "^23.1.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^23.0.0",
-    "@ckeditor/ckeditor5-editor-balloon": "^23.0.0",
-    "@ckeditor/ckeditor5-editor-classic": "^23.0.0",
-    "@ckeditor/ckeditor5-link": "^23.0.0",
-    "@ckeditor/ckeditor5-list": "^23.0.0",
-    "@ckeditor/ckeditor5-paragraph": "^23.0.0",
-    "@ckeditor/ckeditor5-typing": "^23.0.0",
-    "@ckeditor/ckeditor5-table": "^23.0.0"
+    "@ckeditor/ckeditor5-basic-styles": "^23.1.0",
+    "@ckeditor/ckeditor5-editor-balloon": "^23.1.0",
+    "@ckeditor/ckeditor5-editor-classic": "^23.1.0",
+    "@ckeditor/ckeditor5-link": "^23.1.0",
+    "@ckeditor/ckeditor5-list": "^23.1.0",
+    "@ckeditor/ckeditor5-paragraph": "^23.1.0",
+    "@ckeditor/ckeditor5-typing": "^23.1.0",
+    "@ckeditor/ckeditor5-table": "^23.1.0"
   },
@@ -33,0 +33,0 @@ "engines": {

src/automediaembed.js

@@ -19,3 +19,3 @@ /**
 
-const URL_REGEXP = /^(?:http(s)?:\/\/)?[\w.-]+(?:\.[\w.-]+)+[\w\-._~:/?#[\]@!$&'()*+,;=]+$/;
+const URL_REGEXP = /^(?:http(s)?:\/\/)?[\w.-]+(?:\.[\w.-]+)+[\w\-._~:/?#[\]@!$&'()*+,;=%]+$/;
 
@@ -22,0 +22,0 @@ /**

src/mediaembedcommand.js

@@ -33,8 +33,9 @@ /**
 		const schema = model.schema;
-		const position = selection.getFirstPosition();
+		const insertPosition = findOptimalInsertionPosition( selection, model );
 		const selectedMedia = getSelectedMediaModelWidget( selection );
 
-		let parent = position.parent;
+		let parent = insertPosition.parent;
 
-		if ( parent != parent.root ) {
+		// The model.insertContent() will remove empty parent (unless it is a $root or a limit).
+		if ( parent.isEmpty && !model.schema.isLimit( parent ) ) {
 			parent = parent.parent;
@@ -72,2 +73,1 @@ }
 }
-

src/mediaembedui.js

@@ -44,3 +44,2 @@ /**
 
-		// Setup `imageUpload` button.
 		editor.ui.componentFactory.add( 'mediaEmbed', locale => {
@@ -108,3 +107,2 @@ const dropdown = createDropdown( locale );
 		form.urlInputView.bind( 'isReadOnly' ).to( command, 'isEnabled', value => !value );
-		form.saveButtonView.bind( 'isEnabled' ).to( command );
 	}
@@ -111,0 +109,0 @@ }

src/mediaregistry.js

@@ -10,4 +10,2 @@ /**
 
-/* globals console */
-
 import mediaPlaceholderIcon from '../theme/icons/media-placeholder.svg';
@@ -17,3 +15,3 @@ import TooltipView from '@ckeditor/ckeditor5-ui/src/tooltip/tooltipview';
 import Template from '@ckeditor/ckeditor5-ui/src/template';
-import { attachLinkToDocumentation } from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
+import { logWarning } from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
 
@@ -53,3 +51,3 @@ const mediaPlaceholderIconViewBox = '0 0 64 42';
 					 */
-					console.warn( attachLinkToDocumentation( 'media-embed-no-provider-name' ), { provider } );
+					logWarning( 'media-embed-no-provider-name', { provider } );
 
@@ -56,0 +54,0 @@ return false;

src/ui/mediaformview.js

@@ -26,2 +26,3 @@ /**
 import '../../theme/mediaform.css';
+import '@ckeditor/ckeditor5-ui/theme/components/responsive-form/responsiveform.css';
 
@@ -62,2 +63,10 @@ /**
 		/**
+		 * The value of the URL input.
+		 *
+		 * @member {String} #mediaURLInputValue
+		 * @observable
+		 */
+		this.set( 'mediaURLInputValue', '' );
+
+		/**
 		 * The URL input view.
@@ -76,2 +85,3 @@ *
 		this.saveButtonView.type = 'submit';
+		this.saveButtonView.bind( 'isEnabled' ).to( this, 'mediaURLInputValue', value => !!value );
 
@@ -129,3 +139,4 @@ /**
 					'ck',
-					'ck-media-form'
+					'ck-media-form',
+					'ck-responsive-form'
 				],
@@ -283,2 +294,3 @@
 			labeledInput.infoText = inputField.element.value ? this._urlInputViewInfoTip : this._urlInputViewInfoDefault;
+			this.mediaURLInputValue = inputField.element.value.trim();
 		} );
@@ -285,0 +297,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

155694

increased by1.51%

Number of package files

63

increased by1.61%

Lines of code

1663

increased by0.54%

Dependency changes

• Updated@ckeditor/ckeditor5-clipboard@^23.1.0

• Updated@ckeditor/ckeditor5-core@^23.1.0

• Updated@ckeditor/ckeditor5-engine@^23.1.0

• Updated@ckeditor/ckeditor5-image@^23.1.0

• Updated@ckeditor/ckeditor5-ui@^23.1.0

• Updated@ckeditor/ckeditor5-undo@^23.1.0

• Updated@ckeditor/ckeditor5-utils@^23.1.0

• Updated@ckeditor/ckeditor5-widget@^23.1.0