@ckeditor/ckeditor5-typing - npm Package Compare versions

Comparing version 11.0.1 to 11.0.2

CHANGELOG.md

 Changelog
 =========
 
+## [11.0.2](https://github.com/ckeditor/ckeditor5-typing/compare/v11.0.1...v11.0.2) (2018-12-05)
+
+### Bug fixes
+
+* Non-printable keys like volume up or the win key will not remove the content anymore. Closes [#136](https://github.com/ckeditor/ckeditor5-typing/issues/136). ([0ea9fbd](https://github.com/ckeditor/ckeditor5-typing/commit/0ea9fbd))
+
+
 ## [11.0.1](https://github.com/ckeditor/ckeditor5-typing/compare/v11.0.0...v11.0.1) (2018-10-08)
@@ -5,0 +12,0 @@

package.json

 {
   "name": "@ckeditor/ckeditor5-typing",
-  "version": "11.0.1",
+  "version": "11.0.2",
   "description": "Typing feature for CKEditor 5.",
@@ -13,18 +13,18 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-core": "^11.0.1",
-    "@ckeditor/ckeditor5-engine": "^11.0.0",
-    "@ckeditor/ckeditor5-utils": "^11.0.0"
+    "@ckeditor/ckeditor5-core": "^11.1.0",
+    "@ckeditor/ckeditor5-engine": "^12.0.0",
+    "@ckeditor/ckeditor5-utils": "^11.1.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^10.0.3",
-    "@ckeditor/ckeditor5-block-quote": "^10.1.0",
-    "@ckeditor/ckeditor5-editor-classic": "^11.0.1",
-    "@ckeditor/ckeditor5-enter": "^10.1.2",
-    "@ckeditor/ckeditor5-essentials": "^10.1.2",
-    "@ckeditor/ckeditor5-heading": "^10.1.0",
-    "@ckeditor/ckeditor5-image": "^11.0.0",
-    "@ckeditor/ckeditor5-link": "^10.0.4",
-    "@ckeditor/ckeditor5-list": "^11.0.2",
-    "@ckeditor/ckeditor5-paragraph": "^10.0.3",
-    "@ckeditor/ckeditor5-undo": "^10.0.3",
+    "@ckeditor/ckeditor5-basic-styles": "^10.1.0",
+    "@ckeditor/ckeditor5-block-quote": "^10.1.1",
+    "@ckeditor/ckeditor5-editor-classic": "^11.0.2",
+    "@ckeditor/ckeditor5-enter": "^10.1.3",
+    "@ckeditor/ckeditor5-essentials": "^10.1.3",
+    "@ckeditor/ckeditor5-heading": "^10.1.1",
+    "@ckeditor/ckeditor5-image": "^12.0.0",
+    "@ckeditor/ckeditor5-link": "^10.1.0",
+    "@ckeditor/ckeditor5-list": "^11.0.3",
+    "@ckeditor/ckeditor5-paragraph": "^10.0.4",
+    "@ckeditor/ckeditor5-undo": "^10.0.4",
     "eslint": "^5.5.0",
@@ -31,0 +31,0 @@ "eslint-config-ckeditor5": "^1.0.7",

src/deletecommand.js

@@ -11,8 +11,6 @@ /**
 import Command from '@ckeditor/ckeditor5-core/src/command';
-import Selection from '@ckeditor/ckeditor5-engine/src/model/selection';
-import Element from '@ckeditor/ckeditor5-engine/src/model/element';
-import Range from '@ckeditor/ckeditor5-engine/src/model/range';
-import ChangeBuffer from './utils/changebuffer';
 import count from '@ckeditor/ckeditor5-utils/src/count';
 
+import ChangeBuffer from './utils/changebuffer';
+
 /**
@@ -71,3 +69,3 @@ * The delete command. Used by the {@link module:typing/delete~Delete delete feature} to handle the <kbd>Delete</kbd> and
 
-			const selection = new Selection( doc.selection );
+			const selection = writer.createSelection( doc.selection );
 
@@ -178,5 +176,5 @@ // Do not replace the whole selected content if selection was collapsed.
 		const limitElement = model.schema.getLimitElement( selection );
-		const paragraph = new Element( 'paragraph' );
+		const paragraph = writer.createElement( 'paragraph' );
 
-		writer.remove( Range.createIn( limitElement ) );
+		writer.remove( writer.createRangeIn( limitElement ) );
 		writer.insert( paragraph, limitElement );
@@ -183,0 +181,0 @@

src/utils/changebuffer.js

@@ -10,4 +10,2 @@ /**
 
-import Batch from '@ckeditor/ckeditor5-engine/src/model/batch';
-
 /**
@@ -123,3 +121,3 @@ * Change buffer allows to group atomic changes (like characters that have been typed) into
 		if ( !this._batch ) {
-			this._batch = new Batch();
+			this._batch = this.model.createBatch();
 		}
@@ -126,0 +124,0 @@

src/utils/injectandroidbackspacemutationshandling.js

@@ -10,3 +10,2 @@ /**
 
-import Selection from '@ckeditor/ckeditor5-engine/src/model/selection';
 import diff from '@ckeditor/ckeditor5-utils/src/diff';
@@ -30,3 +29,3 @@
 	let previousSelection = null;
-	let currentSelection = new Selection( model.document.selection );
+	let currentSelection = model.createSelection( model.document.selection );
 	let latestSelectionChangeMs = Date.now();
@@ -43,3 +42,3 @@
 	function handleSelectionChange( evt ) {
-		const newSelection = new Selection( evt.source );
+		const newSelection = model.createSelection( evt.source );
 		if ( !currentSelection.isEqual( newSelection ) ) {
@@ -46,0 +45,0 @@ previousSelection = currentSelection;

src/utils/injecttypingmutationshandling.js

@@ -10,4 +10,2 @@ /**
 
-import ModelRange from '@ckeditor/ckeditor5-engine/src/model/range';
-import ViewPosition from '@ckeditor/ckeditor5-engine/src/view/position';
 import diff from '@ckeditor/ckeditor5-utils/src/diff';
@@ -171,7 +169,5 @@ import DomConverter from '@ckeditor/ckeditor5-engine/src/view/domconverter';
 		const insertText = newText.substr( firstChangeAt, insertions );
-		const removeRange = ModelRange.createFromParentsAndOffsets(
-			currentModel,
-			firstChangeAt,
-			currentModel,
-			firstChangeAt + deletions
+		const removeRange = this.editor.model.createRange(
+			this.editor.model.createPositionAt( currentModel, firstChangeAt ),
+			this.editor.model.createPositionAt( currentModel, firstChangeAt + deletions )
 		);
@@ -219,5 +215,5 @@
 		// Get the position in view and model where the changes will happen.
-		const viewPos = new ViewPosition( mutation.node, firstChangeAt );
+		const viewPos = this.editing.view.createPositionAt( mutation.node, firstChangeAt );
 		const modelPos = this.editing.mapper.toModelPosition( viewPos );
-		const removeRange = ModelRange.createFromPositionAndShift( modelPos, deletions );
+		const removeRange = this.editor.model.createRange( modelPos, modelPos.getShiftedBy( deletions ) );
 		const insertText = newText.substr( firstChangeAt, insertions );
@@ -241,3 +237,3 @@
 		const change = getSingleTextNodeChange( mutation );
-		const viewPos = new ViewPosition( mutation.node, change.index );
+		const viewPos = this.editing.view.createPositionAt( mutation.node, change.index );
 		const modelPos = this.editing.mapper.toModelPosition( viewPos );
@@ -252,3 +248,3 @@ const insertedText = change.values[ 0 ].data;
 			text: insertedText.replace( /\u00A0/g, ' ' ),
-			range: new ModelRange( modelPos )
+			range: this.editor.model.createRange( modelPos )
 		} );
@@ -255,0 +251,0 @@ }

src/utils/injectunsafekeystrokeshandling.js

@@ -10,4 +10,2 @@ /**
 
-import Selection from '@ckeditor/ckeditor5-engine/src/model/selection';
-
 import { getCode } from '@ckeditor/ckeditor5-utils/src/keyboard';
@@ -33,3 +31,3 @@
 	view.document.on( 'compositionend', () => {
-		latestCompositionSelection = new Selection( model.document.selection );
+		latestCompositionSelection = model.createSelection( model.document.selection );
 	}, { priority: 'lowest' } );
@@ -128,2 +126,3 @@
 	18, // Alt
+	19, // Pause
 	20, // CapsLock
@@ -134,3 +133,16 @@ 27, // Escape
 	35, // Home
-	36 // End
+	36, // End,
+	45, // Insert,
+	91, // Windows,
+	93, // Menu key,
+	144, // NumLock
+	145, // ScrollLock,
+	173, // Mute/Unmute
+	174, // Volume up
+	175, // Volume down,
+	176, // Next song,
+	177, // Previous song,
+	178, // Stop,
+	179, // Play/Pause,
+	255 // Display brightness (increase and decrease)
 ];
@@ -137,0 +149,0 @@

src/utils/utils.js

@@ -10,3 +10,2 @@ /**
 
-import ViewText from '@ckeditor/ckeditor5-engine/src/view/text';
 import diff from '@ckeditor/ckeditor5-utils/src/diff';
@@ -65,3 +64,3 @@ import diffToChanges from '@ckeditor/ckeditor5-utils/src/difftochanges';
 	// Which is text.
-	if ( !( change.values[ 0 ] instanceof ViewText ) ) {
+	if ( !( !!change.values[ 0 ] && change.values[ 0 ].is( 'text' ) ) ) {
 		return;
@@ -83,3 +82,3 @@ }
 export function compareChildNodes( oldChild, newChild ) {
-	if ( oldChild instanceof ViewText && newChild instanceof ViewText ) {
+	if ( !!oldChild && oldChild.is( 'text' ) && !!newChild && newChild.is( 'text' ) ) {
 		return oldChild.data === newChild.data;
@@ -86,0 +85,0 @@ } else {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60984

increased by0.41%

Lines of code

1223

increased by0.25%

Dependency changes

• - Removed@ckeditor/ckeditor5-engine@11.0.0(transitive)

• Updated@ckeditor/ckeditor5-core@^11.1.0

• Updated@ckeditor/ckeditor5-engine@^12.0.0

• Updated@ckeditor/ckeditor5-utils@^11.1.0