@ckeditor/ckeditor5-widget - npm Package Compare versions

Comparing version 11.0.4 to 11.1.0

CHANGELOG.md

 Changelog
 =========
 
+## [11.1.0](https://github.com/ckeditor/ckeditor5-widget/compare/v11.0.4...v11.1.0) (2019-08-26)
+
+### Features
+
+* Introduced image widget resizer. See [ckeditor/ckeditor5-image#241](https://github.com/ckeditor/ckeditor5-image/issues/241). ([c84cd73](https://github.com/ckeditor/ckeditor5-widget/commit/c84cd73))
+
+### Bug fixes
+
+* Improved balloon positioning when there is more than one stack in the rotator. ([763c9ba](https://github.com/ckeditor/ckeditor5-widget/commit/763c9ba))
+* Reposition visible toolbar when it is in a not visible stack of rotator. Closes [ckeditor/ckeditor5#1957](https://github.com/ckeditor/ckeditor5/issues/1957). ([a438c8b](https://github.com/ckeditor/ckeditor5-widget/commit/a438c8b))
+
+### Other changes
+
+* The issue tracker for this package was moved to https://github.com/ckeditor/ckeditor5/issues. See [ckeditor/ckeditor5#1988](https://github.com/ckeditor/ckeditor5/issues/1988). ([cfd41c1](https://github.com/ckeditor/ckeditor5-widget/commit/cfd41c1))
+* The widget toolbar should have a proper `aria-label` attribute (see [ckeditor/ckeditor5#1404](https://github.com/ckeditor/ckeditor5/issues/1404)). ([aec5888](https://github.com/ckeditor/ckeditor5-widget/commit/aec5888))
+
+
 ## [11.0.4](https://github.com/ckeditor/ckeditor5-widget/compare/v11.0.3...v11.0.4) (2019-07-10)
@@ -5,0 +22,0 @@

package.json

 {
   "name": "@ckeditor/ckeditor5-widget",
-  "version": "11.0.4",
+  "version": "11.1.0",
   "description": "Widget API for CKEditor 5.",
@@ -12,19 +12,21 @@ "keywords": [
   "dependencies": {
-    "@ckeditor/ckeditor5-core": "^12.2.1",
-    "@ckeditor/ckeditor5-engine": "^13.2.1",
-    "@ckeditor/ckeditor5-ui": "^13.0.2",
-    "@ckeditor/ckeditor5-utils": "^13.0.1"
+    "@ckeditor/ckeditor5-core": "^12.3.0",
+    "@ckeditor/ckeditor5-engine": "^14.0.0",
+    "@ckeditor/ckeditor5-ui": "^14.0.0",
+    "@ckeditor/ckeditor5-utils": "^14.0.0",
+    "lodash-es": "^4.17.10"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^11.1.3",
-    "@ckeditor/ckeditor5-clipboard": "^12.0.1",
-    "@ckeditor/ckeditor5-editor-balloon": "^12.2.1",
-    "@ckeditor/ckeditor5-editor-classic": "^12.1.3",
-    "@ckeditor/ckeditor5-enter": "^11.0.4",
-    "@ckeditor/ckeditor5-essentials": "^11.0.4",
-    "@ckeditor/ckeditor5-heading": "^11.0.4",
-    "@ckeditor/ckeditor5-paragraph": "^11.0.4",
-    "@ckeditor/ckeditor5-table": "^13.0.2",
-    "@ckeditor/ckeditor5-typing": "^12.1.1",
-    "@ckeditor/ckeditor5-undo": "^11.0.4",
+    "@ckeditor/ckeditor5-basic-styles": "^11.1.4",
+    "@ckeditor/ckeditor5-block-quote": "^11.1.3",
+    "@ckeditor/ckeditor5-clipboard": "^12.0.2",
+    "@ckeditor/ckeditor5-editor-balloon": "^12.2.2",
+    "@ckeditor/ckeditor5-editor-classic": "^12.1.4",
+    "@ckeditor/ckeditor5-enter": "^11.1.0",
+    "@ckeditor/ckeditor5-essentials": "^11.0.5",
+    "@ckeditor/ckeditor5-heading": "^11.0.5",
+    "@ckeditor/ckeditor5-paragraph": "^11.0.5",
+    "@ckeditor/ckeditor5-table": "^14.0.0",
+    "@ckeditor/ckeditor5-typing": "^12.2.0",
+    "@ckeditor/ckeditor5-undo": "^11.0.5",
     "eslint": "^5.5.0",
@@ -42,3 +44,3 @@ "eslint-config-ckeditor5": "^2.0.0",
   "homepage": "https://ckeditor.com/ckeditor-5",
-  "bugs": "https://github.com/ckeditor/ckeditor5-widget/issues",
+  "bugs": "https://github.com/ckeditor/ckeditor5/issues",
   "repository": {
@@ -45,0 +47,0 @@ "type": "git",

src/widget.js

@@ -33,3 +33,3 @@ /**
  *
- * @extends module:core/plugin~Plugin.
+ * @extends module:core/plugin~Plugin
  */
@@ -36,0 +36,0 @@ export default class Widget extends Plugin {

src/widgettoolbarrepository.js

@@ -114,2 +114,3 @@ /**
 	 * @param {Object} options
+	 * @param {String} [options.ariaLabel] Label used by assistive technologies to describe this toolbar element.
 	 * @param {Array.<String>} options.items Array of toolbar items.
@@ -119,6 +120,9 @@ * @param {Function} options.getRelatedElement Callback which returns an element the toolbar should be attached to.
 	 */
-	register( toolbarId, { items, getRelatedElement, balloonClassName = 'ck-toolbar-container' } ) {
+	register( toolbarId, { ariaLabel, items, getRelatedElement, balloonClassName = 'ck-toolbar-container' } ) {
 		const editor = this.editor;
-		const toolbarView = new ToolbarView();
+		const t = editor.t;
+		const toolbarView = new ToolbarView( editor.locale );
 
+		toolbarView.ariaLabel = ariaLabel || t( 'Widget toolbar' );
+
 		if ( this._toolbarDefinitions.has( toolbarId ) ) {
@@ -192,2 +196,3 @@ /**
 		this._balloon.remove( toolbarDefinition.view );
+		this.stopListening( this._balloon, 'change:visibleView' );
 	}
@@ -215,2 +220,15 @@
 			} );
+
+			// Update toolbar position each time stack with toolbar view is switched to visible.
+			// This is in a case target element has changed when toolbar was in invisible stack
+			// e.g. target image was wrapped by a block quote.
+			// See https://github.com/ckeditor/ckeditor5-widget/issues/92.
+			this.listenTo( this._balloon, 'change:visibleView', () => {
+				for ( const definition of this._toolbarDefinitions.values() ) {
+					if ( this._isToolbarVisible( definition ) ) {
+						const relatedElement = definition.getRelatedElement( this.editor.editing.view.document.selection );
+						repositionContextualBalloon( this.editor, relatedElement );
+					}
+				}
+			} );
 		}
@@ -217,0 +235,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

95108

increased by56.17%

Number of package files

15

increased by50%

Lines of code

1980

increased by71.13%

Worsened metrics

Dependency count

5

increased by25%

Dev dependency count

16

increased by6.67%

Dependency changes

• + Addedlodash-es@^4.17.10

• + Added@ckeditor/ckeditor5-ui@14.0.0(transitive)

• - Removed@ckeditor/ckeditor5-engine@13.2.1(transitive)

• - Removed@ckeditor/ckeditor5-ui@13.0.2(transitive)

• - Removed@ckeditor/ckeditor5-utils@13.0.1(transitive)

• Updated@ckeditor/ckeditor5-core@^12.3.0

• Updated@ckeditor/ckeditor5-engine@^14.0.0

• Updated@ckeditor/ckeditor5-ui@^14.0.0

• Updated@ckeditor/ckeditor5-utils@^14.0.0