@collaborne/custom-cloudformation-resources - npm Package Compare versions

Comparing version 0.5.13 to 0.5.15

dist/cloudfront-waf-v2-rule-group/index.d.ts

@@ -0,1 +1,2 @@
+import { WAFV2 } from 'aws-sdk';
 import { SchemaType } from '@collaborne/json-schema-to-type';
@@ -32,5 +33,6 @@ import { CustomResource, Response } from '../custom-resource';
     deleteResource(physicalResourceId: string, { Name: name }: SchemaType<typeof SCHEMA>): Promise<Response<ResourceAttributes>>;
-    updateResource(physicalResourceId: string, { Name: name }: SchemaType<typeof SCHEMA>): Promise<Response<ResourceAttributes>>;
+    updateResource(physicalResourceId: string, { Name, Description, Rules }: SchemaType<typeof SCHEMA>): Promise<Response<ResourceAttributes>>;
+    protected getRuleGroup(name: string): Promise<WAFV2.GetRuleGroupResponse>;
     protected getRuleGroupAttributes(name: string): Promise<ResourceAttributes>;
 }
 export {};

dist/cloudfront-waf-v2-rule-group/index.js

@@ -77,3 +77,3 @@ "use strict";
             Id: attributes.Id,
-            LockToken: `${name}-delete-token`,
+            LockToken: 'delete',
         })
@@ -85,11 +85,29 @@ .promise();
     }
-    async updateResource(physicalResourceId, { Name: name }) {
-        const attributes = await this.getRuleGroupAttributes(name);
+    async updateResource(physicalResourceId, { Name, Description, Rules }) {
+        var _a, _b, _c;
+        const ruleGroup = await this.getRuleGroup(Name);
+        if (!ruleGroup.RuleGroup) {
+            throw new Error(`Rule group cannot find ${Name}`);
+        }
+        const rules = JSON.parse(Rules);
+        await this.wafV2
+            .updateRuleGroup({
+            Id: (_a = ruleGroup.RuleGroup) === null || _a === void 0 ? void 0 : _a.Id,
+            Name,
+            Description,
+            Scope: SCOPE,
+            Rules: rules,
+            VisibilityConfig: ruleGroup.RuleGroup.VisibilityConfig,
+            LockToken: 'update',
+        })
+            .promise();
         return {
             physicalResourceId,
-            attributes,
+            attributes: {
+                Arn: (_b = ruleGroup.RuleGroup) === null || _b === void 0 ? void 0 : _b.ARN,
+                Id: (_c = ruleGroup.RuleGroup) === null || _c === void 0 ? void 0 : _c.Id,
+            },
         };
     }
-    async getRuleGroupAttributes(name) {
-        var _a, _b, _c;
+    async getRuleGroup(name) {
         const ruleGroup = await this.wafV2.getRuleGroup({ Name: name }).promise();
@@ -99,2 +117,7 @@ if (!ruleGroup) {
         }
+        return ruleGroup;
+    }
+    async getRuleGroupAttributes(name) {
+        var _a, _b, _c;
+        const ruleGroup = await this.getRuleGroup(name);
         if (!((_a = ruleGroup.RuleGroup) === null || _a === void 0 ? void 0 : _a.ARN) || !ruleGroup.RuleGroup.Id) {
@@ -101,0 +124,0 @@ throw new Error(`Missing properties for rule group ${name}`);

package.json

 {
   "name": "@collaborne/custom-cloudformation-resources",
-  "version": "0.5.13",
+  "version": "0.5.15",
   "description": "Custom CloudFormation resources",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/cloudfront-waf-v2-rule-group/index.ts

@@ -102,3 +102,3 @@ import { WAFV2 } from 'aws-sdk';
 				Id: attributes.Id,
-				LockToken: `${name}-delete-token`,
+				LockToken: 'delete',
 			})
@@ -114,15 +114,36 @@ .promise();
 		physicalResourceId: string,
-		{ Name: name }: SchemaType<typeof SCHEMA>,
+		{ Name, Description, Rules }: SchemaType<typeof SCHEMA>,
 	): Promise<Response<ResourceAttributes>> {
-		const attributes = await this.getRuleGroupAttributes(name);
+		const ruleGroup = await this.getRuleGroup(Name);
 
+		if (!ruleGroup.RuleGroup) {
+			throw new Error(`Rule group cannot find ${Name}`);
+		}
+
+		const rules: Rules = JSON.parse(Rules);
+
+		await this.wafV2
+			.updateRuleGroup({
+				Id: ruleGroup.RuleGroup?.Id,
+				Name,
+				Description,
+				Scope: SCOPE,
+				Rules: rules,
+				VisibilityConfig: ruleGroup.RuleGroup.VisibilityConfig,
+				LockToken: 'update',
+			})
+			.promise();
+
 		return {
 			physicalResourceId,
-			attributes,
+			attributes: {
+				Arn: ruleGroup.RuleGroup?.ARN,
+				Id: ruleGroup.RuleGroup?.Id,
+			},
 		};
 	}
 
-	protected async getRuleGroupAttributes(
+	protected async getRuleGroup(
 		name: string,
-	): Promise<ResourceAttributes> {
+	): Promise<WAFV2.GetRuleGroupResponse> {
 		const ruleGroup = await this.wafV2.getRuleGroup({ Name: name }).promise();
@@ -133,2 +154,10 @@ if (!ruleGroup) {
 
+		return ruleGroup;
+	}
+
+	protected async getRuleGroupAttributes(
+		name: string,
+	): Promise<ResourceAttributes> {
+		const ruleGroup = await this.getRuleGroup(name);
+
 		if (!ruleGroup.RuleGroup?.ARN || !ruleGroup.RuleGroup.Id) {
@@ -135,0 +164,0 @@ throw new Error(`Missing properties for rule group ${name}`);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

196768

increased by1.15%

Lines of code

2664

increased by1.87%

No dependency changes