@connectedcars/jwtutils - npm Package Compare versions

Comparing version 1.0.9 to 1.0.10

bin/jwtdecode.test.js

@@ -48,3 +48,3 @@ 'use strict'
     })
-    jwtEncode.stderr.on('data', () => {
+    jwtEncode.stderr.on('end', () => {
       stderrStr = Buffer.concat(errorData).toString('utf8')
@@ -51,0 +51,0 @@ })

package.json

 {
   "name": "@connectedcars/jwtutils",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "Zero dependency JWT encoding/decoding for Node",
@@ -28,2 +28,4 @@ "main": "src/index.js",
   "devDependencies": {
+    "@types/mocha": "^2.2.45",
+    "@types/node": "^8.5.2",
     "babel-eslint": "^7.2.3",
@@ -30,0 +32,0 @@ "benchmark": "^2.1.4",

README.md

@@ -135,3 +135,3 @@ # node-jwtutils
 // Register the middleware
-app.use(JwtAuthMiddleware(pubKeys, audiences, user => {
+app.use(JwtAuthMiddleware(pubKeys, audiences, user => { // Also supports Promises and async
   if (user.issuer === 'https://jwt.io/') {
@@ -138,0 +138,0 @@ if (!user.subject.match(/^[^@]+@domain\.tld$/)) {

src/base64urlsafe.js

@@ -0,1 +1,4 @@
+// @ts-check
+'use strict'
+
 function base64EncodeUrlSafe(buffer) {
@@ -2,0 +5,0 @@ return buffer

src/index.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

src/index.test.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -356,3 +357,3 @@
       let customJwtHeader = Object.assign({}, jwtHeader)
-      customJwtHeader.kid = 2
+      customJwtHeader.kid = '2'
       let jwt = JwtUtils.encode(rsaPrivateKey, customJwtHeader, jwtBody)
@@ -359,0 +360,0 @@ try {

src/jwtauthmiddleware.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -20,2 +21,3 @@
       }
+
       request.user = {
@@ -28,7 +30,13 @@ audience: decodedJwtBody.aud,
       }
+
+      // Handle async
+      let result
       if (typeof mapper === 'function') {
-        mapper(request.user)
+        result = mapper(request.user, request, response)
       }
-
-      return next()
+      if (isPromise(result)) {
+        result.then(() => next()).catch(e => next(e))
+      } else {
+        return next()
+      }
     } catch (e) {
@@ -44,2 +52,10 @@ if (e instanceof JwtVerifyError) {
 
+function isPromise(value) {
+  return (
+    typeof value === 'object' &&
+    value !== null &&
+    typeof value.then === 'function'
+  )
+}
+
 module.exports = jwtAuthMiddleware

src/jwtauthmiddleware.test.js

@@ -0,1 +1,4 @@
+// @ts-check
+'use strict'
+
 const express = require('express')
@@ -68,2 +71,12 @@ const app = express()
       )
+      app.use(
+        '/async',
+        JwtAuthMiddleware(pubKeys, audiences, user => {
+          if (user.subject === 'error') {
+            return Promise.reject(new JwtVerifyError('Async error'))
+          } else {
+            return Promise.resolve('test')
+          }
+        })
+      )
       app.use('/', JwtAuthMiddleware(pubKeys, audiences))
@@ -83,2 +96,5 @@ app.use((err, req, res, next) => {
       })
+      app.get('/async', function(req, res) {
+        res.send(`Async response`)
+      })
 
@@ -164,2 +180,29 @@ done()
     })
+    it('should fail with async error', () => {
+      let customJwtBody = Object.assign({}, jwtBody)
+      customJwtBody.sub = 'error'
+      let jwt = JwtUtils.encode(ecPrivateKey, jwtHeader, customJwtBody)
+      let responsePromise = doRequest('GET', 'localhost', port, '/async', {
+        Authorization: 'Bearer ' + jwt,
+        Accept: 'application/json',
+        'User-Agent': 'test',
+        'X-Error': 'Async error'
+      })
+      return expect(responsePromise, 'to be fulfilled with value satisfying', {
+        statusCode: 401,
+        data: 'Async error'
+      })
+    })
+    it('should success with async', () => {
+      let jwt = JwtUtils.encode(ecPrivateKey, jwtHeader, jwtBody)
+      let responsePromise = doRequest('GET', 'localhost', port, '/async', {
+        Authorization: 'Bearer ' + jwt,
+        Accept: 'application/json',
+        'User-Agent': 'test'
+      })
+      return expect(responsePromise, 'to be fulfilled with value satisfying', {
+        statusCode: 200,
+        data: 'Async response'
+      })
+    })
   })
@@ -166,0 +209,0 @@ })

src/jwtdecode.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

src/jwtdecode.test.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

src/jwtencode.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

src/jwtencode.test.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

src/jwtverifyerror.js

@@ -0,1 +1,2 @@
+// @ts-check
 'use strict'
@@ -2,0 +3,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 7 instances in 1 package

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 2 instances in 1 package

Debug access

Supply chain risk

Uses debug, reflection and dynamic code execution features.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 10 instances in 1 package

High entropy strings

Supply chain risk

Contains high entropy strings. This could be a sign of encrypted data, leaked secrets or obfuscated code.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Minified code

Quality

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Non-permissive License

License

(Experimental) A license not known to be considered permissive was found.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5959492

increased by9430.61%

Number of package files

870

increased by2800%

Lines of code

85996

increased by5956.06%

Worsened metrics

Dev dependency count

14

increased by16.67%

Number of low license alerts

2

increased byInfinity%

License quality

90

decreased by-10%

Number of low quality alerts

5

increased byInfinity%

Number of low supply chain risk alerts

88

increased by2100%

Number of medium supply chain risk alerts

47

increased by1466.67%

No dependency changes