@crystallize/content-chunk - npm Package Compare versions

Comparing version 0.5.4 to 0.5.5

CHANGELOG.md

@@ -0,1 +1,8 @@
+<a name="0.5.5"></a>
+## <small>0.5.5 (2018-05-30)</small>
+
+* Small tweak to not allow empty inline elements as children of certain elements ([2eae4ca](https://github.com/snowballdigital/crystallize-content-chunk/commit/2eae4ca))
+
+
+
 <a name="0.5.4"></a>
@@ -2,0 +9,0 @@ ## <small>0.5.4 (2018-05-30)</small>

develop.js

 const { fromHTML } = require('./src');
 
-console.log(
-  fromHTML(`
-<p>sasd</p>
-<p>asd</p>@
-`)
-);
+console.log(fromHTML(`<p>hello <i>you</i> <i>dude</i></p>`));

package.json

 {
   "name": "@crystallize/content-chunk",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "Validation and parsing for CCC",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/converters/html/fromHTML.js

@@ -56,2 +56,19 @@ const parse5 = require('parse5');
 
+const nodeTypesThatCannotHaveDirectTextChildren = 'ul ol table thead tbody tfoot tr th td img'.split(
+  ' '
+);
+
+function nodeHasContent(node) {
+  if (node.nodeName === '#text') {
+    if (
+      nodeTypesThatCannotHaveDirectTextChildren.includes(
+        node.parentNode.nodeName
+      )
+    ) {
+      return false;
+    }
+  }
+  return true;
+}
+
 function chunkHasContent(chunk) {
@@ -94,2 +111,3 @@ // Empty, inline chunks
     chunk.children = Array.from(node.childNodes)
+      .filter(nodeHasContent)
       .map(parseChunk)
@@ -96,0 +114,0 @@ .filter(chunkHasContent);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

706728

increased by0.14%

Lines of code

2591

increased by0.47%

No dependency changes