@cucumber/cucumber - npm Package Compare versions

Comparing version 8.11.0 to 8.11.1

lib/formatter/html_formatter.d.ts

 import Formatter, { IFormatterOptions } from '.';
 export default class HtmlFormatter extends Formatter {
-    private readonly _finished;
+    private readonly _htmlStream;
     static readonly documentation: string;
@@ -5,0 +5,0 @@ constructor(options: IFormatterOptions);

lib/formatter/html_formatter.js

@@ -9,3 +9,2 @@ "use strict";
 const html_formatter_1 = __importDefault(require("@cucumber/html-formatter"));
-const value_checker_1 = require("../value_checker");
 const stream_1 = require("stream");
@@ -16,16 +15,13 @@ const util_1 = require("util");
         super(options);
-        const cucumberHtmlStream = new html_formatter_1.default((0, resolve_pkg_1.default)('@cucumber/html-formatter', { cwd: __dirname }) +
+        this._htmlStream = new html_formatter_1.default((0, resolve_pkg_1.default)('@cucumber/html-formatter', { cwd: __dirname }) +
             '/dist/main.css', (0, resolve_pkg_1.default)('@cucumber/html-formatter', { cwd: __dirname }) +
             '/dist/main.js');
         options.eventBroadcaster.on('envelope', (envelope) => {
-            cucumberHtmlStream.write(envelope);
-            if ((0, value_checker_1.doesHaveValue)(envelope.testRunFinished)) {
-                cucumberHtmlStream.end();
-            }
+            this._htmlStream.write(envelope);
         });
-        cucumberHtmlStream.on('data', (chunk) => this.log(chunk));
-        this._finished = (0, util_1.promisify)(stream_1.finished)(cucumberHtmlStream);
+        this._htmlStream.on('data', (chunk) => this.log(chunk));
     }
     async finished() {
-        await this._finished;
+        this._htmlStream.end();
+        await (0, util_1.promisify)(stream_1.finished)(this._htmlStream);
         await super.finished();
@@ -32,0 +28,0 @@ }

lib/formatter/json_formatter.js

@@ -147,3 +147,3 @@ "use strict";
             keyword: gherkinScenarioMap[pickle.astNodeIds[0]].keyword,
-            line: gherkinScenarioLocationMap[pickle.astNodeIds[0]].line,
+            line: gherkinScenarioLocationMap[pickle.astNodeIds[pickle.astNodeIds.length - 1]].line,
             name: pickle.name,
@@ -150,0 +150,0 @@ steps,

lib/runtime/attachment_manager/index.d.ts

@@ -14,4 +14,8 @@ /// <reference types="node" />
 export type IAttachFunction = (attachment: IAttachment) => void;
-export type ICreateAttachment = (data: Buffer | Readable | string, mediaType?: string, callback?: () => void) => void | Promise<void>;
-export type ICreateLog = (text: string) => void | Promise<void>;
+export type ICreateStringAttachment = (data: string, mediaType?: string) => void;
+export type ICreateBufferAttachment = (data: Buffer, mediaType: string) => void;
+export type ICreateStreamAttachment = (data: Readable, mediaType: string) => Promise<void>;
+export type ICreateStreamAttachmentWithCallback = (data: Readable, mediaType: string, callback: () => void) => void;
+export type ICreateAttachment = ICreateStringAttachment & ICreateBufferAttachment & ICreateStreamAttachment & ICreateStreamAttachmentWithCallback;
+export type ICreateLog = (text: string) => void;
 export default class AttachmentManager {
@@ -18,0 +22,0 @@ private readonly onAttachment;

lib/version.d.ts

@@ -1,1 +0,1 @@
-export declare const version = "8.11.0";
+export declare const version = "8.11.1";

lib/version.js

@@ -5,3 +5,3 @@ "use strict";
 // Generated by genversion.
-exports.version = '8.11.0';
+exports.version = '8.11.1';
 //# sourceMappingURL=version.js.map

package.json

@@ -11,3 +11,3 @@ {
   ],
-  "version": "8.11.0",
+  "version": "8.11.1",
   "homepage": "https://github.com/cucumber/cucumber-js",
@@ -14,0 +14,0 @@ "author": "Julien Biezemans <[e-mail]>",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

797513

increased by0.05%

No dependency changes