@datadog/browser-rum-core - npm Package Compare versions

Comparing version 2.4.0 to 2.5.0

cjs/boot/buildEnv.js

@@ -6,4 +6,4 @@ "use strict";
     datacenter: 'us',
-    sdkVersion: '2.4.0',
+    sdkVersion: '2.5.0',
 };
 //# sourceMappingURL=buildEnv.js.map

cjs/domain/rumEventsCollection/view/trackViews.js

@@ -154,3 +154,3 @@ "use strict";
         addTiming: function (name, time) {
-            customTimings[name] = time - startTime;
+            customTimings[sanitizeTiming(name)] = time - startTime;
         },
@@ -252,2 +252,12 @@ updateLocation: function (newLocation) {
 }
+/**
+ * Timing name is used as facet path that must contain only letters, digits, or the characters - _ . @ $
+ */
+function sanitizeTiming(name) {
+    var sanitized = name.replace(/[^a-zA-Z0-9-_.@$]/g, '_');
+    if (sanitized !== name) {
+        console.warn("Invalid timing name: " + name + ", sanitized to: " + sanitized);
+    }
+    return sanitized;
+}
 //# sourceMappingURL=trackViews.js.map

esm/boot/buildEnv.js

 export var buildEnv = {
     buildMode: 'release',
     datacenter: 'us',
-    sdkVersion: '2.4.0',
+    sdkVersion: '2.5.0',
 };
 //# sourceMappingURL=buildEnv.js.map

esm/domain/rumEventsCollection/view/trackViews.js

@@ -151,3 +151,3 @@ import { __assign } from "tslib";
         addTiming: function (name, time) {
-            customTimings[name] = time - startTime;
+            customTimings[sanitizeTiming(name)] = time - startTime;
         },
@@ -249,2 +249,12 @@ updateLocation: function (newLocation) {
 }
+/**
+ * Timing name is used as facet path that must contain only letters, digits, or the characters - _ . @ $
+ */
+function sanitizeTiming(name) {
+    var sanitized = name.replace(/[^a-zA-Z0-9-_.@$]/g, '_');
+    if (sanitized !== name) {
+        console.warn("Invalid timing name: " + name + ", sanitized to: " + sanitized);
+    }
+    return sanitized;
+}
 //# sourceMappingURL=trackViews.js.map

package.json

 {
   "name": "@datadog/browser-rum-core",
-  "version": "2.4.0",
+  "version": "2.5.0",
   "license": "Apache-2.0",
@@ -15,3 +15,3 @@ "main": "cjs/index.js",
   "dependencies": {
-    "@datadog/browser-core": "2.4.0",
+    "@datadog/browser-core": "2.5.0",
     "tslib": "^1.10.0"
@@ -27,3 +27,3 @@ },
   },
-  "gitHead": "844d5bf3ed057c99bc381903430226ed4ddb7ac5"
+  "gitHead": "e137aec8b37a9a855f4930bd6305c389828f0da9"
 }

src/domain/rumEventsCollection/view/trackViews.spec.ts

@@ -914,2 +914,14 @@ import { createRawRumEvent } from '../../../../test/fixtures'
   })
+
+  it('should sanitized timing name', () => {
+    setupBuilder.build()
+    const warnSpy = spyOn(console, 'warn')
+
+    addTiming('foo bar-qux.@zip_21%$*€👋', 1234)
+
+    expect(getViewEvent(1).customTimings).toEqual({
+      'foo_bar-qux.@zip_21_$____': 1234,
+    })
+    expect(warnSpy).toHaveBeenCalled()
+  })
 })

src/domain/rumEventsCollection/view/trackViews.ts

@@ -208,3 +208,3 @@ import { addEventListener, DOM_EVENT, generateUUID, monitor, noop, ONE_MINUTE, throttle } from '@datadog/browser-core'
     addTiming(name: string, time: number) {
-      customTimings[name] = time - startTime
+      customTimings[sanitizeTiming(name)] = time - startTime
     },
@@ -316,1 +316,12 @@ updateLocation(newLocation: Location) {
 }
+
+/**
+ * Timing name is used as facet path that must contain only letters, digits, or the characters - _ . @ $
+ */
+function sanitizeTiming(name: string) {
+  const sanitized = name.replace(/[^a-zA-Z0-9-_.@$]/g, '_')
+  if (sanitized !== name) {
+    console.warn(`Invalid timing name: ${name}, sanitized to: ${sanitized}`)
+  }
+  return sanitized
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

736235

increased by0.26%

Lines of code

15559

increased by0.25%

Worsened metrics

Published versions last months

3

decreased by-40%

Published versions last two months

5

decreased by-16.67%

Dependency changes

• + Added@datadog/browser-core@2.5.0(transitive)

• - Removed@datadog/browser-core@2.4.0(transitive)

• Updated@datadog/browser-core@2.5.0