@datadog/browser-rum-core - npm Package Compare versions

Comparing version 3.6.8 to 3.6.10

cjs/boot/buildEnv.js

@@ -6,4 +6,4 @@ "use strict";
     buildMode: 'release',
-    sdkVersion: '3.6.8',
+    sdkVersion: '3.6.10',
 };
 //# sourceMappingURL=buildEnv.js.map

cjs/domain/rumEventsCollection/action/getActionNameFromElement.js

@@ -171,18 +171,20 @@ "use strict";
 /**
- * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element.  This
- * should be the case everywhere except on some version of Internet Explorer.
- * See http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element. This
+ * should be the case everywhere except on Internet Explorer 10 and 11 (see [1])
+ *
+ * The innerText property relies on what is actually rendered to compute its output, so to check if
+ * it actually excludes SCRIPT and STYLE content, a solution would be to create a style element, set
+ * its content to '*', inject it in the document body, and check if the style element innerText
+ * property returns '*'. Using a new `document` instance won't work as it is not rendered.
+ *
+ * This solution requires specific CSP rules (see [2]) to be set by the customer. We want to avoid
+ * this, so instead we rely on browser detection. In case of false negative, the impact should be
+ * low, since we rely on this result to remove the SCRIPT and STYLE innerText (which will be empty)
+ * from a parent element innerText.
+ *
+ * [1]: https://web.archive.org/web/20210602165716/http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * [2]: https://github.com/DataDog/browser-sdk/issues/1084
  */
-var supportsInnerTextScriptAndStyleRemovalResult;
 function supportsInnerTextScriptAndStyleRemoval() {
-    if (supportsInnerTextScriptAndStyleRemovalResult === undefined) {
-        var style = document.createElement('style');
-        style.textContent = '*';
-        var div = document.createElement('div');
-        div.appendChild(style);
-        document.body.appendChild(div);
-        supportsInnerTextScriptAndStyleRemovalResult = div.innerText === '';
-        document.body.removeChild(div);
-    }
-    return supportsInnerTextScriptAndStyleRemovalResult;
+    return !browser_core_1.isIE();
 }
@@ -189,0 +191,0 @@ /**

esm/boot/buildEnv.js

 export var buildEnv = {
     buildMode: 'release',
-    sdkVersion: '3.6.8',
+    sdkVersion: '3.6.10',
 };
 //# sourceMappingURL=buildEnv.js.map

esm/domain/rumEventsCollection/action/getActionNameFromElement.js

@@ -1,2 +0,2 @@
-import { safeTruncate } from '@datadog/browser-core';
+import { safeTruncate, isIE } from '@datadog/browser-core';
 /**
@@ -167,18 +167,20 @@ * Get the action name from the attribute 'data-dd-action-name' on the element or any of its parent.
 /**
- * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element.  This
- * should be the case everywhere except on some version of Internet Explorer.
- * See http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element. This
+ * should be the case everywhere except on Internet Explorer 10 and 11 (see [1])
+ *
+ * The innerText property relies on what is actually rendered to compute its output, so to check if
+ * it actually excludes SCRIPT and STYLE content, a solution would be to create a style element, set
+ * its content to '*', inject it in the document body, and check if the style element innerText
+ * property returns '*'. Using a new `document` instance won't work as it is not rendered.
+ *
+ * This solution requires specific CSP rules (see [2]) to be set by the customer. We want to avoid
+ * this, so instead we rely on browser detection. In case of false negative, the impact should be
+ * low, since we rely on this result to remove the SCRIPT and STYLE innerText (which will be empty)
+ * from a parent element innerText.
+ *
+ * [1]: https://web.archive.org/web/20210602165716/http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * [2]: https://github.com/DataDog/browser-sdk/issues/1084
  */
-var supportsInnerTextScriptAndStyleRemovalResult;
 function supportsInnerTextScriptAndStyleRemoval() {
-    if (supportsInnerTextScriptAndStyleRemovalResult === undefined) {
-        var style = document.createElement('style');
-        style.textContent = '*';
-        var div = document.createElement('div');
-        div.appendChild(style);
-        document.body.appendChild(div);
-        supportsInnerTextScriptAndStyleRemovalResult = div.innerText === '';
-        document.body.removeChild(div);
-    }
-    return supportsInnerTextScriptAndStyleRemovalResult;
+    return !isIE();
 }
@@ -185,0 +187,0 @@ /**

package.json

 {
   "name": "@datadog/browser-rum-core",
-  "version": "3.6.8",
+  "version": "3.6.10",
   "license": "Apache-2.0",
@@ -15,3 +15,3 @@ "main": "cjs/index.js",
   "dependencies": {
-    "@datadog/browser-core": "3.6.8",
+    "@datadog/browser-core": "3.6.10",
     "tslib": "^1.10.0"
@@ -27,3 +27,3 @@ },
   },
-  "gitHead": "af55827d054171d9c150905b39ffe629c0cc8f17"
+  "gitHead": "00bea02238105cd857ba79922976e57190f54e53"
 }

src/boot/startRum.spec.ts

@@ -1,4 +0,3 @@
-import { RelativeTime, Configuration, Observable, noop, relativeNow } from '@datadog/browser-core'
+import { RelativeTime, Configuration, Observable, noop, relativeNow, isIE } from '@datadog/browser-core'
 import { createRumSessionMock, RumSessionMock } from '../../test/mockRumSession'
-import { isIE } from '../../../core/test/specHelper'
 import { noopRecorderApi, setup, TestSetupBuilder } from '../../test/specHelper'
@@ -5,0 +4,0 @@ import { RumPerformanceNavigationTiming, RumPerformanceEntry } from '../browser/performanceCollection'

src/browser/domMutationObservable.spec.ts

@@ -1,2 +0,2 @@
-import { isIE } from '@datadog/browser-core/test/specHelper'
+import { isIE } from '@datadog/browser-core'
 import { createDOMMutationObservable } from './domMutationObservable'
@@ -3,0 +3,0 @@

src/domain/requestCollection.spec.ts

 import {
   Configuration,
   DEFAULT_CONFIGURATION,
+  isIE,
   RequestType,
@@ -8,11 +9,3 @@ resetFetchProxy,
 } from '@datadog/browser-core'
-import {
-  FetchStub,
-  FetchStubManager,
-  isIE,
-  SPEC_ENDPOINTS,
-  stubFetch,
-  stubXhr,
-  withXhr,
-} from '../../../core/test/specHelper'
+import { FetchStub, FetchStubManager, SPEC_ENDPOINTS, stubFetch, stubXhr, withXhr } from '../../../core/test/specHelper'
 import { LifeCycle, LifeCycleEventType } from './lifeCycle'
@@ -19,0 +12,0 @@ import { RequestCompleteEvent, RequestStartEvent, trackFetch, trackXhr } from './requestCollection'

src/domain/rumEventsCollection/action/getActionNameFromElement.ts

@@ -1,2 +0,2 @@
-import { safeTruncate } from '@datadog/browser-core'
+import { safeTruncate, isIE } from '@datadog/browser-core'
 
@@ -185,18 +185,20 @@ /**
 /**
- * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element.  This
- * should be the case everywhere except on some version of Internet Explorer.
- * See http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * Returns true if element.innerText excludes the text from inline SCRIPT and STYLE element. This
+ * should be the case everywhere except on Internet Explorer 10 and 11 (see [1])
+ *
+ * The innerText property relies on what is actually rendered to compute its output, so to check if
+ * it actually excludes SCRIPT and STYLE content, a solution would be to create a style element, set
+ * its content to '*', inject it in the document body, and check if the style element innerText
+ * property returns '*'. Using a new `document` instance won't work as it is not rendered.
+ *
+ * This solution requires specific CSP rules (see [2]) to be set by the customer. We want to avoid
+ * this, so instead we rely on browser detection. In case of false negative, the impact should be
+ * low, since we rely on this result to remove the SCRIPT and STYLE innerText (which will be empty)
+ * from a parent element innerText.
+ *
+ * [1]: https://web.archive.org/web/20210602165716/http://perfectionkills.com/the-poor-misunderstood-innerText/#diff-with-textContent
+ * [2]: https://github.com/DataDog/browser-sdk/issues/1084
  */
-let supportsInnerTextScriptAndStyleRemovalResult: boolean | undefined
 function supportsInnerTextScriptAndStyleRemoval() {
-  if (supportsInnerTextScriptAndStyleRemovalResult === undefined) {
-    const style = document.createElement('style')
-    style.textContent = '*'
-    const div = document.createElement('div')
-    div.appendChild(style)
-    document.body.appendChild(div)
-    supportsInnerTextScriptAndStyleRemovalResult = div.innerText === ''
-    document.body.removeChild(div)
-  }
-  return supportsInnerTextScriptAndStyleRemovalResult
+  return !isIE()
 }
@@ -203,0 +205,0 @@

src/domain/rumEventsCollection/resource/matchRequestTiming.spec.ts

@@ -1,4 +0,3 @@
-import { Duration, RelativeTime, relativeToClocks } from '@datadog/browser-core'
+import { Duration, isIE, RelativeTime, relativeToClocks } from '@datadog/browser-core'
 import { createResourceEntry } from '../../../../test/fixtures'
-import { isIE } from '../../../../../core/test/specHelper'
 import { RumPerformanceResourceTiming } from '../../../browser/performanceCollection'
@@ -5,0 +4,0 @@ import { RequestCompleteEvent } from '../../requestCollection'

src/domain/rumEventsCollection/resource/resourceCollection.spec.ts

@@ -1,3 +0,10 @@
-import { Duration, RelativeTime, RequestType, ResourceType, ServerDuration, TimeStamp } from '@datadog/browser-core'
-import { isIE } from '../../../../../core/test/specHelper'
+import {
+  Duration,
+  isIE,
+  RelativeTime,
+  RequestType,
+  ResourceType,
+  ServerDuration,
+  TimeStamp,
+} from '@datadog/browser-core'
 import { createResourceEntry } from '../../../../test/fixtures'
@@ -4,0 +11,0 @@ import { setup, TestSetupBuilder } from '../../../../test/specHelper'

src/domain/rumSession.spec.ts

@@ -6,2 +6,3 @@ import {
   getCookie,
+  isIE,
   SESSION_COOKIE_NAME,
@@ -11,3 +12,3 @@ setCookie,
 } from '@datadog/browser-core'
-import { Clock, isIE, mockClock } from '../../../core/test/specHelper'
+import { Clock, mockClock } from '../../../core/test/specHelper'
 
@@ -14,0 +15,0 @@ import { LifeCycle, LifeCycleEventType } from './lifeCycle'

src/domain/tracing/tracer.spec.ts

@@ -1,3 +0,2 @@
-import { Configuration, DEFAULT_CONFIGURATION, objectEntries } from '@datadog/browser-core'
-import { isIE } from '../../../../core/test/specHelper'
+import { Configuration, DEFAULT_CONFIGURATION, isIE, objectEntries } from '@datadog/browser-core'
 import { setup, TestSetupBuilder } from '../../../test/specHelper'
@@ -4,0 +3,0 @@ import {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

979357

increased by0.01%

Lines of code

20031

increased by0.02%

Dependency changes

• + Added@datadog/browser-core@3.6.10(transitive)

• - Removed@datadog/browser-core@3.6.8(transitive)

• Updated@datadog/browser-core@3.6.10