@datadog/browser-rum-core - npm Package Compare versions

Comparing version 4.17.1 to 4.17.2

cjs/domain/assembly.js

@@ -51,3 +51,3 @@ "use strict";
                     },
-                    browser_sdk_version: (0, browser_core_1.canUseEventBridge)() ? "4.17.1" : undefined,
+                    browser_sdk_version: (0, browser_core_1.canUseEventBridge)() ? "4.17.2" : undefined,
                 },
@@ -54,0 +54,0 @@ application: {

cjs/domain/rumEventsCollection/action/getSelectorsFromElement.d.ts

 export declare function getSelectorsFromElement(element: Element, actionNameAttribute: string | undefined): {
     selector: string;
     selector_with_stable_attributes: string;
+    selector_without_classes: string;
 };

cjs/domain/rumEventsCollection/action/getSelectorsFromElement.js

@@ -33,2 +33,3 @@ "use strict";
         selector_with_stable_attributes: getSelectorFromElement(element, attributeSelectors.concat(getIDSelector), attributeSelectors.concat(getClassSelector)),
+        selector_without_classes: getSelectorFromElement(element, attributeSelectors.concat(getIDSelector), attributeSelectors),
     };
@@ -35,0 +36,0 @@ }

esm/domain/assembly.js

@@ -48,3 +48,3 @@ import { combine, isEmptyObject, limitModification, timeStampNow, currentDrift, display, createEventRateLimiter, canUseEventBridge, } from '@datadog/browser-core';
                     },
-                    browser_sdk_version: canUseEventBridge() ? "4.17.1" : undefined,
+                    browser_sdk_version: canUseEventBridge() ? "4.17.2" : undefined,
                 },
@@ -51,0 +51,0 @@ application: {

esm/domain/rumEventsCollection/action/getSelectorsFromElement.d.ts

 export declare function getSelectorsFromElement(element: Element, actionNameAttribute: string | undefined): {
     selector: string;
     selector_with_stable_attributes: string;
+    selector_without_classes: string;
 };

esm/domain/rumEventsCollection/action/getSelectorsFromElement.js

@@ -30,2 +30,3 @@ import { arrayFrom, cssEscape, elementMatches } from '@datadog/browser-core';
         selector_with_stable_attributes: getSelectorFromElement(element, attributeSelectors.concat(getIDSelector), attributeSelectors.concat(getClassSelector)),
+        selector_without_classes: getSelectorFromElement(element, attributeSelectors.concat(getIDSelector), attributeSelectors),
     };
@@ -32,0 +33,0 @@ }

package.json

 {
   "name": "@datadog/browser-rum-core",
-  "version": "4.17.1",
+  "version": "4.17.2",
   "license": "Apache-2.0",
@@ -15,3 +15,3 @@ "main": "cjs/index.js",
   "dependencies": {
-    "@datadog/browser-core": "4.17.1"
+    "@datadog/browser-core": "4.17.2"
   },
@@ -26,3 +26,3 @@ "devDependencies": {
   },
-  "gitHead": "3f6b5c15863789d67a7310d9b71883db7020b994"
+  "gitHead": "b4a39bcc003ad5f38044dfedbe3bd3b118281183"
 }

src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts

@@ -123,2 +123,12 @@ import type { IsolatedDom } from '../../../../test/createIsolatedDom'
   })
+
+  describe('selector without classes', () => {
+    it('does not rely on classes', () => {
+      expect(getSelectorWithoutClasses('<div class="foo"></div>')).toBe('BODY>DIV')
+    })
+
+    function getSelectorWithoutClasses(html: string, actionNameAttribute?: string): string {
+      return getSelectorsFromElement(isolatedDom.append(html), actionNameAttribute).selector_without_classes
+    }
+  })
 })

src/domain/rumEventsCollection/action/getSelectorsFromElement.ts

@@ -38,2 +38,7 @@ import { arrayFrom, cssEscape, elementMatches } from '@datadog/browser-core'
     ),
+    selector_without_classes: getSelectorFromElement(
+      element,
+      attributeSelectors.concat(getIDSelector),
+      attributeSelectors
+    ),
   }
@@ -40,0 +45,0 @@ }

src/domain/rumEventsCollection/action/trackClickActions.spec.ts

@@ -126,3 +126,9 @@ import type { Context, Observable, Duration } from '@datadog/browser-core'
         jasmine.objectContaining({
-          target: { selector: '#button', selector_with_stable_attributes: '#button', width: 100, height: 100 },
+          target: {
+            selector: '#button',
+            selector_with_stable_attributes: '#button',
+            selector_without_classes: '#button',
+            width: 100,
+            height: 100,
+          },
           position: { x: 50, y: 50 },
@@ -129,0 +135,0 @@ })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1181345

increased by0.1%

Lines of code

24131

increased by0.1%

Dependency changes

• + Added@datadog/browser-core@4.17.2(transitive)

• - Removed@datadog/browser-core@4.17.1(transitive)

• Updated@datadog/browser-core@4.17.2