@devlln/helm - npm Package Compare versions

Comparing version 0.1.8 to 0.1.9

bridge/package-lock.json

 {
   "name": "codex-voice-remote-bridge",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "lockfileVersion": 3,
@@ -9,3 +9,3 @@ "requires": true,
       "name": "codex-voice-remote-bridge",
-      "version": "0.1.8",
+      "version": "0.1.9",
       "dependencies": {
@@ -12,0 +12,0 @@ "dotenv": "^16.6.1",

bridge/package.json

 {
   "name": "codex-voice-remote-bridge",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "private": true,
@@ -5,0 +5,0 @@ "type": "module",

bridge/src/codexAppServerClient.test.ts

 import test from "node:test";
 import assert from "node:assert/strict";
 import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import net from "node:net";
+import http from "node:http";
 import { tmpdir } from "node:os";
 import path from "node:path";
+import { WebSocketServer } from "ws";
 
@@ -120,2 +121,9 @@ import { CodexAppServerClient, currentPromptDraftFromTerminalTail } from "./codexAppServerClient.js";
   ): Promise<JSONValue | undefined>;
+  steerTurnViaCodexDesktopIpc(
+    threadId: string,
+    text: string,
+    options: TestStartTurnOptions,
+    thread: { cwd?: string; sourceKind?: string | null },
+    baseline: unknown
+  ): Promise<JSONValue | undefined>;
   codexDesktopQueuedFollowUpsWithAppendedMessage(
@@ -127,67 +135,3 @@ currentMessages: TestQueuedFollowUp[],
 
-function encodeRawServerTextFrame(text: string): Buffer {
-  const payload = Buffer.from(text, "utf8");
-  if (payload.length < 126) {
-    return Buffer.concat([Buffer.from([0x81, payload.length]), payload]);
-  }
-
-  if (payload.length < 65_536) {
-    const header = Buffer.alloc(4);
-    header[0] = 0x81;
-    header[1] = 126;
-    header.writeUInt16BE(payload.length, 2);
-    return Buffer.concat([header, payload]);
-  }
-
-  const header = Buffer.alloc(10);
-  header[0] = 0x81;
-  header[1] = 127;
-  header.writeBigUInt64BE(BigInt(payload.length), 2);
-  return Buffer.concat([header, payload]);
-}
-
-function decodeRawClientTextFrame(buffer: Buffer): { text: string; consumed: number } | null {
-  if (buffer.length < 2) {
-    return null;
-  }
-
-  const firstByte = buffer[0]!;
-  const secondByte = buffer[1]!;
-  const opcode = firstByte & 0x0f;
-  let length = secondByte & 0x7f;
-  let offset = 2;
-  if (length === 126) {
-    if (buffer.length < offset + 2) {
-      return null;
-    }
-    length = buffer.readUInt16BE(offset);
-    offset += 2;
-  } else if (length === 127) {
-    if (buffer.length < offset + 8) {
-      return null;
-    }
-    length = Number(buffer.readBigUInt64BE(offset));
-    offset += 8;
-  }
-
-  const masked = (secondByte & 0x80) !== 0;
-  if (!masked || opcode !== 1) {
-    throw new Error("expected masked text frame");
-  }
-
-  if (buffer.length < offset + 4 + length) {
-    return null;
-  }
-
-  const mask = buffer.subarray(offset, offset + 4);
-  offset += 4;
-  const payload = Buffer.from(buffer.subarray(offset, offset + length));
-  for (let index = 0; index < payload.length; index += 1) {
-    payload[index] = payload[index]! ^ mask[index % 4]!;
-  }
-
-  return { text: payload.toString("utf8"), consumed: offset + length };
-}
-
-test("Codex app-server client initializes over raw unix socket transport", async (t) => {
+test("Codex app-server client initializes over websocket unix socket transport", async (t) => {
   if (process.platform === "win32") {
@@ -199,14 +143,11 @@ return;
   const socketPath = path.join(directory, "app.sock");
-  const server = net.createServer((socket) => {
-    let buffer = Buffer.alloc(0);
+  const server = http.createServer();
+  const sockets = new WebSocketServer({
+    server,
+    perMessageDeflate: false,
+  });
 
-    socket.on("data", (chunk) => {
-      buffer = Buffer.concat([buffer, chunk]);
-      const frame = decodeRawClientTextFrame(buffer);
-      if (!frame) {
-        return;
-      }
-
-      buffer = buffer.subarray(frame.consumed);
-      const request = JSON.parse(frame.text) as {
+  sockets.on("connection", (socket) => {
+    socket.once("message", (data) => {
+      const request = JSON.parse(data.toString()) as {
         id: string | number;
@@ -216,3 +157,3 @@ method?: string;
       assert.equal(request.method, "initialize");
-      socket.write(encodeRawServerTextFrame(JSON.stringify({
+      socket.send(JSON.stringify({
         id: request.id,
@@ -225,5 +166,3 @@ result: {
         },
-      })), () => {
-        socket.destroy();
-      });
+      }), () => socket.close());
     });
@@ -233,2 +172,6 @@ });
   t.after(() => {
+    for (const client of sockets.clients) {
+      client.terminate();
+    }
+    sockets.close();
     server.close();
@@ -362,2 +305,109 @@ rmSync(directory, { recursive: true, force: true });
 
+test("queued idle Codex desktop turn starts immediately instead of becoming an invisible follow-up", async () => {
+  const client = new CodexAppServerClient("ws://127.0.0.1:0");
+  const hooks = client as unknown as CodexClientPrivateHooks;
+  let enqueueCalls = 0;
+  let startCalls = 0;
+
+  hooks.loadThreadDeliverySummary = async () => ({
+    sourceKind: "vscode",
+    status: "idle",
+  });
+  hooks.readThreadDeliverySnapshot = async () => ({
+    hasTurnData: true,
+    turnCount: 2,
+    matchingUserTextCount: 0,
+    updatedAt: 123_000,
+    threadStatus: "idle",
+    activeTurnId: null,
+  });
+  hooks.enqueueTurnViaCodexDesktopIpc = async () => {
+    enqueueCalls += 1;
+    throw new Error("idle desktop sends should not queue a follow-up");
+  };
+  hooks.startTurnViaCodexDesktopIpc = async (threadId, text, options) => {
+    startCalls += 1;
+    assert.equal(threadId, "thread-1");
+    assert.equal(text, "from mobile");
+    assert.equal(options.deliveryMode, "queue");
+    return {
+      ok: true,
+      mode: "codexDesktopIpcStart",
+      threadId,
+    };
+  };
+
+  const result = await client.startTurn("thread-1", "from mobile", {
+    deliveryMode: "queue",
+  });
+
+  assert.equal(enqueueCalls, 0);
+  assert.equal(startCalls, 1);
+  assert.deepEqual(result, {
+    ok: true,
+    mode: "codexDesktopIpcStart",
+    threadId: "thread-1",
+  });
+});
+
+test("idle Codex desktop turn falls back to app-server when desktop IPC has no loaded client", async () => {
+  const client = new CodexAppServerClient("ws://127.0.0.1:0");
+  const hooks = client as unknown as CodexClientPrivateHooks;
+  const requestCalls: Array<{ method: string; params?: JSONValue }> = [];
+
+  hooks.loadThreadDeliverySummary = async () => ({
+    sourceKind: "vscode",
+    status: "idle",
+  });
+  hooks.readThreadDeliverySnapshot = async () => ({
+    hasTurnData: true,
+    turnCount: 2,
+    matchingUserTextCount: 0,
+    updatedAt: 123_000,
+    threadStatus: "idle",
+    activeTurnId: null,
+  });
+  hooks.startTurnViaCodexDesktopIpc = async () => {
+    throw new Error("Codex Desktop IPC thread-follower-start-turn failed: no-client-found");
+  };
+  hooks.steerTurnViaCodexDesktopIpc = async () => {
+    throw new Error("Codex Desktop IPC thread-follower-steer-turn failed: no-client-found");
+  };
+  hooks.enqueueTurnViaCodexDesktopIpc = async () => {
+    throw new Error("idle desktop sends should not queue a follow-up");
+  };
+  hooks.request = async (method: string, params?: JSONValue) => {
+    requestCalls.push({ method, params });
+    assert.equal(method, "turn/start");
+    return {
+      ok: true,
+    };
+  };
+
+  const result = await client.startTurn("thread-1", "from mobile", {
+    deliveryMode: "steer",
+  });
+
+  assert.deepEqual(requestCalls, [
+    {
+      method: "turn/start",
+      params: {
+        threadId: "thread-1",
+        input: [
+          {
+            type: "text",
+            text: "from mobile",
+            text_elements: [],
+          },
+        ],
+      },
+    },
+  ]);
+  assert.deepEqual(result, {
+    ok: true,
+    mode: "appServerStartAfterDesktopIpcNoClient",
+    threadId: "thread-1",
+  });
+});
+
 test("queued Codex desktop turn keeps queue mode when an image is attached", async () => {
@@ -364,0 +414,0 @@ const client = new CodexAppServerClient("ws://127.0.0.1:0");

package.json

 {
   "name": "@devlln/helm",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "private": false,
@@ -5,0 +5,0 @@ "description": "Helm CLI bridge installer and runtime helpers.",

New alerts

AI-detected potential code anomaly

Supply chain risk

AI has identified unusual behaviors that may pose a security risk.

Found 1 instance in 1 package

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Fixed alerts

AI-detected potential code anomaly

Supply chain risk

AI has identified unusual behaviors that may pose a security risk.

Found 1 instance in 1 package

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

845434

-0.36%

Lines of code

21883

-0.49%

No dependency changes