@dpc-sdp/ripple-global - npm Package Compare versions

Comparing version 1.0.0-alpha.4 to 1.0.0-alpha.5

mixins/cardtrimfield.js

@@ -20,4 +20,4 @@ import breakpoint from '@dpc-sdp/ripple-global/mixins/breakpoint'
         let card = this.$el
-        if (card.data) {
-          let summary = card.querySelector(this.trimFieldSelector)
+        let summary = card.querySelector(this.trimFieldSelector)
+        if (summary) {
           // Properties
@@ -29,2 +29,4 @@ let summaryLineHeight = parseFloat(window.getComputedStyle(summary, null).getPropertyValue('line-height'))
           this.trimFieldMaxHeight = (summary.clientHeight > summaryAllowedHeight) ? summaryAllowedHeight + 'px' : 'none'
+        } else {
+          this.trimFieldMaxHeight = 'none'
         }
@@ -31,0 +33,0 @@ } else {

package.json

 {
   "name": "@dpc-sdp/ripple-global",
-  "version": "1.0.0-alpha.4",
+  "version": "1.0.0-alpha.5",
   "description": "The core styles and utilities used by all ripple components. Includes sets of colours, fonts, breakpoints.",
@@ -5,0 +5,0 @@ "main": "./index.js",

README.md

@@ -31,7 +31,7 @@ # @dpc-sdp/ripple-global
 
-See [Storybook/Colors](https://ripple-ripple-develop.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Colors).
+See [Storybook/Colors](https://storybook-ripple-master.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Colors).
 
-See [Storybook/Typography](https://ripple-ripple-develop.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Typography).
+See [Storybook/Typography](https://storybook-ripple-master.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Typography).
 
-See [Storybook/Breakpoints](https://ripple-ripple-develop.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Breakpoints).
+See [Storybook/Breakpoints](https://storybook-ripple-master.lagoon.vicsdp.amazee.io/?selectedKind=Atoms/Global&selectedStory=Breakpoints).
 
@@ -38,0 +38,0 @@ --------------------------------------------------------------------------------

utils/helpers.js

@@ -33,3 +33,3 @@ /* eslint-disable */
 const isAnchorLink = (url) => {
-  return (url.length > 0 && url[0] === '#')
+  return (typeof url === 'string' && url.length > 0 && url[0] === '#')
 }
@@ -36,0 +36,0 @@

No alert changes

Improved metrics

Total package byte prevSize

1519354

increased by0.01%

Lines of code

380

increased by0.53%

No dependency changes