@dpc-sdp/ripple-tide-api - npm Package Compare versions

Comparing version 2.1.0-alpha.2 to 2.1.0-alpha.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+# [2.1.0-alpha.3](https://github.com/dpc-sdp/ripple-framework/compare/v2.1.0-alpha.2...v2.1.0-alpha.3) (2022-11-09)
+
+
+### Bug Fixes
+
+* **@dpc-sdp/ripple-tide-api:** remove stripping of backend url from images ([4b18930](https://github.com/dpc-sdp/ripple-framework/commit/4b189307f7ac019fff2a1bfefb425e1134c764c1))
+
+
+
+
+
 # [2.1.0-alpha.2](https://github.com/dpc-sdp/ripple-framework/compare/v2.1.0-alpha.1...v2.1.0-alpha.2) (2022-11-09)
@@ -8,0 +19,0 @@

dist/utils/mapping-utils.js

@@ -10,2 +10,5 @@ import { get } from 'lodash-es';
 };
+/**
+ * @deprecated Need to make a decision on whether we proxy images or use direct url
+ */
 export const removeDomainFromPath = (path) => typeof path === 'string' && path.length > 0
@@ -27,8 +30,4 @@ ? path.replace(/^.*(?=(\/sites\/default\/files))/, '')
     }
-    // Replace BE domain for images as they will be proxied through FE
     return {
-        src: fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : '',
-        // src: `https://develop.content.reference.sdp.vic.gov.au${
-        //   fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : ''
-        // }`,
+        src: fieldMediaImage.url,
         ...fieldMediaImage.meta,
@@ -46,8 +45,4 @@ focalPoint
         : null;
-    // Replace BE domain for images as they will be proxied through FE
     return {
-        src: fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : '',
-        // src: `https://develop.content.reference.sdp.vic.gov.au${
-        //   fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : ''
-        // }`,
+        src: fieldMediaImage.url,
         focalPoint,
@@ -54,0 +49,0 @@ alt: data?.alt,

package.json

 {
   "name": "@dpc-sdp/ripple-tide-api",
-  "version": "2.1.0-alpha.2",
+  "version": "2.1.0-alpha.3",
   "description": "Ripple API endpoints for Tide Drupal backend",
@@ -57,3 +57,3 @@ "main": "./dist/index.js",
   ],
-  "gitHead": "e04ad295e9ec859d3f6d4a05ef3e6580b79b7c7b"
+  "gitHead": "73265aa996ed5e8fcb7c221eae16ebfd8579f75e"
 }

src/utils/mapping-utils.ts

@@ -47,2 +47,5 @@ import { get } from 'lodash-es'
 
+/**
+ * @deprecated Need to make a decision on whether we proxy images or use direct url
+ */
 export const removeDomainFromPath = (path: string) =>
@@ -76,8 +79,4 @@ typeof path === 'string' && path.length > 0
   }
-  // Replace BE domain for images as they will be proxied through FE
   return {
-    src: fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : '',
-    // src: `https://develop.content.reference.sdp.vic.gov.au${
-    //   fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : ''
-    // }`,
+    src: fieldMediaImage.url,
     ...fieldMediaImage.meta,
@@ -98,8 +97,4 @@ focalPoint
 
-  // Replace BE domain for images as they will be proxied through FE
   return {
-    src: fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : '',
-    // src: `https://develop.content.reference.sdp.vic.gov.au${
-    //   fieldMediaImage.url ? removeDomainFromPath(fieldMediaImage.url) : ''
-    // }`,
+    src: fieldMediaImage.url,
     focalPoint,
@@ -106,0 +101,0 @@ alt: data?.alt,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

320495

decreased by-0.26%

Lines of code

5704

decreased by-0.18%

No dependency changes