@dreamworld/dw-form - npm Package Compare versions

Comparing version 4.0.0 to 4.1.0-remove-custom-getter-setter.1

dw-form-field.js

 import { LitElement, html, css, unsafeCSS } from "@dreamworld/pwa-helpers/lit.js";
-import { classMap } from 'lit/directives/class-map.js';
+import { classMap } from "lit/directives/class-map.js";
 
@@ -100,2 +100,9 @@ import * as TypographyLiterals from "@dreamworld/material-styles/typography-literals";
 
+  updated(_changeProperties) {
+    if (_changeProperties.has("label")) {
+      const labelEl = this.renderRoot.querySelector(".dw-label");
+      this._hasLabel = !!(this.label || labelEl);
+    }
+  }
+
   render() {
@@ -132,17 +139,4 @@ const classes = {
   }
-
-  set label(value) {
-    const oldValue = this._label;
-    let labelEl = this.renderRoot?.querySelector('.dw-label') ?? null
-    // let labelEl = this.renderRoot.querySelector(".dw-label");
-    this._label = value;
-    this._hasLabel = !!(value || labelEl);
-    this.requestUpdate("label", oldValue);
-  }
-
-  get label() {
-    return this._label;
-  }
 }
 
 window.customElements.define("dw-form-field", DwFormField);

package.json

 {
   "name": "@dreamworld/dw-form",
-  "version": "4.0.0",
+  "version": "4.1.0-remove-custom-getter-setter.1",
   "description": "",
@@ -5,0 +5,0 @@ "main": "dw-form.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

27744

decreased by-0.43%

Lines of code

646

decreased by-0.77%

Number of low quality alerts

2

increased by100%

No dependency changes