@elastic/apm-rum-core - npm Package Compare versions

Comparing version 4.6.0 to 4.6.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [4.6.1](https://github.com/elastic/apm-agent-rum-js/compare/@elastic/apm-rum-core@4.6.0...@elastic/apm-rum-core@4.6.1) (2019-10-09)
+
+
+### Bug Fixes
+
+* **rum-core:** handle relative urls without slash properly ([#446](https://github.com/elastic/apm-agent-rum-js/issues/446)) ([288e8b1](https://github.com/elastic/apm-agent-rum-js/commit/288e8b1))
+
+
+
+
+
 # [4.6.0](https://github.com/elastic/apm-agent-rum-js/compare/@elastic/apm-rum-core@4.5.4...@elastic/apm-rum-core@4.6.0) (2019-09-30)
@@ -8,0 +19,0 @@

dist/es/common/url.js

@@ -15,2 +15,7 @@ var RULES = [['#', 'hash'], ['?', 'query'], ['/', 'path'], ['@', 'auth', 1], [NaN, 'host', undefined, 1]];
     address = address.replace('\\', '/');
+
+    if (!slashes) {
+      instructions[2] = [NaN, 'path'];
+    }
+
     var index;
@@ -41,2 +46,3 @@
         this[key] = address;
+        address = '';
       }
@@ -48,4 +54,8 @@
 
+    if (relative && this.path.charAt(0) !== '/') {
+      this.path = '/' + this.path;
+    }
+
     this.relative = relative;
-    this.protocol = protocol || location.protocol || '';
+    this.protocol = protocol || location.protocol;
     this.origin = this.protocol && this.host && this.protocol !== 'file:' ? this.protocol + '//' + this.host : 'null';
@@ -52,0 +62,0 @@ this.href = this.toString();

dist/lib/common/url.js

@@ -19,2 +19,7 @@ "use strict";
     address = address.replace('\\', '/');
+
+    if (!slashes) {
+      instructions[2] = [NaN, 'path'];
+    }
+
     var index;
@@ -45,2 +50,3 @@
         this[key] = address;
+        address = '';
       }
@@ -52,4 +58,8 @@
 
+    if (relative && this.path.charAt(0) !== '/') {
+      this.path = '/' + this.path;
+    }
+
     this.relative = relative;
-    this.protocol = protocol || location.protocol || '';
+    this.protocol = protocol || location.protocol;
     this.origin = this.protocol && this.host && this.protocol !== 'file:' ? this.protocol + '//' + this.host : 'null';
@@ -56,0 +66,0 @@ this.href = this.toString();

package.json

 {
   "name": "@elastic/apm-rum-core",
-  "version": "4.6.0",
+  "version": "4.6.1",
   "description": "Elastic apm core",
@@ -44,3 +44,3 @@ "license": "MIT",
   },
-  "gitHead": "e9938243a657405d2f231be93d258274fc4e5cc5"
+  "gitHead": "902460082e31371da206b831d18ec530d36118b5"
 }

src/common/url.js

@@ -74,2 +74,10 @@ /**
 
+    /**
+     * When the authority component is absent the URL starts with a path component.
+     * By setting it as NaN, we set the remaining parsed address to path
+     */
+    if (!slashes) {
+      instructions[2] = [NaN, 'path']
+    }
+
     let index
@@ -106,2 +114,3 @@ for (let i = 0; i < instructions.length; i++) {
         this[key] = address
+        address = ''
       }
@@ -120,5 +129,13 @@ /**
 
+    /**
+     * if the URL is relative, prepend the path with `/`
+     * to construct the href correctly
+     */
+    if (relative && this.path.charAt(0) !== '/') {
+      this.path = '/' + this.path
+    }
+
     this.relative = relative
 
-    this.protocol = protocol || location.protocol || ''
+    this.protocol = protocol || location.protocol
 
@@ -125,0 +142,0 @@ this.origin =

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

366645

increased by0.32%

Lines of code

10536

increased by0.28%

No dependency changes