@electron/osx-sign - npm Package Compare versions

Comparing version 1.0.4 to 1.0.5

dist/cjs/flat.d.ts

@@ -11,2 +11,2 @@ import { FlatOptions } from './types';
  */
-export declare const flat: (opts: FlatOptions, cb?: ((error?: Error | undefined) => void) | undefined) => void;
+export declare const flat: (opts: FlatOptions, cb?: ((error?: Error) => void) | undefined) => void;

dist/cjs/flat.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

dist/cjs/index.d.ts

 import { sign, signApp } from './sign';
 import { flat, buildPkg } from './flat';
 export { sign, flat, signApp as signAsync, signApp, buildPkg as flatAsync, buildPkg };
+export * from './types';

dist/cjs/index.js

 "use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __exportStar = (this && this.__exportStar) || function(m, exports) {
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
+};
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -21,2 +35,3 @@ exports.buildPkg = exports.flatAsync = exports.signApp = exports.signAsync = exports.flat = exports.sign = void 0;
 module.exports.buildPkg = flat_1.buildPkg;
+__exportStar(require("./types"), exports);
 //# sourceMappingURL=index.js.map

dist/cjs/sign.d.ts

@@ -11,2 +11,2 @@ import { SignOptions } from './types';
  */
-export declare const sign: (opts: SignOptions, cb?: ((error?: Error | undefined) => void) | undefined) => void;
+export declare const sign: (opts: SignOptions, cb?: ((error?: Error) => void) | undefined) => void;

dist/cjs/sign.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -189,19 +193,23 @@ if (k2 === undefined) k2 = k;
         const perFileOptions = await mergeOptionsForFile(opts.optionsForFile ? opts.optionsForFile(filePath) : null, defaultOptionsForFile(filePath, opts.platform));
-        if (opts.preAutoEntitlements === false) {
-            (0, util_1.debugWarn)('Pre-sign operation disabled for entitlements automation.');
-        }
-        else {
-            (0, util_1.debugLog)('Pre-sign operation enabled for entitlements automation with versions >= `1.1.1`:', '\n', '* Disable by setting `pre-auto-entitlements` to `false`.');
-            if (!opts.version || (0, compare_version_1.default)(opts.version, '1.1.1') >= 0) {
-                // Enable Mac App Store sandboxing without using temporary-exception, introduced in Electron v1.1.1. Relates to electron#5601
-                const newEntitlements = await (0, util_entitlements_1.preAutoEntitlements)(opts, perFileOptions, {
-                    identity,
-                    provisioningProfile: opts.provisioningProfile
-                        ? await (0, util_provisioning_profiles_1.getProvisioningProfile)(opts.provisioningProfile, opts.keychain)
-                        : undefined
-                });
-                // preAutoEntitlements may provide us new entitlements, if so we update our options
-                // and ensure that entitlements-loginhelper has a correct default value
-                if (newEntitlements) {
-                    perFileOptions.entitlements = newEntitlements;
+        // preAutoEntitlements should only be applied to the top level app bundle.
+        // Applying it other files will cause the app to crash and be rejected by Apple.
+        if (!filePath.includes('.app/')) {
+            if (opts.preAutoEntitlements === false) {
+                (0, util_1.debugWarn)('Pre-sign operation disabled for entitlements automation.');
+            }
+            else {
+                (0, util_1.debugLog)('Pre-sign operation enabled for entitlements automation with versions >= `1.1.1`:', '\n', '* Disable by setting `pre-auto-entitlements` to `false`.');
+                if (!opts.version || (0, compare_version_1.default)(opts.version, '1.1.1') >= 0) {
+                    // Enable Mac App Store sandboxing without using temporary-exception, introduced in Electron v1.1.1. Relates to electron#5601
+                    const newEntitlements = await (0, util_entitlements_1.preAutoEntitlements)(opts, perFileOptions, {
+                        identity,
+                        provisioningProfile: opts.provisioningProfile
+                            ? await (0, util_provisioning_profiles_1.getProvisioningProfile)(opts.provisioningProfile, opts.keychain)
+                            : undefined
+                    });
+                    // preAutoEntitlements may provide us new entitlements, if so we update our options
+                    // and ensure that entitlements-loginhelper has a correct default value
+                    if (newEntitlements) {
+                        perFileOptions.entitlements = newEntitlements;
+                    }
                 }
@@ -208,0 +216,0 @@ }

dist/cjs/types.d.ts

@@ -1,4 +0,4 @@
-export declare type ElectronMacPlatform = 'darwin' | 'mas';
-declare type SigningDistributionType = 'development' | 'distribution';
-export declare type BaseSignOptions = Readonly<{
+export type ElectronMacPlatform = 'darwin' | 'mas';
+type SigningDistributionType = 'development' | 'distribution';
+export type BaseSignOptions = Readonly<{
     app: string;
@@ -9,3 +9,3 @@ identity?: string;
 }>;
-declare type OnlyValidatedBaseSignOptions = {
+type OnlyValidatedBaseSignOptions = {
     platform: ElectronMacPlatform;
@@ -17,3 +17,3 @@ };
  */
-export declare type PerFileSignOptions = {
+export type PerFileSignOptions = {
     /**
@@ -43,3 +43,3 @@ * The entitlements file to use when signing this file
 };
-declare type OnlySignOptions = {
+type OnlySignOptions = {
     binaries?: string[];
@@ -56,7 +56,7 @@ optionsForFile?: (filePath: string) => PerFileSignOptions;
 };
-declare type OnlyValidatedSignOptions = {
+type OnlyValidatedSignOptions = {
     ignore?: (string | ((file: string) => boolean))[];
     type: SigningDistributionType;
 };
-declare type OnlyFlatOptions = {
+type OnlyFlatOptions = {
     identityValidation?: boolean;
@@ -67,12 +67,12 @@ install?: string;
 };
-declare type OnlyValidatedFlatOptions = {
+type OnlyValidatedFlatOptions = {
     install: string;
     pkg: string;
 };
-declare type ValidatedForm<UnValidated, Validated> = Omit<UnValidated, keyof Validated> & Validated;
-export declare type ValidatedBaseSignOptions = Readonly<ValidatedForm<BaseSignOptions, OnlyValidatedBaseSignOptions>>;
-export declare type SignOptions = Readonly<OnlySignOptions & BaseSignOptions>;
-export declare type ValidatedSignOptions = Readonly<ValidatedForm<OnlySignOptions, OnlyValidatedSignOptions> & ValidatedBaseSignOptions>;
-export declare type FlatOptions = Readonly<OnlyFlatOptions & BaseSignOptions>;
-export declare type ValidatedFlatOptions = Readonly<ValidatedForm<OnlyFlatOptions, OnlyValidatedFlatOptions> & ValidatedBaseSignOptions>;
+type ValidatedForm<UnValidated, Validated> = Omit<UnValidated, keyof Validated> & Validated;
+export type ValidatedBaseSignOptions = Readonly<ValidatedForm<BaseSignOptions, OnlyValidatedBaseSignOptions>>;
+export type SignOptions = Readonly<OnlySignOptions & BaseSignOptions>;
+export type ValidatedSignOptions = Readonly<ValidatedForm<OnlySignOptions, OnlyValidatedSignOptions> & ValidatedBaseSignOptions>;
+export type FlatOptions = Readonly<OnlyFlatOptions & BaseSignOptions>;
+export type ValidatedFlatOptions = Readonly<ValidatedForm<OnlyFlatOptions, OnlyValidatedFlatOptions> & ValidatedBaseSignOptions>;
 export {};

dist/cjs/util-entitlements.d.ts

 import { PerFileSignOptions, ValidatedSignOptions } from './types';
 import { Identity } from './util-identities';
 import { ProvisioningProfile } from './util-provisioning-profiles';
-declare type ComputedOptions = {
+type ComputedOptions = {
     identity: Identity;
@@ -6,0 +6,0 @@ provisioningProfile?: ProvisioningProfile;

dist/cjs/util-entitlements.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

dist/cjs/util-provisioning-profiles.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

dist/cjs/util.d.ts

@@ -8,4 +8,4 @@ /// <reference types="node" />
 export declare function execFileAsync(file: string, args: string[], options?: child.ExecFileOptions): Promise<string>;
-declare type DeepListItem<T> = null | T | DeepListItem<T>[];
-declare type DeepList<T> = DeepListItem<T>[];
+type DeepListItem<T> = null | T | DeepListItem<T>[];
+type DeepList<T> = DeepListItem<T>[];
 export declare function compactFlattenedList<T>(list: DeepList<T>): T[];
@@ -12,0 +12,0 @@ /**

dist/cjs/util.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

dist/esm/flat.d.ts

@@ -11,2 +11,2 @@ import { FlatOptions } from './types';
  */
-export declare const flat: (opts: FlatOptions, cb?: ((error?: Error | undefined) => void) | undefined) => void;
+export declare const flat: (opts: FlatOptions, cb?: ((error?: Error) => void) | undefined) => void;

dist/esm/index.d.ts

 import { sign, signApp } from './sign';
 import { flat, buildPkg } from './flat';
 export { sign, flat, signApp as signAsync, signApp, buildPkg as flatAsync, buildPkg };
+export * from './types';

dist/esm/index.js

@@ -13,2 +13,3 @@ import { sign, signApp } from './sign';
 export { sign, flat, signApp as signAsync, signApp, buildPkg as flatAsync, buildPkg };
+export * from './types';
 //# sourceMappingURL=index.js.map

dist/esm/sign.d.ts

@@ -11,2 +11,2 @@ import { SignOptions } from './types';
  */
-export declare const sign: (opts: SignOptions, cb?: ((error?: Error | undefined) => void) | undefined) => void;
+export declare const sign: (opts: SignOptions, cb?: ((error?: Error) => void) | undefined) => void;

dist/esm/sign.js

@@ -164,19 +164,23 @@ import * as fs from 'fs-extra';
         const perFileOptions = await mergeOptionsForFile(opts.optionsForFile ? opts.optionsForFile(filePath) : null, defaultOptionsForFile(filePath, opts.platform));
-        if (opts.preAutoEntitlements === false) {
-            debugWarn('Pre-sign operation disabled for entitlements automation.');
-        }
-        else {
-            debugLog('Pre-sign operation enabled for entitlements automation with versions >= `1.1.1`:', '\n', '* Disable by setting `pre-auto-entitlements` to `false`.');
-            if (!opts.version || compareVersion(opts.version, '1.1.1') >= 0) {
-                // Enable Mac App Store sandboxing without using temporary-exception, introduced in Electron v1.1.1. Relates to electron#5601
-                const newEntitlements = await preAutoEntitlements(opts, perFileOptions, {
-                    identity,
-                    provisioningProfile: opts.provisioningProfile
-                        ? await getProvisioningProfile(opts.provisioningProfile, opts.keychain)
-                        : undefined
-                });
-                // preAutoEntitlements may provide us new entitlements, if so we update our options
-                // and ensure that entitlements-loginhelper has a correct default value
-                if (newEntitlements) {
-                    perFileOptions.entitlements = newEntitlements;
+        // preAutoEntitlements should only be applied to the top level app bundle.
+        // Applying it other files will cause the app to crash and be rejected by Apple.
+        if (!filePath.includes('.app/')) {
+            if (opts.preAutoEntitlements === false) {
+                debugWarn('Pre-sign operation disabled for entitlements automation.');
+            }
+            else {
+                debugLog('Pre-sign operation enabled for entitlements automation with versions >= `1.1.1`:', '\n', '* Disable by setting `pre-auto-entitlements` to `false`.');
+                if (!opts.version || compareVersion(opts.version, '1.1.1') >= 0) {
+                    // Enable Mac App Store sandboxing without using temporary-exception, introduced in Electron v1.1.1. Relates to electron#5601
+                    const newEntitlements = await preAutoEntitlements(opts, perFileOptions, {
+                        identity,
+                        provisioningProfile: opts.provisioningProfile
+                            ? await getProvisioningProfile(opts.provisioningProfile, opts.keychain)
+                            : undefined
+                    });
+                    // preAutoEntitlements may provide us new entitlements, if so we update our options
+                    // and ensure that entitlements-loginhelper has a correct default value
+                    if (newEntitlements) {
+                        perFileOptions.entitlements = newEntitlements;
+                    }
                 }
@@ -183,0 +187,0 @@ }

dist/esm/types.d.ts

@@ -1,4 +0,4 @@
-export declare type ElectronMacPlatform = 'darwin' | 'mas';
-declare type SigningDistributionType = 'development' | 'distribution';
-export declare type BaseSignOptions = Readonly<{
+export type ElectronMacPlatform = 'darwin' | 'mas';
+type SigningDistributionType = 'development' | 'distribution';
+export type BaseSignOptions = Readonly<{
     app: string;
@@ -9,3 +9,3 @@ identity?: string;
 }>;
-declare type OnlyValidatedBaseSignOptions = {
+type OnlyValidatedBaseSignOptions = {
     platform: ElectronMacPlatform;
@@ -17,3 +17,3 @@ };
  */
-export declare type PerFileSignOptions = {
+export type PerFileSignOptions = {
     /**
@@ -43,3 +43,3 @@ * The entitlements file to use when signing this file
 };
-declare type OnlySignOptions = {
+type OnlySignOptions = {
     binaries?: string[];
@@ -56,7 +56,7 @@ optionsForFile?: (filePath: string) => PerFileSignOptions;
 };
-declare type OnlyValidatedSignOptions = {
+type OnlyValidatedSignOptions = {
     ignore?: (string | ((file: string) => boolean))[];
     type: SigningDistributionType;
 };
-declare type OnlyFlatOptions = {
+type OnlyFlatOptions = {
     identityValidation?: boolean;
@@ -67,12 +67,12 @@ install?: string;
 };
-declare type OnlyValidatedFlatOptions = {
+type OnlyValidatedFlatOptions = {
     install: string;
     pkg: string;
 };
-declare type ValidatedForm<UnValidated, Validated> = Omit<UnValidated, keyof Validated> & Validated;
-export declare type ValidatedBaseSignOptions = Readonly<ValidatedForm<BaseSignOptions, OnlyValidatedBaseSignOptions>>;
-export declare type SignOptions = Readonly<OnlySignOptions & BaseSignOptions>;
-export declare type ValidatedSignOptions = Readonly<ValidatedForm<OnlySignOptions, OnlyValidatedSignOptions> & ValidatedBaseSignOptions>;
-export declare type FlatOptions = Readonly<OnlyFlatOptions & BaseSignOptions>;
-export declare type ValidatedFlatOptions = Readonly<ValidatedForm<OnlyFlatOptions, OnlyValidatedFlatOptions> & ValidatedBaseSignOptions>;
+type ValidatedForm<UnValidated, Validated> = Omit<UnValidated, keyof Validated> & Validated;
+export type ValidatedBaseSignOptions = Readonly<ValidatedForm<BaseSignOptions, OnlyValidatedBaseSignOptions>>;
+export type SignOptions = Readonly<OnlySignOptions & BaseSignOptions>;
+export type ValidatedSignOptions = Readonly<ValidatedForm<OnlySignOptions, OnlyValidatedSignOptions> & ValidatedBaseSignOptions>;
+export type FlatOptions = Readonly<OnlyFlatOptions & BaseSignOptions>;
+export type ValidatedFlatOptions = Readonly<ValidatedForm<OnlyFlatOptions, OnlyValidatedFlatOptions> & ValidatedBaseSignOptions>;
 export {};

dist/esm/util-entitlements.d.ts

 import { PerFileSignOptions, ValidatedSignOptions } from './types';
 import { Identity } from './util-identities';
 import { ProvisioningProfile } from './util-provisioning-profiles';
-declare type ComputedOptions = {
+type ComputedOptions = {
     identity: Identity;
@@ -6,0 +6,0 @@ provisioningProfile?: ProvisioningProfile;

dist/esm/util.d.ts

@@ -8,4 +8,4 @@ /// <reference types="node" />
 export declare function execFileAsync(file: string, args: string[], options?: child.ExecFileOptions): Promise<string>;
-declare type DeepListItem<T> = null | T | DeepListItem<T>[];
-declare type DeepList<T> = DeepListItem<T>[];
+type DeepListItem<T> = null | T | DeepListItem<T>[];
+type DeepList<T> = DeepListItem<T>[];
 export declare function compactFlattenedList<T>(list: DeepList<T>): T[];
@@ -12,0 +12,0 @@ /**

package.json

 {
   "name": "@electron/osx-sign",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Codesign Electron macOS apps",
@@ -37,2 +37,4 @@ "main": "dist/cjs/index.js",
   "devDependencies": {
+    "@continuous-auth/semantic-release-npm": "^3.0.0",
+    "@electron/get": "^2.0.2",
     "@types/compare-version": "^0.1.31",
@@ -43,11 +45,10 @@ "@types/debug": "^4.1.7",
     "@types/plist": "^3.0.2",
-    "@typescript-eslint/eslint-plugin": "^5.3.0",
-    "@typescript-eslint/parser": "^5.3.0",
-    "electron-download": "^4.1.0",
-    "eslint": "^8.1.0",
+    "@typescript-eslint/eslint-plugin": "^5.45.0",
+    "@typescript-eslint/parser": "^5.45.0",
+    "eslint": "^8.29.0",
     "eslint-config-eslint": "^7.0.0",
-    "eslint-config-standard": "^16.0.3",
-    "eslint-plugin-import": "^2.25.2",
+    "eslint-config-standard": "^17.0.0",
+    "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^5.1.1",
+    "eslint-plugin-promise": "^6.1.1",
     "extract-zip": "^2.0.1",
@@ -58,5 +59,5 @@ "mkdirp": "^1.0.4",
     "run-waterfall": "^1.1.7",
-    "standard": "^16.0.4",
+    "standard": "^17.0.0",
     "tape": "^4.7.1",
-    "typescript": "^4.4.4"
+    "typescript": "^4.9.3"
   },
@@ -63,0 +64,0 @@ "scripts": {

README.md

@@ -271,3 +271,3 @@ # @electron/osx-sign [![npm][npm_img]][npm_url] [![Build Status][circleci_img]][circleci_url]
 
-When this command is run for the first time: `electron-download` will download macOS Electron releases defined in `test/config.json`, and save to `~/.electron/`, which might take up less than 1GB of disk space.
+When this command is run for the first time: `@electron/get` will download macOS Electron releases defined in `test/config.json`, and save to `~/.electron/`, which might take up less than 1GB of disk space.
 
@@ -285,3 +285,3 @@ A successful testing should look something like:
 
-Calling electron-download before running tests...
+Calling @electron/get before running tests...
 Running tests...
@@ -288,0 +288,0 @@ TAP version 13

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

177083

increased by1.26%

Lines of code

2342

increased by2%

Number of medium supply chain risk alerts

2

decreased by-33.33%

Worsened metrics

Dev dependency count

23

increased by4.55%

No dependency changes