@feathersjs/transport-commons - npm Package Compare versions

Comparing version 5.0.27 to 5.0.28

CHANGELOG.md

@@ -6,2 +6,8 @@ # Change Log
 
+## [5.0.28](https://github.com/feathersjs/feathers/compare/v5.0.27...v5.0.28) (2024-07-10)
+
+### Bug Fixes
+
+- **transport-commons:** Fix HTTP status precedence ([#3511](https://github.com/feathersjs/feathers/issues/3511)) ([5d999a0](https://github.com/feathersjs/feathers/commit/5d999a0acddc0cb7692058209dfbc62673ab5a69))
+
 ## [5.0.27](https://github.com/feathersjs/feathers/compare/v5.0.26...v5.0.27) (2024-06-18)
@@ -8,0 +14,0 @@

lib/channels/channel/base.d.ts

@@ -1,2 +0,1 @@
-/// <reference types="node" />
 import { EventEmitter } from 'events';
@@ -3,0 +2,0 @@ import { RealTimeConnection } from '@feathersjs/feathers';

lib/channels/index.d.ts

@@ -1,2 +0,1 @@
-/// <reference types="node" />
 import { Application, RealTimeConnection } from '@feathersjs/feathers';
@@ -3,0 +2,0 @@ import { Channel } from './channel/base';

lib/channels/index.js

@@ -6,3 +6,4 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.CombinedChannel = exports.Channel = exports.channels = exports.keys = void 0;
+exports.CombinedChannel = exports.Channel = exports.keys = void 0;
+exports.channels = channels;
 const feathers_1 = require("@feathersjs/feathers");
@@ -86,3 +87,2 @@ const commons_1 = require("@feathersjs/commons");
 }
-exports.channels = channels;
 //# sourceMappingURL=index.js.map

lib/channels/mixins.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.publishMixin = exports.channelMixin = exports.keys = void 0;
+exports.keys = void 0;
+exports.channelMixin = channelMixin;
+exports.publishMixin = publishMixin;
 /* eslint-disable @typescript-eslint/no-unnecessary-type-assertion */
@@ -47,3 +49,2 @@ const feathers_1 = require("@feathersjs/feathers");
 }
-exports.channelMixin = channelMixin;
 function publishMixin() {
@@ -72,3 +73,2 @@ const result = {
 }
-exports.publishMixin = publishMixin;
 //# sourceMappingURL=mixins.js.map

lib/http.js

@@ -6,3 +6,6 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getResponse = exports.getStatusCode = exports.argumentsFor = exports.getServiceMethod = exports.knownMethods = exports.statusCodes = exports.METHOD_HEADER = void 0;
+exports.argumentsFor = exports.knownMethods = exports.statusCodes = exports.METHOD_HEADER = void 0;
+exports.getServiceMethod = getServiceMethod;
+exports.getStatusCode = getStatusCode;
+exports.getResponse = getResponse;
 const lib_1 = require("@feathersjs/errors/lib");
@@ -38,3 +41,2 @@ const encodeurl_1 = __importDefault(require("encodeurl"));
 }
-exports.getServiceMethod = getServiceMethod;
 exports.argumentsFor = {
@@ -54,5 +56,2 @@ get: ({ id, params }) => [id, params],
     }
-    if (context.method === 'create') {
-        return exports.statusCodes.created;
-    }
     if (location !== undefined) {
@@ -64,5 +63,7 @@ return exports.statusCodes.seeOther;
     }
+    if (context.method === 'create') {
+        return exports.statusCodes.created;
+    }
     return exports.statusCodes.success;
 }
-exports.getStatusCode = getStatusCode;
 function getResponse(context) {
@@ -80,3 +81,2 @@ const { http = {} } = context;
 }
-exports.getResponse = getResponse;
 //# sourceMappingURL=http.js.map

lib/socket/index.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.socket = void 0;
+exports.socket = socket;
 const feathers_1 = require("@feathersjs/feathers");
@@ -46,3 +46,2 @@ const channels_1 = require("../channels");
 }
-exports.socket = socket;
 //# sourceMappingURL=index.js.map

lib/socket/utils.js

@@ -6,3 +6,6 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.runMethod = exports.getDispatcher = exports.normalizeError = exports.paramsPositions = exports.DEFAULT_PARAMS_POSITION = void 0;
+exports.paramsPositions = exports.DEFAULT_PARAMS_POSITION = void 0;
+exports.normalizeError = normalizeError;
+exports.getDispatcher = getDispatcher;
+exports.runMethod = runMethod;
 const feathers_1 = require("@feathersjs/feathers");
@@ -33,3 +36,2 @@ const errors_1 = require("@feathersjs/errors");
 }
-exports.normalizeError = normalizeError;
 function getDispatcher(emit, socketMap, socketKey) {
@@ -55,3 +57,2 @@ return function (event, channel, context, data) {
 }
-exports.getDispatcher = getDispatcher;
 async function runMethod(app, connection, _path, _method, args) {
@@ -101,3 +102,2 @@ const path = typeof _path === 'string' ? _path : null;
 }
-exports.runMethod = runMethod;
 //# sourceMappingURL=utils.js.map

package.json

 {
   "name": "@feathersjs/transport-commons",
   "description": "Shared functionality for websocket providers",
-  "version": "5.0.27",
+  "version": "5.0.28",
   "homepage": "https://feathersjs.com",
@@ -57,5 +57,5 @@ "main": "lib/",
   "dependencies": {
-    "@feathersjs/commons": "^5.0.27",
-    "@feathersjs/errors": "^5.0.27",
-    "@feathersjs/feathers": "^5.0.27",
+    "@feathersjs/commons": "^5.0.28",
+    "@feathersjs/errors": "^5.0.28",
+    "@feathersjs/feathers": "^5.0.28",
     "encodeurl": "^2.0.0",
@@ -66,11 +66,11 @@ "lodash": "^4.17.21"
     "@types/encodeurl": "^1.0.2",
-    "@types/lodash": "^4.17.0",
-    "@types/mocha": "^10.0.6",
-    "@types/node": "^20.12.8",
-    "mocha": "^10.4.0",
+    "@types/lodash": "^4.17.6",
+    "@types/mocha": "^10.0.7",
+    "@types/node": "^20.14.10",
+    "mocha": "^10.6.0",
     "shx": "^0.3.4",
     "ts-node": "^10.9.2",
-    "typescript": "^5.4.5"
+    "typescript": "^5.5.3"
   },
-  "gitHead": "f6ff82535fa25432757c049f54302883c59e6bb6"
+  "gitHead": "410ba7db8f3348d208e34511827302133d727ba3"
 }

src/http.ts

@@ -65,6 +65,2 @@ import { MethodNotAllowed } from '@feathersjs/errors/lib'
 
-  if (context.method === 'create') {
-    return statusCodes.created
-  }
-
   if (location !== undefined) {
@@ -78,2 +74,6 @@ return statusCodes.seeOther
 
+  if (context.method === 'create') {
+    return statusCodes.created
+  }
+
   return statusCodes.success
@@ -80,0 +80,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

151530

increased by0.02%

Worsened metrics

Lines of code

1849

decreased by-0.16%

Dependency changes

• Updated@feathersjs/commons@^5.0.28

• Updated@feathersjs/errors@^5.0.28

• Updated@feathersjs/feathers@^5.0.28