@fluentui/react-aria - npm Package Compare versions

Comparing version 0.0.0-nightly0e0cf06c3420211029.1 to 0.0.0-nightlya372ad979820211103.1

CHANGELOG.json

@@ -5,5 +5,5 @@ {
     {
-      "date": "Fri, 29 Oct 2021 06:39:55 GMT",
-      "tag": "@fluentui/react-aria_v0.0.0-nightly0e0cf06c3420211029.1",
-      "version": "0.0.0-nightly0e0cf06c3420211029.1",
+      "date": "Wed, 03 Nov 2021 08:24:01 GMT",
+      "tag": "@fluentui/react-aria_v0.0.0-nightlya372ad979820211103.1",
+      "version": "0.0.0-nightlya372ad979820211103.1",
       "comments": {
@@ -14,10 +14,16 @@ "prerelease": [
             "package": "@fluentui/react-aria",
-            "commit": "3535f78f7af73f13f2c1e7470293fb5e592866de",
+            "commit": "ff9c0a60767a2dbd1afdc71659a5daee5f2068dd",
             "comment": "Release nightly v9"
           },
           {
+            "author": "[e-mail]",
+            "package": "@fluentui/react-aria",
+            "commit": "a4ea9b6227d2f634f85b40fe4cec10e4c391244b",
+            "comment": "Fixing events being fired when button is disabledFocusable"
+          },
+          {
             "author": "beachball",
             "package": "@fluentui/react-aria",
-            "comment": "Bump @fluentui/keyboard-keys to v0.0.0-nightly0e0cf06c3420211029.1",
-            "commit": "3535f78f7af73f13f2c1e7470293fb5e592866de"
+            "comment": "Bump @fluentui/keyboard-keys to v0.0.0-nightlya372ad979820211103.1",
+            "commit": "ff9c0a60767a2dbd1afdc71659a5daee5f2068dd"
           },
@@ -27,4 +33,4 @@ {
             "package": "@fluentui/react-aria",
-            "comment": "Bump @fluentui/react-make-styles to v0.0.0-nightly0e0cf06c3420211029.1",
-            "commit": "3535f78f7af73f13f2c1e7470293fb5e592866de"
+            "comment": "Bump @fluentui/react-make-styles to v0.0.0-nightlya372ad979820211103.1",
+            "commit": "ff9c0a60767a2dbd1afdc71659a5daee5f2068dd"
           },
@@ -34,4 +40,4 @@ {
             "package": "@fluentui/react-aria",
-            "comment": "Bump @fluentui/react-utilities to v0.0.0-nightly0e0cf06c3420211029.1",
-            "commit": "3535f78f7af73f13f2c1e7470293fb5e592866de"
+            "comment": "Bump @fluentui/react-utilities to v0.0.0-nightlya372ad979820211103.1",
+            "commit": "ff9c0a60767a2dbd1afdc71659a5daee5f2068dd"
           },
@@ -41,4 +47,4 @@ {
             "package": "@fluentui/react-aria",
-            "comment": "Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightly0e0cf06c3420211029.1",
-            "commit": "3535f78f7af73f13f2c1e7470293fb5e592866de"
+            "comment": "Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightlya372ad979820211103.1",
+            "commit": "ff9c0a60767a2dbd1afdc71659a5daee5f2068dd"
           }
@@ -45,0 +51,0 @@ ]

CHANGELOG.md

 # Change Log - @fluentui/react-aria
 
-This log was last generated on Fri, 29 Oct 2021 06:39:55 GMT and should not be manually modified.
+This log was last generated on Wed, 03 Nov 2021 08:24:01 GMT and should not be manually modified.
 
 <!-- Start content -->
 
-## [0.0.0-nightly0e0cf06c3420211029.1](https://github.com/microsoft/fluentui/tree/@fluentui/react-aria_v0.0.0-nightly0e0cf06c3420211029.1)
+## [0.0.0-nightlya372ad979820211103.1](https://github.com/microsoft/fluentui/tree/@fluentui/react-aria_v0.0.0-nightlya372ad979820211103.1)
 
-Fri, 29 Oct 2021 06:39:55 GMT 
-[Compare changes](https://github.com/microsoft/fluentui/compare/@fluentui/react-aria_v9.0.0-beta.2..@fluentui/react-aria_v0.0.0-nightly0e0cf06c3420211029.1)
+Wed, 03 Nov 2021 08:24:01 GMT 
+[Compare changes](https://github.com/microsoft/fluentui/compare/@fluentui/react-aria_v9.0.0-beta.2..@fluentui/react-aria_v0.0.0-nightlya372ad979820211103.1)
 
 ### Changes
 
-- Release nightly v9 ([commit](https://github.com/microsoft/fluentui/commit/3535f78f7af73f13f2c1e7470293fb5e592866de) by email not defined)
-- Bump @fluentui/keyboard-keys to v0.0.0-nightly0e0cf06c3420211029.1 ([commit](https://github.com/microsoft/fluentui/commit/3535f78f7af73f13f2c1e7470293fb5e592866de) by beachball)
-- Bump @fluentui/react-make-styles to v0.0.0-nightly0e0cf06c3420211029.1 ([commit](https://github.com/microsoft/fluentui/commit/3535f78f7af73f13f2c1e7470293fb5e592866de) by beachball)
-- Bump @fluentui/react-utilities to v0.0.0-nightly0e0cf06c3420211029.1 ([commit](https://github.com/microsoft/fluentui/commit/3535f78f7af73f13f2c1e7470293fb5e592866de) by beachball)
-- Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightly0e0cf06c3420211029.1 ([commit](https://github.com/microsoft/fluentui/commit/3535f78f7af73f13f2c1e7470293fb5e592866de) by beachball)
+- Release nightly v9 ([commit](https://github.com/microsoft/fluentui/commit/ff9c0a60767a2dbd1afdc71659a5daee5f2068dd) by email not defined)
+- Fixing events being fired when button is disabledFocusable ([PR #20342](https://github.com/microsoft/fluentui/pull/20342) by [e-mail])
+- Bump @fluentui/keyboard-keys to v0.0.0-nightlya372ad979820211103.1 ([commit](https://github.com/microsoft/fluentui/commit/ff9c0a60767a2dbd1afdc71659a5daee5f2068dd) by beachball)
+- Bump @fluentui/react-make-styles to v0.0.0-nightlya372ad979820211103.1 ([commit](https://github.com/microsoft/fluentui/commit/ff9c0a60767a2dbd1afdc71659a5daee5f2068dd) by beachball)
+- Bump @fluentui/react-utilities to v0.0.0-nightlya372ad979820211103.1 ([commit](https://github.com/microsoft/fluentui/commit/ff9c0a60767a2dbd1afdc71659a5daee5f2068dd) by beachball)
+- Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightlya372ad979820211103.1 ([commit](https://github.com/microsoft/fluentui/commit/ff9c0a60767a2dbd1afdc71659a5daee5f2068dd) by beachball)
 
@@ -20,0 +21,0 @@ ## [9.0.0-beta.2](https://github.com/microsoft/fluentui/tree/@fluentui/react-aria_v9.0.0-beta.2)

lib-commonjs/hooks/useARIAButton.js

@@ -88,8 +88,14 @@ "use strict";
       shorthandProps.disabled = disabled && !disabledFocusable;
-      shorthandProps['aria-disabled'] = disabledFocusable;
-    } // If an <a> tag is to be rendered we have to remove disabled and set aria-disabled, role and tabIndex as well as
-    // some event handlers.
+      shorthandProps['aria-disabled'] = disabledFocusable; // Undefine events if disabledFocusable is passed in
+
+      if (disabledFocusable) {
+        shorthandProps.onClick = undefined;
+        shorthandProps.onKeyDown = undefined;
+        shorthandProps.onKeyUp = undefined;
+      }
+    } // If an <a> tag is to be rendered we have to remove disabled and type, and set aria-disabled, role and tabIndex.
     else {
       delete shorthandProps.disabled;
       shorthandProps['aria-disabled'] = disabled || disabledFocusable;
+      shorthandProps.href = disabled ? undefined : shorthandProps.href;
       shorthandProps.onClick = onClickHandler;
@@ -96,0 +102,0 @@ shorthandProps.onKeyDown = onKeyDownHandler;

lib/hooks/useARIAButton.js

@@ -79,8 +79,14 @@ import { Enter, Space } from '@fluentui/keyboard-keys';
       shorthandProps.disabled = disabled && !disabledFocusable;
-      shorthandProps['aria-disabled'] = disabledFocusable;
-    } // If an <a> tag is to be rendered we have to remove disabled and set aria-disabled, role and tabIndex as well as
-    // some event handlers.
+      shorthandProps['aria-disabled'] = disabledFocusable; // Undefine events if disabledFocusable is passed in
+
+      if (disabledFocusable) {
+        shorthandProps.onClick = undefined;
+        shorthandProps.onKeyDown = undefined;
+        shorthandProps.onKeyUp = undefined;
+      }
+    } // If an <a> tag is to be rendered we have to remove disabled and type, and set aria-disabled, role and tabIndex.
     else {
       delete shorthandProps.disabled;
       shorthandProps['aria-disabled'] = disabled || disabledFocusable;
+      shorthandProps.href = disabled ? undefined : shorthandProps.href;
       shorthandProps.onClick = onClickHandler;
@@ -87,0 +93,0 @@ shorthandProps.onKeyDown = onKeyDownHandler;

package.json

 {
   "name": "@fluentui/react-aria",
-  "version": "0.0.0-nightly0e0cf06c3420211029.1",
+  "version": "0.0.0-nightlya372ad979820211103.1",
   "description": "React helper to ensure ARIA",
@@ -28,3 +28,3 @@ "main": "lib-commonjs/index.js",
     "@fluentui/eslint-plugin": "*",
-    "@fluentui/jest-serializer-make-styles": "0.0.0-nightly0e0cf06c3420211029.1",
+    "@fluentui/jest-serializer-make-styles": "0.0.0-nightlya372ad979820211103.1",
     "@fluentui/react-conformance": "*",
@@ -44,5 +44,5 @@ "@fluentui/scripts": "^1.0.0",
   "dependencies": {
-    "@fluentui/keyboard-keys": "0.0.0-nightly0e0cf06c3420211029.1",
-    "@fluentui/react-make-styles": "0.0.0-nightly0e0cf06c3420211029.1",
-    "@fluentui/react-utilities": "0.0.0-nightly0e0cf06c3420211029.1",
+    "@fluentui/keyboard-keys": "0.0.0-nightlya372ad979820211103.1",
+    "@fluentui/react-make-styles": "0.0.0-nightlya372ad979820211103.1",
+    "@fluentui/react-utilities": "0.0.0-nightlya372ad979820211103.1",
     "tslib": "^2.1.0"
@@ -49,0 +49,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

91222

increased by1.58%

Lines of code

1441

increased by1.12%

Dependency changes

• + Added@fluentui/keyboard-keys@0.0.0-nightlya372ad979820211103.1(transitive)

• + Added@fluentui/make-styles@0.0.0-nightlya372ad979820211103.1(transitive)

• + Added@fluentui/react-make-styles@0.0.0-nightlya372ad979820211103.1(transitive)

• + Added@fluentui/react-shared-contexts@0.0.0-nightlya372ad979820211103.1(transitive)

• + Added@fluentui/react-theme@0.0.0-nightlya372ad979820211103.1(transitive)

• + Added@fluentui/react-utilities@0.0.0-nightlya372ad979820211103.1(transitive)

• - Removed@fluentui/keyboard-keys@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• - Removed@fluentui/make-styles@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• - Removed@fluentui/react-make-styles@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• - Removed@fluentui/react-shared-contexts@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• - Removed@fluentui/react-theme@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• - Removed@fluentui/react-utilities@0.0.0-nightly0e0cf06c3420211029.1(transitive)

• Updated@fluentui/keyboard-keys@0.0.0-nightlya372ad979820211103.1

• Updated@fluentui/react-make-styles@0.0.0-nightlya372ad979820211103.1

• Updated@fluentui/react-utilities@0.0.0-nightlya372ad979820211103.1