@furystack/http-api - npm Package Compare versions

Comparing version 0.2.11 to 0.2.12

dist/Actions/GetCurrentUser.js

@@ -10,11 +10,2 @@ "use strict";
 };
-var __rest = (this && this.__rest) || function (s, e) {
-    var t = {};
-    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
-        t[p] = s[p];
-    if (s != null && typeof Object.getOwnPropertySymbols === "function")
-        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) if (e.indexOf(p[i]) < 0)
-            t[p[i]] = s[p[i]];
-    return t;
-};
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -30,7 +21,7 @@ const RequestAction_1 = require("../RequestAction");
             const user = yield getContext().getCurrentUser();
-            const { Password } = user, userWithoutPassword = __rest(user, ["Password"]);
+            delete user.Password;
             serverResponse.writeHead(200, {
                 "Content-Type": "application/json",
             });
-            serverResponse.end(JSON.stringify(userWithoutPassword));
+            serverResponse.end(JSON.stringify(user));
         });
@@ -37,0 +28,0 @@ }

dist/IdentityService.d.ts

@@ -21,3 +21,3 @@ /// <reference types="node" />
     cookieLogin(username: string, password: string, serverResponse: ServerResponse): Promise<TUser>;
-    externalLogin<T extends IExternalLoginService<TUser, TArgs>, TArgs extends any[]>(service: Constructable<T>, ...args: TArgs): Promise<TUser>;
+    externalLogin<T extends IExternalLoginService<TUser, TArgs>, TArgs extends any[]>(service: Constructable<T>, serverResponse: ServerResponse, ...args: TArgs): Promise<TUser>;
     cookieLogout(req: IncomingMessage, serverResponse: ServerResponse): Promise<void>;
@@ -24,0 +24,0 @@ readonly options: IIdentityServiceOptions<TUser>;

dist/IdentityService.js

@@ -81,3 +81,3 @@ "use strict";
     }
-    externalLogin(service, ...args) {
+    externalLogin(service, serverResponse, ...args) {
         return __awaiter(this, void 0, void 0, function* () {
@@ -90,2 +90,3 @@ try {
                     this.sessions.set(sessionId, user.Id);
+                    serverResponse.setHeader("Set-Cookie", `${this.options.cookieName}=${sessionId}; Path=/; Secure; HttpOnly`);
                     return user;
@@ -92,0 +93,0 @@ }

package.json

 {
   "name": "@furystack/http-api",
-  "version": "0.2.11",
+  "version": "0.2.12",
   "description": "HTTP Api FuryStack package",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/Actions/GetCurrentUser.ts

@@ -9,9 +9,9 @@ import { IContext, IUser } from "@furystack/core";
         const user = await getContext().getCurrentUser() as ILoginUser<IUser>;
-        const { Password, ...userWithoutPassword } = user;
+        delete user.Password;
         serverResponse.writeHead(200, {
             "Content-Type": "application/json",
         });
-        serverResponse.end(JSON.stringify(userWithoutPassword));
+        serverResponse.end(JSON.stringify(user));
     }
     public segmentName: string = "getCurrentUser";
 }

src/IdentityService.ts

@@ -73,3 +73,3 @@ import { Constructable, InMemoryStore, IPhysicalStore, IUser, LoggerCollection, visitorUser } from "@furystack/core";
 
-    public async externalLogin<T extends IExternalLoginService<TUser, TArgs>, TArgs extends any[]>(service: Constructable<T>, ...args: TArgs): Promise<TUser> {
+    public async externalLogin<T extends IExternalLoginService<TUser, TArgs>, TArgs extends any[]>(service: Constructable<T>, serverResponse: ServerResponse, ...args: TArgs): Promise<TUser> {
         try {
@@ -81,2 +81,3 @@ const instance = this.options.injector.GetInstance(service);
                 this.sessions.set(sessionId, user.Id);
+                serverResponse.setHeader("Set-Cookie", `${this.options.cookieName}=${sessionId}; Path=/; Secure; HttpOnly`);
                 return user;
@@ -83,0 +84,0 @@ }

src/Models/IExternalLoginService.ts

 import { IUser } from "@furystack/core";
+import { ServerResponse } from "http";
 import { IdentityService, ILoginUser } from "..";
@@ -3,0 +4,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

116846

decreased by-0.07%

Lines of code

1647

decreased by-0.36%

No dependency changes