@gearbox-protocol/devops - npm Package Compare versions

Comparing version 0.0.8 to 0.0.9

lib/verifier/verifierDeployer.js

@@ -113,18 +113,4 @@ "use strict";
         // Overwriting info for now
-        var exisitingIndex = -1;
-        this.verifier.filter(function (request, index) {
-            if (request.address == c.address) {
-                exisitingIndex = index;
-                return [request];
-            }
-            else {
-                return [];
-            }
-        }, []);
-        if (exisitingIndex > -1) {
-            this.verifier[exisitingIndex] = c;
-        }
-        else {
-            this.verifier.push(c);
-        }
+        this.verifier = this.verifier.filter(function (request) { return request.address.toLowerCase() !== c.address.toLowerCase(); });
+        this.verifier.push(c);
         this._saveVerifier();
@@ -134,8 +120,8 @@ };
         switch (networkName) {
-            case 'mainnet':
+            case "mainnet":
                 return "https://api.etherscan.io";
-            case 'kovan':
+            case "kovan":
                 return "https://api-kovan.etherscan.io";
             default:
-                return "https://api.etherscan.io";
+                throw new Error("".concat(networkName, " is not supported"));
         }
@@ -155,3 +141,3 @@ };
                         isVerified = _a.sent();
-                        return [2 /*return*/, isVerified.data && isVerified.data.status === '1'];
+                        return [2 /*return*/, isVerified.data && isVerified.data.status === "1"];
                 }
@@ -163,3 +149,3 @@ });
         return __awaiter(this, void 0, void 0, function () {
-            var i, params, isVerified;
+            var params, isVerified;
             return __generator(this, function (_a) {
@@ -169,6 +155,5 @@ switch (_a.label) {
                         this.enableLogs();
-                        i = 0;
                         _a.label = 1;
                     case 1:
-                        if (!(i < this.verifier.length)) return [3 /*break*/, 7];
+                        if (!(this.verifier.length > 0)) return [3 /*break*/, 6];
                         params = this.verifier.shift();
@@ -189,7 +174,4 @@ return [4 /*yield*/, this.isVerified(params === null || params === void 0 ? void 0 : params.address)];
                         this._saveVerifier();
-                        _a.label = 6;
-                    case 6:
-                        i++;
                         return [3 /*break*/, 1];
-                    case 7: return [2 /*return*/];
+                    case 6: return [2 /*return*/];
                 }
@@ -196,0 +178,0 @@ });

package.json

 {
   "name": "@gearbox-protocol/devops",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "description": "Gearbox Devops for SC development",
@@ -5,0 +5,0 @@ "main": "./lib/index.js",

src/verifier/verifierDeployer.ts

@@ -9,3 +9,3 @@ /*
 import path from "path";
-import hre from 'hardhat';
+import hre from "hardhat";
 
@@ -25,11 +25,13 @@ dotEnvConfig({ path: ".env" });
 
-
   constructor() {
     super();
-    const networkName = hre.network.name
-    this.VERIFIER_FILE = path.join(process.cwd(), `./.verifier.${networkName}.json`);
+    const networkName = hre.network.name;
+    this.VERIFIER_FILE = path.join(
+      process.cwd(),
+      `./.verifier.${networkName}.json`
+    );
     try {
-    this.verifier = require(this.VERIFIER_FILE);
-    } catch  {
-      console.log(`Cant find ${this.VERIFIER_FILE}, started from scratch`)
+      this.verifier = require(this.VERIFIER_FILE);
+    } catch {
+      console.log(`Cant find ${this.VERIFIER_FILE}, started from scratch`);
     }
@@ -41,43 +43,35 @@ this.apiKey = process.env.ETHERSCAN_API_KEY || "";
   addContract(c: VerifyRequest) {
-
     // Add logic to check if address is already exists
     // Overwriting info for now
-    let exisitingIndex = -1;
-    this.verifier.filter((request, index) => {
-      if(request.address == c.address){
-        exisitingIndex = index
-        return [request]
-      }else{
-        return []
-      }
-    },[]);
 
-    if(exisitingIndex > -1){
-      this.verifier[exisitingIndex] = c
-    }else{
-      this.verifier.push(c);
-    }
+    this.verifier = this.verifier.filter(
+      request => request.address.toLowerCase() !== c.address.toLowerCase()
+    );
 
+    this.verifier.push(c);
+
     this._saveVerifier();
   }
 
-  baseUrl(networkName: string) : String {
-    switch(networkName){
-      case 'mainnet':
+  baseUrl(networkName: string): String {
+    switch (networkName) {
+      case "mainnet":
         return "https://api.etherscan.io";
-      case 'kovan':
+      case "kovan":
         return "https://api-kovan.etherscan.io";
       default:
-        return "https://api.etherscan.io";
+        throw new Error(`${networkName} is not supported`);
     }
   }
-  
 
-  async isVerified(address: string | undefined) : Promise<boolean> {
-
-    const networkName = await hre.network.name
-    const url = `${this.baseUrl(networkName)}/api?module=contract&action=getabi&address=${address}&apikey=${this.apiKey}`;
+  async isVerified(address: string | undefined): Promise<boolean> {
+    const networkName = await hre.network.name;
+    const url = `${this.baseUrl(
+      networkName
+    )}/api?module=contract&action=getabi&address=${address}&apikey=${
+      this.apiKey
+    }`;
     const isVerified = await axios.get(url);
-    return isVerified.data && isVerified.data.status === '1';
-  } 
+    return isVerified.data && isVerified.data.status === "1";
+  }
 
@@ -87,3 +81,3 @@ async deploy() {
 
-    for (let i = 0; i < this.verifier.length; i++) {
+    while (this.verifier.length > 0) {
       const params = this.verifier.shift();
@@ -90,0 +84,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

46053

decreased by-1.14%

Lines of code

939

decreased by-2.19%

No dependency changes