@github/details-menu-element - npm Package Compare versions

Comparing version 0.9.0 to 0.10.0

dist/index.esm.js

@@ -189,5 +189,9 @@ class DetailsMenuElement extends HTMLElement {
   if (selected.hasAttribute('disabled') || selected.getAttribute('aria-disabled') === 'true') return;
-  const dispatched = selected.dispatchEvent(new CustomEvent('details-menu-select', {
-    bubbles: true,
-    cancelable: true
+  const menu = selected.closest('details-menu');
+  if (!menu) return;
+  const dispatched = menu.dispatchEvent(new CustomEvent('details-menu-select', {
+    cancelable: true,
+    detail: {
+      relatedTarget: selected
+    }
   }));
@@ -198,4 +202,6 @@ if (!dispatched) return;
   if (selected.getAttribute('role') !== 'menuitemcheckbox') close(details);
-  selected.dispatchEvent(new CustomEvent('details-menu-selected', {
-    bubbles: true
+  menu.dispatchEvent(new CustomEvent('details-menu-selected', {
+    detail: {
+      relatedTarget: selected
+    }
   }));
@@ -202,0 +208,0 @@ }

dist/index.umd.js

@@ -209,5 +209,9 @@ (function (global, factory) {
     if (selected.hasAttribute('disabled') || selected.getAttribute('aria-disabled') === 'true') return;
-    const dispatched = selected.dispatchEvent(new CustomEvent('details-menu-select', {
-      bubbles: true,
-      cancelable: true
+    const menu = selected.closest('details-menu');
+    if (!menu) return;
+    const dispatched = menu.dispatchEvent(new CustomEvent('details-menu-select', {
+      cancelable: true,
+      detail: {
+        relatedTarget: selected
+      }
     }));
@@ -218,4 +222,6 @@ if (!dispatched) return;
     if (selected.getAttribute('role') !== 'menuitemcheckbox') close(details);
-    selected.dispatchEvent(new CustomEvent('details-menu-selected', {
-      bubbles: true
+    menu.dispatchEvent(new CustomEvent('details-menu-selected', {
+      detail: {
+        relatedTarget: selected
+      }
     }));
@@ -222,0 +228,0 @@ }

package.json

 {
   "name": "@github/details-menu-element",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "description": "A menu opened with a <details> button.",
@@ -5,0 +5,0 @@ "main": "dist/index.umd.js",

README.md

@@ -62,4 +62,4 @@ # <details-menu> element
 
-- `details-menu-select` - An item is to be select (cancelable).
-- `details-menu-selected` - An item is selected, label updated, menu closed.
+- `details-menu-select` (cancelable) - fired on `<details-menu>` with `event.detail.relatedTarget` being the item to be selected.
+- `details-menu-selected` - fired on `<details-menu>` with `event.detail.relatedTarget` being the item selected, after label is updated and menu is closed.
 
@@ -66,0 +66,0 @@ ### Deferred loading

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25171

increased by1.66%

Lines of code

562

increased by2.18%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes