@github/details-menu-element - npm Package Compare versions

Comparing version 0.6.4 to 0.6.5

dist/index.esm.js

@@ -130,7 +130,7 @@ var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
 
-  var menuitem = event.type === 'click' ? target.closest('[role="menuitem"]') : target.closest('[role="menuitemradio"], [role="menuitemcheckbox"]');
+  var menuitem = event.type === 'change' ? target.closest('[role="menuitemradio"], [role="menuitemcheckbox"]') : target.closest('[role="menuitem"], [role="menuitemradio"]');
   if (menuitem) commit(menuitem, details);
 }
 
-function updateChecked(details) {
+function updateChecked(selected, details) {
   var _iteratorNormalCompletion2 = true;
@@ -145,4 +145,3 @@ var _didIteratorError2 = false;
       var input = el.querySelector('input[type="radio"], input[type="checkbox"]');
-      if (!(input instanceof HTMLInputElement)) continue;
-      el.setAttribute('aria-checked', input.checked.toString());
+      el.setAttribute('aria-checked', (input instanceof HTMLInputElement ? input.checked : el === selected).toString());
     }
@@ -172,3 +171,3 @@ } catch (err) {
   updateLabel(selected, details);
-  updateChecked(details);
+  updateChecked(selected, details);
   if (selected.getAttribute('role') !== 'menuitemcheckbox') close(details);
@@ -175,0 +174,0 @@ selected.dispatchEvent(new CustomEvent('details-menu-selected', { bubbles: true }));

dist/index.umd.js

@@ -189,7 +189,7 @@ (function (global, factory) {
 
-    var menuitem = event.type === 'click' ? target.closest('[role="menuitem"]') : target.closest('[role="menuitemradio"], [role="menuitemcheckbox"]');
+    var menuitem = event.type === 'change' ? target.closest('[role="menuitemradio"], [role="menuitemcheckbox"]') : target.closest('[role="menuitem"], [role="menuitemradio"]');
     if (menuitem) commit(menuitem, details);
   }
 
-  function updateChecked(details) {
+  function updateChecked(selected, details) {
     var _iteratorNormalCompletion2 = true;
@@ -204,4 +204,3 @@ var _didIteratorError2 = false;
         var input = el.querySelector('input[type="radio"], input[type="checkbox"]');
-        if (!(input instanceof HTMLInputElement)) continue;
-        el.setAttribute('aria-checked', input.checked.toString());
+        el.setAttribute('aria-checked', (input instanceof HTMLInputElement ? input.checked : el === selected).toString());
       }
@@ -231,3 +230,3 @@ } catch (err) {
     updateLabel(selected, details);
-    updateChecked(details);
+    updateChecked(selected, details);
     if (selected.getAttribute('role') !== 'menuitemcheckbox') close(details);
@@ -234,0 +233,0 @@ selected.dispatchEvent(new CustomEvent('details-menu-selected', { bubbles: true }));

package.json

 {
   "name": "@github/details-menu-element",
-  "version": "0.6.4",
+  "version": "0.6.5",
   "description": "A menu opened with a <details> button.",
@@ -5,0 +5,0 @@ "main": "dist/index.umd.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25433

increased by0.33%

Worsened metrics

Lines of code

517

decreased by-0.39%

No dependency changes