@gltf-transform/core - npm Package Compare versions

Comparing version 3.7.2 to 3.7.3

package.json

 {
 	"name": "@gltf-transform/core",
-	"version": "3.7.2",
+	"version": "3.7.3",
 	"repository": "github:donmccurdy/glTF-Transform",
@@ -55,3 +55,3 @@ "homepage": "https://gltf-transform.dev/",
 	},
-	"gitHead": "4bc686d4b1c3c4acfa3cc7fdffc7c2b563835d7a"
+	"gitHead": "8a8e6c1c1c86b261d1b99dda068c051b21a6cb50"
 }

src/io/node-io.ts

@@ -162,4 +162,6 @@ import { Format } from '../constants.js';
 			}
+			// TODO(v4): Consider storing decoded URIs in memory, and avoid decoding here. However,
+			// we'll need to think through implications for absolute URLs.
 			const resource = Buffer.from(resources[resourceURI]);
-			const resourcePath = path.join(dir, resourceURI);
+			const resourcePath = path.join(dir, decodeURIComponent(resourceURI));
 			await fs.mkdir(path.dirname(resourcePath), { recursive: true });
@@ -166,0 +168,0 @@ await fs.writeFile(resourcePath, resource);

src/io/platform-io.ts

@@ -191,5 +191,8 @@ import { Format, GLB_BUFFER, VertexLayout } from '../constants.js';
 
+				// TODO(v4): Perhaps the resources dictionary could have been keyed by decoded URIs
+				// like "my image.png" instead of "my%20image.png". But for now, we use the URIs
+				// verbatim as found in resource definition. Consider revisiting in v4.
 				jsonDoc.resources[uri] = await this.readURI(this.resolve(base, uri), 'view');
 				this.lastReadBytes += jsonDoc.resources[uri].byteLength;
-			}
+			},
 		);
@@ -196,0 +199,0 @@ await Promise.all(pendingResources);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1522442

increased by0.09%

Lines of code

11787

increased by0.04%

No dependency changes