@google-cloud/common - npm Package Compare versions

Comparing version 0.12.0 to 0.12.1

package.json

 {
   "name": "@google-cloud/common",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "author": "Google Inc.",
-  "description": "Common components for Google Cloud APIs Node.js Client Libraries",
+  "description": "Common components for Cloud APIs Node.js Client Libraries",
   "contributors": [
@@ -45,3 +45,2 @@ {
     "create-error-class": "^3.0.2",
-    "dot-prop": "^2.4.0",
     "duplexify": "^3.5.0",
@@ -51,3 +50,2 @@ "ent": "^2.2.0",
     "google-auto-auth": "^0.5.2",
-    "google-proto-files": "^0.8.6",
     "is": "^3.2.0",
@@ -67,3 +65,2 @@ "log-driver": "^1.2.5",
     "proxyquire": "^1.7.10",
-    "sinon": "^1.17.7",
     "uuid": "^3.0.1"
@@ -70,0 +67,0 @@ },

src/index.js

@@ -0,0 +0,0 @@ /*!

src/logger.js

@@ -0,0 +0,0 @@ /*!

src/operation.js

@@ -0,0 +0,0 @@ /*!

src/paginator.js

@@ -0,0 +0,0 @@ /*!

src/service-object.js

@@ -208,11 +208,27 @@ /*!
 
+  function onCreate(err, instance, apiResponse) {
+    if (err) {
+      if (err.code === 409) {
+        self.get(config, callback);
+        return;
+      }
+
+      callback(err, null, apiResponse);
+      return;
+    }
+
+    callback(null, instance, apiResponse);
+  }
+
   this.getMetadata(function(err, metadata) {
     if (err) {
       if (err.code === 404 && autoCreate) {
-        var args = [callback];
+        var args = [];
 
         if (!is.empty(config)) {
-          args.unshift(config);
+          args.push(config);
         }
 
+        args.push(onCreate);
+
         self.create.apply(self, args);
@@ -219,0 +235,0 @@ return;

src/service.js

@@ -0,0 +0,0 @@ /*!

src/util.js

@@ -46,3 +46,3 @@ /**
 var errorMessage = format([
-  'Sorry, we cannot connect to Google Cloud Services without a project ID.',
+  'Sorry, we cannot connect to Cloud Services without a project ID.',
   'You may specify one with an environment variable named "GCLOUD_PROJECT".',
@@ -522,3 +522,5 @@ 'See {baseUrl}/{path} for a detailed guide on creating an authenticated',
     for (var opt in value) {
-      value[opt] = replaceProjectIdToken(value[opt], projectId);
+      if (value.hasOwnProperty(opt)) {
+        value[opt] = replaceProjectIdToken(value[opt], projectId);
+      }
     }
@@ -525,0 +527,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

68719

increased by3.55%

Dependency count

18

decreased by-10%

Dev dependency count

3

decreased by-25%

Lines of code

1584

increased by0.89%

Dependency changes

• - Removeddot-prop@^2.4.0

• - Removedgoogle-proto-files@^0.8.6

• - Removeddot-prop@2.4.0(transitive)

• - Removedgoogle-proto-files@0.8.6(transitive)

• - Removedis-obj@1.0.1(transitive)