@grath/ebay-ts-sdk - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

ebay/ebay.ts

@@ -67,11 +67,15 @@ import * as request from 'request-promise';
     let convertedResponse: any;
+    try {
+      if(this.params.apiType === 'XML') {
+        convert.parseString(response, (err, result) => {
+          if (err) throw err;
+          convertedResponse = result;
+        });
+      } else {
+        convertedResponse = response;
+      }
+    } catch (error) {
+      throw error;
+    }
 
-    if(this.params.apiType === 'XML') {
-      convert.parseString(response, (err, result) => {
-        convertedResponse = result;
-      });
-    } else {
-      convertedResponse = response;
-    }
- 
     return convertedResponse;
@@ -78,0 +82,0 @@ }

ebay/helpers/generateXml.ts

@@ -38,3 +38,3 @@ /**
   return `<?xml version="1.0" encoding="utf-8"?>
-  <${params.callName} xmlns="urn:ebay:apis:eBLBaseComponents">
+  <${params.callName}Request xmlns="urn:ebay:apis:eBLBaseComponents">
     <RequesterCredentials>
@@ -44,3 +44,3 @@ <eBayAuthToken>${params.auth.token}</eBayAuthToken>
     ${body}
-  </${params.callName}>
+  </${params.callName}Request>
   `;
@@ -47,0 +47,0 @@ };

ebay/index.ts

@@ -1,1 +0,7 @@
-exports.Trading = require('./trading');
+import * as Trading from './trading';
+import * as Ebay from './ebay';
+
+export {
+  Trading,
+  Ebay,
+};

ebay/trading/getAccount.ts

@@ -11,5 +11,5 @@ import { Ebay } from '../ebay';
   AccountHistorySelection: string;
-  BeginDate: string;
+  BeginDate?: string;
   Currency?: string;
-  EndDate: string;
+  EndDate?: string;
   ExcludeBalance?: boolean;
@@ -16,0 +16,0 @@ ExcludeSummary?: boolean;

ebay/trading/index.ts

@@ -1,1 +0,5 @@
-exports.GetAccount = require('./getAccount');
+import * as GetAccount from './getAccount';
+
+export {
+  GetAccount
+}

package.json

@@ -11,3 +11,3 @@ {
   "description": "TypeScript sdk to work with ebay API calls",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "main": "./build/index.js",
@@ -14,0 +14,0 @@ "devDependencies": {},

tsconfig.json

@@ -8,3 +8,3 @@ {
         "sourceMap": true,
-        "lib": ["es2015"],
+        "lib": ["es6"],
         "forceConsistentCasingInFileNames": true,
@@ -14,3 +14,4 @@ "noImplicitReturns": true,
         "noUnusedLocals": true,
-        "outDir": "./build"
+        "outDir": "./build",
+        "declaration": true,
     },
@@ -17,0 +18,0 @@ "include": [

No alert changes

Worsened metrics

Total package byte prevSize

12312

decreased by-60.37%

Number of package files

12

decreased by-57.14%

Lines of code

191

decreased by-48.66%

No dependency changes