@grpc/grpc-js - npm Package Compare versions

Comparing version 1.5.2 to 1.5.3

build/src/load-balancer-pick-first.js

@@ -351,5 +351,9 @@ "use strict";
         if (this.currentPick !== null) {
-            this.currentPick.unref();
-            this.currentPick.removeConnectivityStateListener(this.pickedSubchannelStateListener);
-            this.channelControlHelper.removeChannelzChild(this.currentPick.getChannelzRef());
+            /* Unref can cause a state change, which can cause a change in the value
+             * of this.currentPick, so we hold a local reference to make sure that
+             * does not impact this function. */
+            const currentPick = this.currentPick;
+            currentPick.unref();
+            currentPick.removeConnectivityStateListener(this.pickedSubchannelStateListener);
+            this.channelControlHelper.removeChannelzChild(currentPick.getChannelzRef());
         }
@@ -356,0 +360,0 @@ }

package.json

 {
   "name": "@grpc/grpc-js",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "description": "gRPC Library for Node - pure JS implementation",
@@ -5,0 +5,0 @@ "homepage": "https://grpc.io/",

src/load-balancer-pick-first.ts

@@ -452,7 +452,11 @@ /*
     if (this.currentPick !== null) {
-      this.currentPick.unref();
-      this.currentPick.removeConnectivityStateListener(
+      /* Unref can cause a state change, which can cause a change in the value
+       * of this.currentPick, so we hold a local reference to make sure that
+       * does not impact this function. */
+      const currentPick = this.currentPick;
+      currentPick.unref();
+      currentPick.removeConnectivityStateListener(
         this.pickedSubchannelStateListener
       );
-      this.channelControlHelper.removeChannelzChild(this.currentPick.getChannelzRef());
+      this.channelControlHelper.removeChannelzChild(currentPick.getChannelzRef());
     }
@@ -459,0 +463,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1364369

increased by0.04%

Lines of code

27643

increased by0.03%

No dependency changes