@grpc/grpc-js - npm Package Compare versions

Comparing version 1.8.19 to 1.8.20

build/src/transport.js

@@ -82,2 +82,9 @@ "use strict";
         this.lastMessageReceivedTimestamp = null;
+        /* Populate subchannelAddressString and channelzRef before doing anything
+         * else, because they are used in the trace methods. */
+        this.subchannelAddressString = (0, subchannel_address_1.subchannelAddressToString)(subchannelAddress);
+        if (options['grpc.enable_channelz'] === 0) {
+            this.channelzEnabled = false;
+        }
+        this.channelzRef = (0, channelz_1.registerChannelzSocket)(this.subchannelAddressString, () => this.getChannelzInfo(), this.channelzEnabled);
         // Build user-agent string.
@@ -104,10 +111,2 @@ this.userAgent = [
         }
-        if (this.keepaliveWithoutCalls) {
-            this.maybeStartKeepalivePingTimer();
-        }
-        this.subchannelAddressString = (0, subchannel_address_1.subchannelAddressToString)(subchannelAddress);
-        if (options['grpc.enable_channelz'] === 0) {
-            this.channelzEnabled = false;
-        }
-        this.channelzRef = (0, channelz_1.registerChannelzSocket)(this.subchannelAddressString, () => this.getChannelzInfo(), this.channelzEnabled);
         session.once('close', () => {
@@ -150,2 +149,7 @@ this.trace('session closed');
         }
+        /* Start the keepalive timer last, because this can trigger trace logs,
+         * which should only happen after everything else is set up. */
+        if (this.keepaliveWithoutCalls) {
+            this.maybeStartKeepalivePingTimer();
+        }
     }
@@ -152,0 +156,0 @@ getChannelzInfo() {

package.json

 {
   "name": "@grpc/grpc-js",
-  "version": "1.8.19",
+  "version": "1.8.20",
   "description": "gRPC Library for Node - pure JS implementation",
@@ -5,0 +5,0 @@ "homepage": "https://grpc.io/",

src/transport.ts

@@ -129,2 +129,10 @@ /*
   ) {
+    /* Populate subchannelAddressString and channelzRef before doing anything
+     * else, because they are used in the trace methods. */
+    this.subchannelAddressString = subchannelAddressToString(subchannelAddress);
+
+    if (options['grpc.enable_channelz'] === 0) {
+      this.channelzEnabled = false;
+    }
+    this.channelzRef = registerChannelzSocket(this.subchannelAddressString, () => this.getChannelzInfo(), this.channelzEnabled);
     // Build user-agent string.
@@ -151,13 +159,3 @@ this.userAgent = [
     }
-    if (this.keepaliveWithoutCalls) {
-      this.maybeStartKeepalivePingTimer();
-    }
 
-    this.subchannelAddressString = subchannelAddressToString(subchannelAddress);
-
-    if (options['grpc.enable_channelz'] === 0) {
-      this.channelzEnabled = false;
-    }
-    this.channelzRef = registerChannelzSocket(this.subchannelAddressString, () => this.getChannelzInfo(), this.channelzEnabled);
-
     session.once('close', () => {
@@ -210,2 +208,7 @@ this.trace('session closed');
     }
+    /* Start the keepalive timer last, because this can trigger trace logs,
+     * which should only happen after everything else is set up. */
+    if (this.keepaliveWithoutCalls) {
+      this.maybeStartKeepalivePingTimer();
+    }
   }
@@ -212,0 +215,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1634221

increased by0.04%

Lines of code

32613

increased by0.02%

No dependency changes