@grpc/grpc-js - npm Package Compare versions

Comparing version 1.8.5 to 1.8.6

build/src/subchannel-call.d.ts

@@ -6,3 +6,3 @@ /// <reference types="node" />
 import { InterceptingListener, MessageContext, StatusObject } from './call-interface';
-import { CallEventTracker } from './transport';
+import { CallEventTracker, Transport } from './transport';
 export interface SubchannelCall {
@@ -26,3 +26,3 @@ cancelWithStatus(status: Status, details: string): void;
     private readonly listener;
-    private readonly peerName;
+    private readonly transport;
     private readonly callId;
@@ -42,5 +42,4 @@ private decoder;
     private finalStatus;
-    private disconnectListener;
     private internalError;
-    constructor(http2Stream: http2.ClientHttp2Stream, callEventTracker: CallEventTracker, listener: SubchannelCallInterceptingListener, peerName: string, callId: number);
+    constructor(http2Stream: http2.ClientHttp2Stream, callEventTracker: CallEventTracker, listener: SubchannelCallInterceptingListener, transport: Transport, callId: number);
     onDisconnect(): void;
@@ -47,0 +46,0 @@ private outputStatus;

build/src/subchannel-call.js

@@ -44,7 +44,7 @@ "use strict";
 class Http2SubchannelCall {
-    constructor(http2Stream, callEventTracker, listener, peerName, callId) {
+    constructor(http2Stream, callEventTracker, listener, transport, callId) {
         this.http2Stream = http2Stream;
         this.callEventTracker = callEventTracker;
         this.listener = listener;
-        this.peerName = peerName;
+        this.transport = transport;
         this.callId = callId;
@@ -67,9 +67,2 @@ this.decoder = new stream_decoder_1.StreamDecoder();
         this.internalError = null;
-        this.disconnectListener = () => {
-            this.endCall({
-                code: constants_1.Status.UNAVAILABLE,
-                details: 'Connection dropped',
-                metadata: new metadata_1.Metadata(),
-            });
-        };
         http2Stream.on('response', (headers, flags) => {
@@ -403,3 +396,3 @@ let headersString = '';
     getPeer() {
-        return this.peerName;
+        return this.transport.getPeerName();
     }
@@ -406,0 +399,0 @@ getCallNumber() {

build/src/transport.d.ts

@@ -22,2 +22,3 @@ /// <reference types="node" />
     getChannelzRef(): SocketRef;
+    getPeerName(): string;
     createCall(metadata: Metadata, host: string, method: string, listener: SubchannelCallInterceptingListener, subchannelCallStatsTracker: Partial<CallEventTracker>): SubchannelCall;
@@ -101,2 +102,3 @@ addDisconnectListener(listener: TransportDisconnectListener): void;
     getChannelzRef(): SocketRef;
+    getPeerName(): string;
     shutdown(): void;
@@ -103,0 +105,0 @@ }

build/src/transport.js

@@ -383,3 +383,3 @@ "use strict";
         }
-        call = new subchannel_call_1.Http2SubchannelCall(http2Stream, eventTracker, listener, this.subchannelAddressString, (0, call_number_1.getNextCallNumber)());
+        call = new subchannel_call_1.Http2SubchannelCall(http2Stream, eventTracker, listener, this, (0, call_number_1.getNextCallNumber)());
         this.addActiveCall(call);
@@ -391,2 +391,5 @@ return call;
     }
+    getPeerName() {
+        return this.subchannelAddressString;
+    }
     shutdown() {
@@ -393,0 +396,0 @@ this.session.close();

package.json

 {
   "name": "@grpc/grpc-js",
-  "version": "1.8.5",
+  "version": "1.8.6",
   "description": "gRPC Library for Node - pure JS implementation",
@@ -5,0 +5,0 @@ "homepage": "https://grpc.io/",

src/subchannel-call.ts

@@ -29,3 +29,3 @@ /*
 import { InterceptingListener, MessageContext, StatusObject, WriteCallback } from './call-interface';
-import { CallEventTracker } from './transport';
+import { CallEventTracker, Transport } from './transport';
 
@@ -109,4 +109,2 @@ const TRACER_NAME = 'subchannel_call';
 
-  private disconnectListener: () => void;
-
   private internalError: SystemError | null = null;
@@ -118,12 +116,5 @@
     private readonly listener: SubchannelCallInterceptingListener,
-    private readonly peerName: string,
+    private readonly transport: Transport,
     private readonly callId: number
   ) {
-    this.disconnectListener = () => {
-      this.endCall({
-        code: Status.UNAVAILABLE,
-        details: 'Connection dropped',
-        metadata: new Metadata(),
-      });
-    };
     http2Stream.on('response', (headers, flags) => {
@@ -481,3 +472,3 @@ let headersString = '';
   getPeer(): string {
-    return this.peerName;
+    return this.transport.getPeerName();
   }
@@ -484,0 +475,0 @@

src/transport.ts

@@ -68,2 +68,3 @@ /*
   getChannelzRef(): SocketRef;
+  getPeerName(): string;
   createCall(metadata: Metadata, host: string, method: string, listener: SubchannelCallInterceptingListener, subchannelCallStatsTracker: Partial<CallEventTracker>): SubchannelCall;
@@ -452,3 +453,3 @@ addDisconnectListener(listener: TransportDisconnectListener): void;
     }
-    call = new Http2SubchannelCall(http2Stream, eventTracker, listener, this.subchannelAddressString, getNextCallNumber());
+    call = new Http2SubchannelCall(http2Stream, eventTracker, listener, this, getNextCallNumber());
     this.addActiveCall(call);
@@ -462,2 +463,6 @@ return call;
 
+  getPeerName() {
+    return this.subchannelAddressString;
+  }
+
   shutdown() {
@@ -464,0 +469,0 @@ this.session.close();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

1683288

decreased by-0.02%

Lines of code

33312

decreased by-0.02%

No dependency changes