@hig/modal - npm Package Compare versions

Comparing version 2.2.1 to 2.2.2

build/index.es.js

@@ -209,3 +209,3 @@ import { keyframes, css, cx } from 'emotion';
                 onClick: onCloseClick,
-                title: "Close"
+                title: closeButtonAriaLabel
               })
@@ -250,3 +250,3 @@ )
 ModalHeaderPresenter.defaultProps = {
-  closeButtonAriaLabel: "close"
+  closeButtonAriaLabel: "Close"
 };
@@ -271,3 +271,3 @@ ModalHeaderPresenter.__docgenInfo = {
       "defaultValue": {
-        "value": "\"close\"",
+        "value": "\"Close\"",
         "computed": false
@@ -452,3 +452,3 @@ }
    * ARIA label attribute for the close button if/when headerChildren
-   * are not utilized
+   * are not utilized, also used for the title attribute
    */
@@ -508,3 +508,3 @@ closeButtonAriaLabel: PropTypes.string,
       "required": false,
-      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized"
+      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized, also used for the title attribute"
     },
@@ -765,3 +765,3 @@ "headerChildren": {
    * ARIA label attribute for the close button if/when headerChildren
-   * are not utilized
+   * are not utilized, also used for the title attribute
    */
@@ -798,2 +798,5 @@ closeButtonAriaLabel: PropTypes.string,
 };
+Modal.defaultProps = {
+  closeButtonAriaLabel: "Close"
+};
 Modal.__docgenInfo = {
@@ -815,3 +818,7 @@ "description": "",
       "required": false,
-      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized"
+      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized, also used for the title attribute",
+      "defaultValue": {
+        "value": "\"Close\"",
+        "computed": false
+      }
     },
@@ -818,0 +825,0 @@ "headerChildren": {

build/index.js

@@ -216,3 +216,3 @@ 'use strict';
                 onClick: onCloseClick,
-                title: "Close"
+                title: closeButtonAriaLabel
               })
@@ -257,3 +257,3 @@ )
 ModalHeaderPresenter.defaultProps = {
-  closeButtonAriaLabel: "close"
+  closeButtonAriaLabel: "Close"
 };
@@ -278,3 +278,3 @@ ModalHeaderPresenter.__docgenInfo = {
       "defaultValue": {
-        "value": "\"close\"",
+        "value": "\"Close\"",
         "computed": false
@@ -459,3 +459,3 @@ }
    * ARIA label attribute for the close button if/when headerChildren
-   * are not utilized
+   * are not utilized, also used for the title attribute
    */
@@ -515,3 +515,3 @@ closeButtonAriaLabel: PropTypes.string,
       "required": false,
-      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized"
+      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized, also used for the title attribute"
     },
@@ -772,3 +772,3 @@ "headerChildren": {
    * ARIA label attribute for the close button if/when headerChildren
-   * are not utilized
+   * are not utilized, also used for the title attribute
    */
@@ -805,2 +805,5 @@ closeButtonAriaLabel: PropTypes.string,
 };
+Modal.defaultProps = {
+  closeButtonAriaLabel: "Close"
+};
 Modal.__docgenInfo = {
@@ -822,3 +825,7 @@ "description": "",
       "required": false,
-      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized"
+      "description": "ARIA label attribute for the close button if/when headerChildren\nare not utilized, also used for the title attribute",
+      "defaultValue": {
+        "value": "\"Close\"",
+        "computed": false
+      }
     },
@@ -825,0 +832,0 @@ "headerChildren": {

CHANGELOG.md

@@ -0,1 +1,8 @@
+# [@hig/modal-v2.2.2](https://github.com/Autodesk/hig/compare/@hig/modal@2.2.1...@hig/modal@2.2.2) (2020-11-17)
+
+
+### Bug Fixes
+
+* pass closeButtonAriaLabel to title attribute ([b9348f9](https://github.com/Autodesk/hig/commit/b9348f9))
+
 # [@hig/modal-v2.2.1](https://github.com/Autodesk/hig/compare/@hig/modal@2.2.0...@hig/modal@2.2.1) (2020-05-13)
@@ -2,0 +9,0 @@

package.json

 {
   "name": "@hig/modal",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "HIG Modal",
@@ -22,4 +22,4 @@ "author": "Autodesk Inc.",
     "@hig/icons": "^3.2.0",
+    "@hig/typography": "^1.1.0",
     "@hig/utils": "^0.4.0",
-    "@hig/typography": "^1.0.3",
     "emotion": "^10.0.0",
@@ -30,4 +30,4 @@ "prop-types": "^15.7.1",
   "peerDependencies": {
-    "@hig/theme-context": "^3.0.0",
-    "@hig/theme-data": "^2.16.0",
+    "@hig/theme-context": "^3.0.1",
+    "@hig/theme-data": "^2.18.0",
     "react": "^15.4.1 || ^16.3.2"
@@ -40,4 +40,3 @@ },
     "@hig/scripts": "^0.1.2",
-    "@hig/semantic-release-config": "^0.1.0",
-    "lodash.merge": "^4.4.0"
+    "@hig/semantic-release-config": "^0.1.0"
   },
@@ -44,0 +43,0 @@ "scripts": {

README.md

@@ -45,16 +45,16 @@ # Modal
 import Button from "@hig/button";
-import merge from "lodash.merge";
 
 function YourComponent() {
-  // ...
-  const modalStyles = styles =>
-    merge(styles, {
-      modal: {
-        bodyContent: {
-          display: "flex",
-          flexDirection: "column",
-          justifyContent: "space-between"
-        }
+  const modalStyles = styles => ({
+    ...styles,
+    modal: {
+      ...styles.modal,
+      bodyContent: {
+        ...styles.modal.bodyContent,
+        display: "flex",
+        flexDirection: "column",
+        justifyContent: "space-between"
       }
-    })
+    }
+  });
                                       
@@ -61,0 +61,0 @@ return (

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

69061

increased by1.18%

Dev dependency count

5

decreased by-16.67%

Lines of code

1570

increased by0.9%

Dependency changes

• Updated@hig/typography@^1.1.0