@highlight-ui/dialog - npm Package Compare versions

Comparing version 8.4.6 to 8.4.7

dist/cjs/index.js

@@ -63,14 +63,14 @@ 'use strict';
 var styles$1 = {
-  "dialog": "Dialog-module__2icvnh15__v8-4-6",
-  "size-small": "Dialog-module__3spVEVua__v8-4-6",
-  "size-medium": "Dialog-module__-zWxw4HX__v8-4-6",
-  "size-large": "Dialog-module__3wZ2NPV0__v8-4-6",
-  "header": "Dialog-module__2wAUH40a__v8-4-6",
-  "headerShadowed": "Dialog-module__xODFOi1M__v8-4-6",
-  "headerTitle": "Dialog-module__1lxoaZF6__v8-4-6",
-  "closeButton": "Dialog-module__2l9SSdo___v8-4-6",
-  "body": "Dialog-module__1bPY4avA__v8-4-6",
-  "footer": "Dialog-module__3o8NTS6m__v8-4-6",
-  "footerShadowed": "Dialog-module__1s03rY8s__v8-4-6",
-  "disabled": "Dialog-module__1TM_UCZw__v8-4-6"
+  "dialog": "Dialog-module__2icvnh15__v8-4-7",
+  "size-small": "Dialog-module__3spVEVua__v8-4-7",
+  "size-medium": "Dialog-module__-zWxw4HX__v8-4-7",
+  "size-large": "Dialog-module__3wZ2NPV0__v8-4-7",
+  "header": "Dialog-module__2wAUH40a__v8-4-7",
+  "headerShadowed": "Dialog-module__xODFOi1M__v8-4-7",
+  "headerTitle": "Dialog-module__1lxoaZF6__v8-4-7",
+  "closeButton": "Dialog-module__2l9SSdo___v8-4-7",
+  "body": "Dialog-module__1bPY4avA__v8-4-7",
+  "footer": "Dialog-module__3o8NTS6m__v8-4-7",
+  "footerShadowed": "Dialog-module__1s03rY8s__v8-4-7",
+  "disabled": "Dialog-module__1TM_UCZw__v8-4-7"
 };
@@ -116,6 +116,12 @@
 function visible(element) {
+  const isHidden = element.getAttribute("aria-hidden") || element.getAttribute("hidden") || element.getAttribute("type") === "hidden";
+
+  if (isHidden) {
+    return false;
+  }
+
   let parentElement = element;
 
   while (parentElement) {
-    if (parentElement === document.body) {
+    if (parentElement === document.body || parentElement.nodeType === 11) {
       break;
@@ -170,3 +176,4 @@ }
   const finalTabbable = tabbable[event.shiftKey ? 0 : tabbable.length - 1];
-  const leavingFinalTabbable = finalTabbable === document.activeElement || node === document.activeElement;
+  const root = node.getRootNode();
+  const leavingFinalTabbable = finalTabbable === root.activeElement || node === root.activeElement;
 
@@ -187,3 +194,5 @@ if (!leavingFinalTabbable) {
   const rootNodes = Array.from(document.querySelectorAll(selector)).map(node => {
-    if (node.contains(containerNode)) {
+    var _a;
+
+    if (((_a = node == null ? void 0 : node.shadowRoot) == null ? void 0 : _a.contains(containerNode)) || node.contains(containerNode)) {
       return void 0;
@@ -226,9 +235,14 @@ }
 
-    if (restoreAria.current) {
-      restoreAria.current();
+    if (node === null) {
+      return;
     }
 
+    restoreAria.current = createAriaHider(node);
+
+    if (ref.current === node) {
+      return;
+    }
+
     if (node) {
-      const processNode = _node => {
-        restoreAria.current = createAriaHider(_node);
+      const processNode = () => {
         let focusElement = node.querySelector("[data-autofocus]");
@@ -243,3 +257,5 @@
         if (focusElement) {
-          focusElement.focus();
+          focusElement.focus({
+            preventScroll: true
+          });
         } else if (process.env.NODE_ENV === "development") {
@@ -251,4 +267,4 @@ console.warn("[@mantine/hooks/use-focus-trap] Failed to find focusable element within provided node", node);
       setTimeout(() => {
-        if (node.ownerDocument) {
-          processNode(node);
+        if (node.getRootNode()) {
+          processNode();
         } else if (process.env.NODE_ENV === "development") {
@@ -277,2 +293,6 @@ console.warn("[@mantine/hooks/use-focus-trap] Ref node is not part of the dom", node);
       document.removeEventListener("keydown", handleKeyDown);
+
+      if (restoreAria.current) {
+        restoreAria.current();
+      }
     };
@@ -1409,6 +1429,6 @@ }, [active]);
 var styles = {
-  "modal": "Modal-module__i5Pbh60m__v8-4-6",
-  "modalBackdrop": "Modal-module__ZVIwEMrU__v8-4-6",
-  "modalContent": "Modal-module__3UHa_kcB__v8-4-6",
-  "scrollLocked": "Modal-module__1T2Qjbem__v8-4-6"
+  "modal": "Modal-module__i5Pbh60m__v8-4-7",
+  "modalBackdrop": "Modal-module__ZVIwEMrU__v8-4-7",
+  "modalContent": "Modal-module__3UHa_kcB__v8-4-7",
+  "scrollLocked": "Modal-module__1T2Qjbem__v8-4-7"
 };
@@ -1415,0 +1435,0 @@

dist/esm/index.js

@@ -39,14 +39,14 @@ import React, { useRef, useEffect, useCallback, useState } from 'react';
 var styles$1 = {
-  "dialog": "Dialog-module__2icvnh15__v8-4-6",
-  "size-small": "Dialog-module__3spVEVua__v8-4-6",
-  "size-medium": "Dialog-module__-zWxw4HX__v8-4-6",
-  "size-large": "Dialog-module__3wZ2NPV0__v8-4-6",
-  "header": "Dialog-module__2wAUH40a__v8-4-6",
-  "headerShadowed": "Dialog-module__xODFOi1M__v8-4-6",
-  "headerTitle": "Dialog-module__1lxoaZF6__v8-4-6",
-  "closeButton": "Dialog-module__2l9SSdo___v8-4-6",
-  "body": "Dialog-module__1bPY4avA__v8-4-6",
-  "footer": "Dialog-module__3o8NTS6m__v8-4-6",
-  "footerShadowed": "Dialog-module__1s03rY8s__v8-4-6",
-  "disabled": "Dialog-module__1TM_UCZw__v8-4-6"
+  "dialog": "Dialog-module__2icvnh15__v8-4-7",
+  "size-small": "Dialog-module__3spVEVua__v8-4-7",
+  "size-medium": "Dialog-module__-zWxw4HX__v8-4-7",
+  "size-large": "Dialog-module__3wZ2NPV0__v8-4-7",
+  "header": "Dialog-module__2wAUH40a__v8-4-7",
+  "headerShadowed": "Dialog-module__xODFOi1M__v8-4-7",
+  "headerTitle": "Dialog-module__1lxoaZF6__v8-4-7",
+  "closeButton": "Dialog-module__2l9SSdo___v8-4-7",
+  "body": "Dialog-module__1bPY4avA__v8-4-7",
+  "footer": "Dialog-module__3o8NTS6m__v8-4-7",
+  "footerShadowed": "Dialog-module__1s03rY8s__v8-4-7",
+  "disabled": "Dialog-module__1TM_UCZw__v8-4-7"
 };
@@ -92,6 +92,12 @@
 function visible(element) {
+  const isHidden = element.getAttribute("aria-hidden") || element.getAttribute("hidden") || element.getAttribute("type") === "hidden";
+
+  if (isHidden) {
+    return false;
+  }
+
   let parentElement = element;
 
   while (parentElement) {
-    if (parentElement === document.body) {
+    if (parentElement === document.body || parentElement.nodeType === 11) {
       break;
@@ -146,3 +152,4 @@ }
   const finalTabbable = tabbable[event.shiftKey ? 0 : tabbable.length - 1];
-  const leavingFinalTabbable = finalTabbable === document.activeElement || node === document.activeElement;
+  const root = node.getRootNode();
+  const leavingFinalTabbable = finalTabbable === root.activeElement || node === root.activeElement;
 
@@ -163,3 +170,5 @@ if (!leavingFinalTabbable) {
   const rootNodes = Array.from(document.querySelectorAll(selector)).map(node => {
-    if (node.contains(containerNode)) {
+    var _a;
+
+    if (((_a = node == null ? void 0 : node.shadowRoot) == null ? void 0 : _a.contains(containerNode)) || node.contains(containerNode)) {
       return void 0;
@@ -202,9 +211,14 @@ }
 
-    if (restoreAria.current) {
-      restoreAria.current();
+    if (node === null) {
+      return;
     }
 
+    restoreAria.current = createAriaHider(node);
+
+    if (ref.current === node) {
+      return;
+    }
+
     if (node) {
-      const processNode = _node => {
-        restoreAria.current = createAriaHider(_node);
+      const processNode = () => {
         let focusElement = node.querySelector("[data-autofocus]");
@@ -219,3 +233,5 @@
         if (focusElement) {
-          focusElement.focus();
+          focusElement.focus({
+            preventScroll: true
+          });
         } else if (process.env.NODE_ENV === "development") {
@@ -227,4 +243,4 @@ console.warn("[@mantine/hooks/use-focus-trap] Failed to find focusable element within provided node", node);
       setTimeout(() => {
-        if (node.ownerDocument) {
-          processNode(node);
+        if (node.getRootNode()) {
+          processNode();
         } else if (process.env.NODE_ENV === "development") {
@@ -253,2 +269,6 @@ console.warn("[@mantine/hooks/use-focus-trap] Ref node is not part of the dom", node);
       document.removeEventListener("keydown", handleKeyDown);
+
+      if (restoreAria.current) {
+        restoreAria.current();
+      }
     };
@@ -1385,6 +1405,6 @@ }, [active]);
 var styles = {
-  "modal": "Modal-module__i5Pbh60m__v8-4-6",
-  "modalBackdrop": "Modal-module__ZVIwEMrU__v8-4-6",
-  "modalContent": "Modal-module__3UHa_kcB__v8-4-6",
-  "scrollLocked": "Modal-module__1T2Qjbem__v8-4-6"
+  "modal": "Modal-module__i5Pbh60m__v8-4-7",
+  "modalBackdrop": "Modal-module__ZVIwEMrU__v8-4-7",
+  "modalContent": "Modal-module__3UHa_kcB__v8-4-7",
+  "scrollLocked": "Modal-module__1T2Qjbem__v8-4-7"
 };
@@ -1391,0 +1411,0 @@

package.json

 {
   "name": "@highlight-ui/dialog",
-  "version": "8.4.6",
+  "version": "8.4.7",
   "author": "Personio GmbH & Co. KG",
@@ -38,7 +38,3 @@ "main": "dist/cjs/index.js",
     "@testing-library/user-event": "^13.2.1",
-    "@types/lodash.debounce": "4.0.7",
-    "@types/lodash.groupby": "4.6.7",
     "@types/lodash.invoke": "4.5.7",
-    "@types/lodash.times": "4.3.7",
-    "@types/lodash.topairs": "4.3.7",
     "classnames": "^2.3.1",
@@ -52,14 +48,10 @@ "jest": "^27.2.3",
     "@highlight-ui/icon": "^4.1.3",
-    "@highlight-ui/tooltip": "^3.3.23",
+    "@highlight-ui/tooltip": "^3.3.24",
     "@highlight-ui/typography": "^5.2.12",
     "@highlight-ui/utils-commons": "^2.3.3",
     "@highlight-ui/utils-hooks": "^3.2.15",
-    "@highlight-ui/utils-portal-manager": "^3.1.5",
-    "@mantine/hooks": "^4.2.1",
+    "@highlight-ui/utils-portal-manager": "^3.1.6",
+    "@mantine/hooks": "5.10.2",
     "@use-it/event-listener": "^0.1.6",
-    "lodash.debounce": "4.0.8",
-    "lodash.groupby": "4.6.0",
-    "lodash.invoke": "4.5.2",
-    "lodash.times": "4.3.2",
-    "lodash.topairs": "4.3.0"
+    "lodash.invoke": "4.5.2"
   },
@@ -70,3 +62,3 @@ "peerDependencies": {
   },
-  "gitHead": "04f3f8e000850bdbdb51bba0aa09afda35c3f699"
+  "gitHead": "e9e0c85f77f561f26cfaaf31f5e10709562b0ea9"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

282048

increased by1.05%

Dependency count

12

decreased by-25%

Dev dependency count

14

decreased by-22.22%

Lines of code

3022

increased by0.94%

Dependency changes

• + Added@mantine/hooks@5.10.2(transitive)

• - Removedlodash.debounce@4.0.8

• - Removedlodash.groupby@4.6.0

• - Removedlodash.times@4.3.2

• - Removedlodash.topairs@4.3.0

• - Removed@mantine/hooks@4.2.12(transitive)

• - Removedlodash.groupby@4.6.0(transitive)

• - Removedlodash.times@4.3.2(transitive)

• - Removedlodash.topairs@4.3.0(transitive)

• Updated@highlight-ui/tooltip@^3.3.24

• Updated@highlight-ui/utils-portal-manager@^3.1.6

• Updated@mantine/hooks@5.10.2